From: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
To: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Nuke skl_update_plane debug message from the pipe update critical section
Date: Wed, 8 Mar 2017 14:26:24 +0100 [thread overview]
Message-ID: <fc279031-0acf-cb07-f96b-1d093943ae9d@linux.intel.com> (raw)
In-Reply-To: <20170308131218.GF31595@intel.com>
Op 08-03-17 om 14:12 schreef Ville Syrjälä:
> On Wed, Mar 08, 2017 at 01:00:07PM +0100, Maarten Lankhorst wrote:
>> printks are slow so we should not be doing them from the vblank evade
>> critical section. These could explain why we sometimes seem to
>> blow past our 100 usec deadline.
>>
>> The problem has been there ever since commit bfd16b2a23dc ("drm/i915:
>> Make updating pipe without modeset atomic.")
> I guess that part isn't actually true as far as this printk is
> concerned?
>
> Maybe commit 331879ce8ea ("drm/i915: skylake sprite plane scaling
> using shared scalers")?
Indeed, too much copy paste. Thanks for review.
~Maarten
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2017-03-08 13:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-08 12:00 [PATCH] drm/i915: Nuke skl_update_plane debug message from the pipe update critical section Maarten Lankhorst
2017-03-08 13:12 ` Ville Syrjälä
2017-03-08 13:26 ` Maarten Lankhorst [this message]
2017-03-09 10:42 ` Maarten Lankhorst
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fc279031-0acf-cb07-f96b-1d093943ae9d@linux.intel.com \
--to=maarten.lankhorst@linux.intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.