From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C12EAC25B75 for ; Thu, 23 May 2024 23:11:32 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.728930.1134018 (Exim 4.92) (envelope-from ) id 1sAHah-0005yi-Ou; Thu, 23 May 2024 23:11:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 728930.1134018; Thu, 23 May 2024 23:11:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1sAHah-0005yb-KK; Thu, 23 May 2024 23:11:19 +0000 Received: by outflank-mailman (input) for mailman id 728930; Thu, 23 May 2024 23:11:18 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1sAHag-0005yV-9m for xen-devel@lists.xenproject.org; Thu, 23 May 2024 23:11:18 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1sAHaf-0008I4-W3; Thu, 23 May 2024 23:11:17 +0000 Received: from gw1.octic.net ([88.97.20.152] helo=[10.0.1.244]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1sAHaf-0001oZ-Qd; Thu, 23 May 2024 23:11:17 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=EwDu3x4EZ7cn1iaD41BLePUbCeqetI5jMQx2kpFydyo=; b=5+q/n0sqtgiM06k6YSoKLLTjyh l2/VwMwKZjrU2RY94YW7bsR9kN7HX484zTP0CbX19S7HiEgKotNIpXMVFVRZIudM9tI4ZsYJ+Z24I ITmxAzGMlXjl5qQIDKybBCdAsEIItXwAggvOspygw7X43NHylS43KFnN431gws8sX2ZE=; Message-ID: Date: Fri, 24 May 2024 00:11:16 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 8/9] tools: Introduce the "xl dt-overlay {attach,detach}" commands Content-Language: en-GB To: Henry Wang , xen-devel@lists.xenproject.org Cc: Anthony PERARD , Juergen Gross , Jason Andryuk References: <20240523074040.1611264-1-xin.wang2@amd.com> <20240523074040.1611264-9-xin.wang2@amd.com> From: Julien Grall In-Reply-To: <20240523074040.1611264-9-xin.wang2@amd.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Henry, On 23/05/2024 08:40, Henry Wang wrote: > With the XEN_DOMCTL_dt_overlay DOMCTL added, users should be able to > attach/detach devices from the provided DT overlay to domains. > Support this by introducing a new set of "xl dt-overlay" commands and > related documentation, i.e. "xl dt-overlay {attach,detach}". Slightly > rework the command option parsing logic. > > Signed-off-by: Henry Wang > Reviewed-by: Jason Andryuk > --- > v4: > - Add Jason's Reviewed-by tag. > v3: > - Introduce new API libxl_dt_overlay_domain() and co., instead of > reusing existing API libxl_dt_overlay(). > - Add in-code comments for the LIBXL_DT_OVERLAY_* macros. > - Use find_domain() to avoid getting domain_id from strtol(). > v2: > - New patch. > --- > tools/include/libxl.h | 10 +++++++ > tools/include/xenctrl.h | 3 +++ > tools/libs/ctrl/xc_dt_overlay.c | 31 +++++++++++++++++++++ > tools/libs/light/libxl_dt_overlay.c | 28 +++++++++++++++++++ > tools/xl/xl_cmdtable.c | 4 +-- > tools/xl/xl_vmcontrol.c | 42 ++++++++++++++++++++--------- > 6 files changed, 104 insertions(+), 14 deletions(-) > > diff --git a/tools/include/libxl.h b/tools/include/libxl.h > index 62cb07dea6..6cc6d6bf6a 100644 > --- a/tools/include/libxl.h > +++ b/tools/include/libxl.h I think you also need to introduce LIBXL_HAVE_... Cheers, -- Julien Grall