From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 71D8DC4321E for ; Sun, 4 Dec 2022 14:33:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229908AbiLDOdI (ORCPT ); Sun, 4 Dec 2022 09:33:08 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46496 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229753AbiLDOdG (ORCPT ); Sun, 4 Dec 2022 09:33:06 -0500 Received: from node.akkea.ca (li1434-30.members.linode.com [45.33.107.30]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3CD9BDFA4 for ; Sun, 4 Dec 2022 06:33:01 -0800 (PST) Received: from localhost (localhost [127.0.0.1]) by node.akkea.ca (Postfix) with ESMTP id 815474E2006; Sun, 4 Dec 2022 14:33:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=akkea.ca; s=mail; t=1670164381; bh=jRV688Ot1KbuXYNIt8OfX89PW4wirLG5WyXVCsHx4nc=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=PHvacv3lVCrhPcqJV+esW8IVh5u9owpP7uXZGuflHca82iL4E0cmFAPbippX714DL bg2uFCmUX/bxLeiBPkZX7GfrnpTuKjZcaOE+uAnmj9QZ9AgDlqBR6Jnpvms0c0UI+Q e7BvtzKd6yhXYUfMqD491AccfvlUWBJbxZxFIpGU= X-Virus-Scanned: Debian amavisd-new at mail.akkea.ca Received: from node.akkea.ca ([127.0.0.1]) by localhost (mail.akkea.ca [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id OKVf-ubt7EEz; Sun, 4 Dec 2022 14:33:00 +0000 (UTC) Received: from www.akkea.ca (localhost [127.0.0.1]) by node.akkea.ca (Postfix) with ESMTP id BCD3A4E2003; Sun, 4 Dec 2022 14:33:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=akkea.ca; s=mail; t=1670164380; bh=jRV688Ot1KbuXYNIt8OfX89PW4wirLG5WyXVCsHx4nc=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=vUEqpQ2TyGzgkBxrsw+LWs5wxpOM9zBDVAUnbVwKvZAyFnLNmpVeFuinDJAlUgM9j tcNKSmVPFMOaFy/HayjL1vIcGuqlXK07/BiUsu+ezjXmJeMJfk1WbPphPUCsZ+TDeo 2vLrp0m4m22XFBbA8iF19LkugYGhKGkXvwbe56Pg= MIME-Version: 1.0 Date: Sun, 04 Dec 2022 06:33:00 -0800 From: Angus Ainslie To: Arend Van Spriel Cc: Andy Green , Shengyu Qu , franky.lin@broadcom.com, linux-wireless@vger.kernel.org Subject: Re: AP6275 / bcm43752 pcie on mainline brcmf In-Reply-To: <184d8f5fab0.279b.9b12b7fc0a3841636cfb5e919b41b954@broadcom.com> References: <08416710-655a-c87c-a599-3fe2563f7de4@warmcat.com> <18470a1e910.279b.9b12b7fc0a3841636cfb5e919b41b954@broadcom.com> <184720fc920.279b.9b12b7fc0a3841636cfb5e919b41b954@broadcom.com> <625f1d5d-e137-7ad7-96b9-92035e87df8b@broadcom.com> <638afa8e-a393-410c-3182-0d8e9b6da17d@warmcat.com> <7bf5884906b1abc30adebd3c915a3259@akkea.ca> <18486ca8490.279b.9b12b7fc0a3841636cfb5e919b41b954@broadcom.com> <3163e341-bcfc-a2c3-f0e1-5b62c9da2f43@broadcom.com> <852dcabac6bd70a7d55b5ea3f6b0df20@akkea.ca> <184d89525a0.279b.9b12b7fc0a3841636cfb5e919b41b954@broadcom.com> <184d8f5fab0.279b.9b12b7fc0a3841636cfb5e919b41b954@broadcom.com> Message-ID: X-Sender: angus@akkea.ca User-Agent: Roundcube Webmail/1.3.17 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On 2022-12-03 09:08, Arend Van Spriel wrote: > On December 3, 2022 4:37:19 PM Angus Ainslie wrote: > >> On 2022-12-03 07:22, Arend Van Spriel wrote: >>> On December 3, 2022 2:56:39 PM Angus Ainslie wrote: >>> >>>> On 2022-11-29 11:48, Arend van Spriel wrote: >>>>> On 11/17/2022 7:36 PM, Angus Ainslie wrote: >>>>>> On 2022-11-17 10:12, Arend Van Spriel wrote: >>>>>>> On November 17, 2022 5:06:25 PM Angus Ainslie >>>>>>> wrote: >>>>>>> >>>>>>>> On 2022-11-17 04:01, Andy Green wrote: >>>>>>>>> On 11/17/22 09:23, Arend van Spriel wrote: >>>>>>>>>> On 11/16/2022 1:25 PM, Shengyu Qu wrote: >>>>>>>>>>> Got a new version of downstream driver and firmware here: >>>>>>>>>>> https://gitlab.com/rk3588_linux/linux/external/rkwifibt/-/tree/linux-5.10-gen-rkr3.4 >>>>>>>>>> >>>>>>>>>> Thanks for that. The firmware indeed seems to originate from >>>>>>>>>> Synaptics >>>>>>>>>> and this module can be found on wifi-alliance product finder: >>>>>>>>>> >>>>>>>>>> https://www.wi-fi.org/product-finder-results?sort_by=certified&sort_order=desc&keywords=ap6275 >>>>>>>>>> >>>>>>>>>> We have no known contacts there and they do not seem to have >>>>>>>>>> much >>>>>>>>>> interest in open-source. In that gitlab repo I see they are >>>>>>>>>> providing >>>>>>>>>> bcmdhd driver and I assume they consider that sufficient. >>>>>>>>>> >>>>>>>>>> Will see what I can do. First have to think on how to approach >>>>>>>>>> this >>>>>>>>>> failure to get most out of a debug effort. I do not have the >>>>>>>>>> module >>>>>>>>>> over here so we would need to go back and forth. The fact that >>>>>>>>>> the >>>>>>>>>> issue is seen on both SDIO and PCIe is somewhat encouraging. >>>>>>>>> >>>>>>>>> Yes it seems that at some point with some firmware, SDIO has >>>>>>>>> worked >>>>>>>>> for, eg, Angus. And, it should work well with bchdhd (but that >>>>>>>>> does >>>>>>>>> not seem to work for scan for me on v6.1-rc5 uplevel with the >>>>>>>>> firmware >>>>>>>>> load changed to use kernel apis; but the firmware has no >>>>>>>>> timeout >>>>>>>>> on >>>>>>>>> bcmdhd). So it doesn't feel a million miles away. >>>>>>>> >>>>>>>> This is the firmware we have been using for SDIO. It was sent to >>>>>>>> us >>>>>>>> directly by SparkLAN so not sure how it compares to other >>>>>>>> variants. >>>>>>>> >>>>>>>> https://source.puri.sm/Librem5/firmware-brcm43752-nonfree/-/tree/master/firmware/brcm >>>>>>> >>>>>>> It is a tad bit older: >>>>>>> >>>>>>> $ strings brcmfmac43752-sdio.bin | grep FW-TAG >>>>>>> 4362a2-roml/config_sdio_ampak_release_he >>>>>>> Version=18.35.387.23.7 (b328500@shgit) (wlan=r880297) >>>>>>> Date=2020-07-13T10:34:00Z FWID=01-f50fdff0 >>>>>> >>>>>> Currently it's broken for hotspot mode but I haven't had the >>>>>> chance >>>>>> to >>>>>> see if that is FW or something further up the stack. >>>>> >>>>> Hi Angus, >>>>> >>>>> When you added support for this device in brcmfmac you marked it as >>>>> a >>>>> Cypress device. Are you sure about that? AFAICT this device is >>>>> coming >>>>> from Synaptics. >>>> >>>> Hi Arend, >>>> >>>> I assumed Cypress based on the fact that it most closely resembled >>>> the >>>> 4373 from the driver side. >>> >>> Right. Both are based on the same chip architecture that they brought >>> from Broadcom so the similarities are not surprising. >>> >>>> How would I figure out whether it's Cypress or Synaptics ? >>>> >>>> When I search the web for it I only find SparkLAN or "AMPAK >>>> technology" >>>> references. >>> >>> Earlier my colleague Franky found this link to WFA certificate: >>> >>> https://api.cert.wi-fi.org/api/certificate/download/public?variantId=103641 >>> >>> WFA and FCC are usually good sources of info. Also the product pages >>> of the vendors are worth checking. I have them bookmarked out of >>> professional interest ;-) >> >> I did find FCC references but those seemed ambiguous as well. Thanks >> for >> the wi-fi.org link. >> >> Should I send a patch renaming SDIO_DEVICE_ID_BROADCOM_CYPRESS_43752 >> -> >> SDIO_DEVICE_ID_BROADCOM_43752 ? > > Feel free to do so. I have some cleanup work queued up so I can also > take care of it. > If you're already going to be in there it would be great if you could clean it up. Thanks Angus > Regards, > Arend