From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=uw4O7MqRRH6cjz2l6gKUwYcEyZ2QUkzUVsKtVcx8rjI=; b=mZmMn6v+jyVFq6LE8sQEoQPCMcREcYBbxccgehmz7Os7iDLMP7vXOuyIN748uFCZjA FusniR3VNhik5BL+CoWXpwd9puyrCbLeGfK4JrCc40fGh1HQdma8eCF7ZHgEeXQPFLlX UPSFPFo2Pcs7NsGLhXOupC1niZuRfNmzlZWahfSVvcnCHkB3Pahq6HJ8RtfFLoVVje0W MWo4rnV9GMSX8o+A5aFvof40WyN7/15CZ5Q1aG8nLODAmAuBsNojeeLZv0mbY329U5og afhKbaRoSju3Elw70OIlsUwsamBsct/5oEHFZ64WMVy/EzQ6YxK9Z23iF6Q3U3KGlmGs fb7w== References: <1507093134-20406-1-git-send-email-dsahern@gmail.com> <1507093134-20406-7-git-send-email-dsahern@gmail.com> <20171004081357.37bfd941@xeon-e3> From: David Ahern Message-ID: Date: Wed, 4 Oct 2017 09:16:20 -0700 MIME-Version: 1.0 In-Reply-To: <20171004081357.37bfd941@xeon-e3> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Bridge] [PATCH net-next 6/7] net: bridge: Pass extack to down to netdev_master_upper_dev_link List-Id: Linux Ethernet Bridging List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stephen Hemminger Cc: netdev@vger.kernel.org, bridge@lists.linux-foundation.org, idosch@mellanox.com, jiri@mellanox.com, vfalico@gmail.com, j.vosburgh@gmail.com, davem@davemloft.net On 10/4/17 8:13 AM, Stephen Hemminger wrote: > On Tue, 3 Oct 2017 21:58:53 -0700 > David Ahern wrote: > >> Pass extack arg to br_add_if. Add messages for a couple of failures >> and pass arg to netdev_master_upper_dev_link. >> >> Signed-off-by: David Ahern > > This looks good. You might want to pass the netlink_ext_ack down as > an immutable pointer (const). Can't mark extack as const. The NL_SET_ERR_MSG sets _msg to the passed in string. > > Acked-by: Stephen Hemminger > From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Ahern Subject: Re: [PATCH net-next 6/7] net: bridge: Pass extack to down to netdev_master_upper_dev_link Date: Wed, 4 Oct 2017 09:16:20 -0700 Message-ID: References: <1507093134-20406-1-git-send-email-dsahern@gmail.com> <1507093134-20406-7-git-send-email-dsahern@gmail.com> <20171004081357.37bfd941@xeon-e3> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, j.vosburgh@gmail.com, vfalico@gmail.com, andy@greyhouse.net, jiri@mellanox.com, idosch@mellanox.com, davem@davemloft.net, bridge@lists.linux-foundation.org To: Stephen Hemminger Return-path: Received: from mail-pg0-f67.google.com ([74.125.83.67]:34459 "EHLO mail-pg0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750937AbdJDQQT (ORCPT ); Wed, 4 Oct 2017 12:16:19 -0400 Received: by mail-pg0-f67.google.com with SMTP id u27so13507120pgn.1 for ; Wed, 04 Oct 2017 09:16:19 -0700 (PDT) In-Reply-To: <20171004081357.37bfd941@xeon-e3> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 10/4/17 8:13 AM, Stephen Hemminger wrote: > On Tue, 3 Oct 2017 21:58:53 -0700 > David Ahern wrote: > >> Pass extack arg to br_add_if. Add messages for a couple of failures >> and pass arg to netdev_master_upper_dev_link. >> >> Signed-off-by: David Ahern > > This looks good. You might want to pass the netlink_ext_ack down as > an immutable pointer (const). Can't mark extack as const. The NL_SET_ERR_MSG sets _msg to the passed in string. > > Acked-by: Stephen Hemminger >