From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 97EE3C64ED6 for ; Tue, 28 Feb 2023 14:05:09 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.503384.775637 (Exim 4.92) (envelope-from ) id 1pX0bC-0003gY-2y; Tue, 28 Feb 2023 14:04:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 503384.775637; Tue, 28 Feb 2023 14:04:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pX0bC-0003gR-09; Tue, 28 Feb 2023 14:04:58 +0000 Received: by outflank-mailman (input) for mailman id 503384; Tue, 28 Feb 2023 14:04:56 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pX0bA-0003gL-Ji for xen-devel@lists.xenproject.org; Tue, 28 Feb 2023 14:04:56 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pX0b9-0002MQ-4E; Tue, 28 Feb 2023 14:04:55 +0000 Received: from 54-240-197-227.amazon.com ([54.240.197.227] helo=[192.168.12.216]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pX0b8-0006sm-U3; Tue, 28 Feb 2023 14:04:55 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=9bdTtz8ajUjFXClJC1OngUeqd7zfvR7ia3k1e8SbcWE=; b=vo9ABfVyqM7FAv+xJqB6j/9OWd ufS3DiXBSkdFS7RGdvVLvsic27S6p5u8YZGKRwO9qczvISyiXQWuc04qvF8pw/VKn+xQqlaO0w1Ff t2jBx+gov2ZI3tbB6UIdUcGavvyjxuhRyoHFPGIdv4ckj+o9GZhstO/dMVGp2CmJmG5I=; Message-ID: Date: Tue, 28 Feb 2023 14:04:52 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v3 2/4] xen: change to Content-Language: en-US To: Oleksii , xen-devel@lists.xenproject.org Cc: Jan Beulich , Andrew Cooper , Stefano Stabellini , Gianluca Guida , Bertrand Marquis , Volodymyr Babchuk , George Dunlap , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: <19404db4a577e17dffef85a101449a507965be19.1677233393.git.oleksii.kurochko@gmail.com> <468d6130-739e-4b0e-44e7-5aab520a0cac@xen.org> <319ddd67bca2291afe7f27cba3cf8eb4e1307747.camel@gmail.com> From: Julien Grall In-Reply-To: <319ddd67bca2291afe7f27cba3cf8eb4e1307747.camel@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 28/02/2023 12:38, Oleksii wrote: > Hi Julien, Hi, > On Sat, 2023-02-25 at 16:47 +0000, Julien Grall wrote: >> Hi Oleksii, >> >> On 24/02/2023 11:31, Oleksii Kurochko wrote: >>> Since the generic version of bug.h stuff was introduced use >>> >>> instead of unnecessary >>> >>> Signed-off-by: Oleksii Kurochko >>> --- >>> Changes in V3: >>>   * Update patch 2 not to break compilation: move some parts from >>> patches 3 and 4 >>>     to patch 2: >>>     * move some generic parts from to >>>     * add define BUG_FRAME_STRUCT in ARM's >>> --- >>> Changes in V2: >>>   * Put [PATCH v1 4/4] xen: change to as >>> second patch, >>>     update the patch to change all to among >>> the whole project >>>     to not break build. >>>   * Update the commit message. >>> --- >>>   xen/arch/arm/include/asm/bug.h       | 19 +++---------------- >>>   xen/arch/arm/include/asm/div64.h     |  2 +- >>>   xen/arch/arm/vgic/vgic-v2.c          |  2 +- >>>   xen/arch/arm/vgic/vgic.c             |  2 +- >>>   xen/arch/x86/acpi/cpufreq/cpufreq.c  |  2 +- >>>   xen/arch/x86/include/asm/asm_defns.h |  2 +- >>>   xen/arch/x86/include/asm/bug.h       | 19 ++----------------- >>>   xen/drivers/cpufreq/cpufreq.c        |  2 +- >>>   xen/include/xen/lib.h                |  2 +- >>>   9 files changed, 12 insertions(+), 40 deletions(-) >>> >>> diff --git a/xen/arch/arm/include/asm/bug.h >>> b/xen/arch/arm/include/asm/bug.h >>> index f4088d0913..cacaf014ab 100644 >>> --- a/xen/arch/arm/include/asm/bug.h >>> +++ b/xen/arch/arm/include/asm/bug.h >>> @@ -1,6 +1,8 @@ >>>   #ifndef __ARM_BUG_H__ >>>   #define __ARM_BUG_H__ >>> >>> +#include >> >> You are not adding new code in bug.h, so can you explain why this is >> now >> necessary? >> >>> + >>>   #if defined(CONFIG_ARM_32) >>>   # include >>>   #elif defined(CONFIG_ARM_64) >>> @@ -9,9 +11,7 @@ >>>   # error "unknown ARM variant" >>>   #endif >>> >>> -#define BUG_DISP_WIDTH    24 >>> -#define BUG_LINE_LO_WIDTH (31 - BUG_DISP_WIDTH) >>> -#define BUG_LINE_HI_WIDTH (31 - BUG_DISP_WIDTH) >> >> Even if the values are the same as the one you defined in the common >> bug.h, it doesn't feel right to remove them as long as... >> >>> +#define BUG_FRAME_STRUCT >> >> the arch is defining BUG_FRAME_STRUCT. So I would say the generic one >> should be defined within BUG_FRAME_STRUCT. >> > One of the reason BUG_DISP_WIDTH, BUG_LINE_* were removed is that they > don't use in ARM at all... Hmmm ok. But this sort of things should have been documented in the commit message even thought it doesn't feel this is related to what the patch is doing. Cheers, -- Julien Grall