From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: Denis Benato <denis.benato@linux.dev>
Cc: LKML <linux-kernel@vger.kernel.org>,
platform-driver-x86@vger.kernel.org,
Hans de Goede <hansg@kernel.org>,
"Luke D . Jones" <luke@ljones.dev>,
Mateusz Schyboll <dragonn@op.pl>,
Denis Benato <benato.denis96@gmail.com>
Subject: Re: [PATCH v4 0/3] platform/x86: asus-wmi: move keyboard control firmware attributes
Date: Mon, 26 Jan 2026 14:56:01 +0200 (EET) [thread overview]
Message-ID: <fc8a3843-0f04-ecd7-b30f-d53dbf3fc7e2@linux.intel.com> (raw)
In-Reply-To: <52704f4d-37f4-4eb5-998e-25e098ceef54@linux.dev>
On Mon, 26 Jan 2026, Denis Benato wrote:
> On 1/3/26 00:43, Denis Benato wrote:
> >
> > I was recently reading through the asusctl issue tracker and I found
> > out that some users have been having troubles with the keyboard RGB control
> > that was working before since the creation of asus-armoury and subequent
> > deprecation of old sysfs attributes.
> >
> > This patch series aims to re-introduce those attributes in asus-armoury
> > so that userspace tools can still control keyboard RGB lighting
> > without having to rely on deprecated asus-wmi attributes.
> >
> > In addition to that, since disabling OOBE is essential for controlling
> > LEDs on some models and it was incorrectly tied to deprecated attributes,
> > this patch series also fixes sending OOBE at probe time.
> >
> > Link: https://gitlab.com/asus-linux/asusctl/-/issues/619
> Hi Ilpo, please disregard everything in this patch series except the OOBE fix:
> that fix is important and I see it has been picked up.
>
> It's probably much better not to touch keyboard modes without a rework
> of the associated RGB interface: it doesn't make sense to move only the
> power state and I already saw there have been reported problems
> with TUFs.
>
> The original problem I was trying to solve is better solved another way
> via userspace saving the last setting with the interface already provided.
Yes, OOBE fix is now in Linus' tree.
The other 2 patches eliminated from the patchwork queue, thanks.
--
i.
prev parent reply other threads:[~2026-01-26 12:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-02 23:43 [PATCH v4 0/3] platform/x86: asus-wmi: move keyboard control firmware attributes Denis Benato
2026-01-02 23:43 ` [PATCH v4 1/3] platform/x86: asus-wmi: explicitly mark more code with CONFIG_ASUS_WMI_DEPRECATED_ATTRS Denis Benato
2026-01-02 23:43 ` [PATCH v4 2/3] platform/x86: asus-wmi: fix sending OOBE at probe Denis Benato
2026-01-02 23:43 ` [PATCH v4 3/3] platform/x86: asus-armoury: add keyboard control firmware attributes Denis Benato
2026-01-12 20:49 ` [PATCH v4 0/3] platform/x86: asus-wmi: move " Denis Benato
2026-01-13 14:02 ` Ilpo Järvinen
2026-01-13 21:53 ` Denis Benato
2026-01-14 9:04 ` Ilpo Järvinen
2026-01-16 18:10 ` Denis Benato
2026-01-26 1:36 ` Denis Benato
2026-01-26 12:56 ` Ilpo Järvinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fc8a3843-0f04-ecd7-b30f-d53dbf3fc7e2@linux.intel.com \
--to=ilpo.jarvinen@linux.intel.com \
--cc=benato.denis96@gmail.com \
--cc=denis.benato@linux.dev \
--cc=dragonn@op.pl \
--cc=hansg@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luke@ljones.dev \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.