From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pierre-Louis Bossart Subject: Re: [PATCH V2] ASoC: SOF: Fix build error with CONFIG_SND_SOC_SOF_NOCODEC=m Date: Fri, 10 May 2019 11:24:18 -0500 Message-ID: References: <20190510023657.8960-1-yuehaibing@huawei.com> <20190510132940.28184-1-yuehaibing@huawei.com> <9284cd65-98e3-5f7e-1427-8245dd84edcd@linux.intel.com> <34a5afbc-c165-78aa-0269-7362b523195a@huawei.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <34a5afbc-c165-78aa-0269-7362b523195a@huawei.com> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: YueHaibing , lgirdwood@gmail.com, broonie@kernel.org, perex@perex.cz, tiwai@suse.com, rdunlap@infradead.org Cc: linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org List-Id: alsa-devel@alsa-project.org On 5/10/19 8:50 AM, YueHaibing wrote: > On 2019/5/10 21:36, Pierre-Louis Bossart wrote: >> On 5/10/19 8:29 AM, YueHaibing wrote: >>> Fix gcc build error while CONFIG_SND_SOC_SOF_NOCODEC=m >>> >>> sound/soc/sof/core.o: In function `snd_sof_device_probe': >>> core.c:(.text+0x4af): undefined reference to `sof_nocodec_setup' >>> >>> Change IS_ENABLED to IS_REACHABLE to fix this. >> >> this just hides the issue instead of fixing it. >> please send the config+sha1 so that we can check. > > Sure, config sha1 5fdc79b550c1d850eee604aa58bad4d6da9223f0 Indeed there is an issue. will send a patch shortly to alsa-devel. Thanks for spotting this. > >> >>> >>> Reported-by: Hulk Robot >>> Suggested-by: Takashi Iwai >>> Fixes: c16211d6226d ("ASoC: SOF: Add Sound Open Firmware driver core") >>> Signed-off-by: YueHaibing >>> --- >>> V2: use IS_REACHABLE >>> --- >>> sound/soc/sof/core.c | 4 ++-- >>> 1 file changed, 2 insertions(+), 2 deletions(-) >>> >>> diff --git a/sound/soc/sof/core.c b/sound/soc/sof/core.c >>> index 32105e0..38e22f4 100644 >>> --- a/sound/soc/sof/core.c >>> +++ b/sound/soc/sof/core.c >>> @@ -259,7 +259,7 @@ int snd_sof_create_page_table(struct snd_sof_dev *sdev, >>> static int sof_machine_check(struct snd_sof_dev *sdev) >>> { >>> struct snd_sof_pdata *plat_data = sdev->pdata; >>> -#if IS_ENABLED(CONFIG_SND_SOC_SOF_NOCODEC) >>> +#if IS_REACHABLE(CONFIG_SND_SOC_SOF_NOCODEC) >>> struct snd_soc_acpi_mach *machine; >>> int ret; >>> #endif >>> @@ -267,7 +267,7 @@ static int sof_machine_check(struct snd_sof_dev *sdev) >>> if (plat_data->machine) >>> return 0; >>> -#if !IS_ENABLED(CONFIG_SND_SOC_SOF_NOCODEC) >>> +#if !IS_REACHABLE(CONFIG_SND_SOC_SOF_NOCODEC) >>> dev_err(sdev->dev, "error: no matching ASoC machine driver found - aborting probe\n"); >>> return -ENODEV; >>> #else >>> >> >> >> . >>