RE: [PATCH v8 2/2] mmc: support packed write command for eMMC4.5 device

[merez@codeaurora.org]

On Sun, July 8, 2012 4:52 pm, Seungwon Jeon wrote:
> Sunday, July 08, 2012, Maya <merez@codeaurora.org> wrote:
>> One minor comment below:
>>
>> > @@ -1278,9 +1609,15 @@ static int mmc_blk_issue_rw_rq(struct mmc_queue
>> *mq, struct request *rqc)
>> >  			    (card->ext_csd.data_sector_size == 4096)) {
>> You can use mmc_large_sec here (instead of
>> card->ext_csd.data_sector_size
>> == 4096)
> Yes, but this line is kept due to another issue related with 4KB sector.
>
> Thanks,
> Seungwon Jeon
Hi,

I'm not sure I understand your reply. mmc_large_sec does exactly what the
if here does.
My suggestion is to replace the code with the new function you added.
I agree it's an old code but this way the code will be consistent and
mmc_large_sec will be used in every place we would like to check if the
sector size is 4K.

Thanks,
Maya

-- 
Sent by consultant of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum