Re: [PATCH v3 2/3] fs/resctrl: Assign counters to existing groups when enabling mbm_event

["Moger, Babu" <bmoger@amd.com>]

Hi Reinette,

On 10/7/2026 5:21 PM, Reinette Chatre wrote:
> Hi Babu,
> 
> On 10/7/26 11:16 AM, Babu Moger wrote:
>> How about this?
>>
>> /*
>>   * rdtgroup_assign_cntrs() - Assign counters to MBM events.
>>   *
>>   * Each group can accommodate two counters per domain: one for the total
>>   * event and one for the local event. Assignments may fail due to the limited
>>   * number of counters. However, it is not necessary to return failure.
> 
> This drops the original motivation for why an error is not returned, leaving
> the claim that "it is not necessary" to return a failure without an explanation
> why.
> 
> An example that adds a motivation:
> 
>   /*
>    * rdtgroup_assign_cntrs() - Assign counters to enabled MBM events of a
>    *                         resource group
>    *
>    * Each group can accommodate two counters per domain: one for the total
>    * event and one for the local event. Assignments may fail due to the limited
>    * number of counters.
>    *
>    * Intended to be called in auto assignment scenarios ("mbm_assign_on_mkdir"
>    * enabled in "mbm_event" counter assignment mode) where counter assignment is
>    * not required to succeed. Thus no failure is returned. Users can modify the
>    * counter assignments afterwards if needed.
>    */
> 

Sounds good.
Thanks,
Babu