From: Rick Lindsley <ricklind@linux.vnet.ibm.com>
To: Johaan Smith <johaansmith74@gmail.com>,
Sukadev Bhattiprolu <sukadev@linux.ibm.com>
Cc: netdev@vger.kernel.org, Dany Madden <drt@linux.ibm.com>,
Rick Lindsley <ricklind@linux.ibm.com>,
Brian King <brking@linux.ibm.com>,
cforno12@linux.ibm.com, Abdul Haleem <abdhalee@in.ibm.com>
Subject: Re: [PATCH net 2/7] Revert "ibmvnic: remove duplicate napi_schedule call in open function"
Date: Thu, 24 Jun 2021 00:28:31 -0700 [thread overview]
Message-ID: <fcabc0b3-8b1f-3690-37ca-047ea34101e2@linux.vnet.ibm.com> (raw)
In-Reply-To: <CAJAjEthEoZk8LLWhhwMaTy0nrh5qaeY6ouUu--Uv2D_Zr+1pug@mail.gmail.com>
On 6/24/21 12:02 AM, Johaan Smith wrote:
> On Wed, Jun 23, 2021 at 11:17 PM Sukadev Bhattiprolu
> Sometimes git bisect may lead us to the false positives. Full investigation is
> always the best solution if it is not too hard.
I'd be happy to view evidence that points at another patch, if someone has some.
But the original patch did not address any observed problem:
"So there is no need for do_reset to call napi_schedule again
at the end of the function though napi_schedule will neglect
the request if napi is already scheduled."
Given that it fixed no problem but appears to have introduced one, the efficient
action is to revert it for now.
next prev parent reply other threads:[~2021-06-24 7:28 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-24 4:13 [PATCH net 0/7] ibmvnic: Assorted bug fixes Sukadev Bhattiprolu
2021-06-24 4:13 ` [PATCH net 1/7] Revert "ibmvnic: simplify reset_long_term_buff function" Sukadev Bhattiprolu
2021-06-24 6:07 ` Lijun Pan
2021-06-24 16:07 ` Sukadev Bhattiprolu
2021-06-24 4:13 ` [PATCH net 2/7] Revert "ibmvnic: remove duplicate napi_schedule call in open function" Sukadev Bhattiprolu
2021-06-24 6:20 ` Lijun Pan
2021-06-24 6:42 ` Rick Lindsley
2021-06-24 7:07 ` Rick Lindsley
2021-06-24 7:02 ` Johaan Smith
2021-06-24 7:28 ` Rick Lindsley [this message]
2021-06-24 17:05 ` Lijun Pan
2021-06-24 18:18 ` Dany Madden
2021-06-24 23:33 ` Rick Lindsley
2021-06-24 16:53 ` Lijun Pan
2021-06-24 4:13 ` [PATCH net 3/7] ibmvnic: clean pending indirect buffs during reset Sukadev Bhattiprolu
2021-06-24 4:13 ` [PATCH net 4/7] ibmvnic: account for bufs already saved in indir_buf Sukadev Bhattiprolu
2021-06-24 4:13 ` [PATCH net 5/7] ibmvnic: set ltb->buff to NULL after freeing Sukadev Bhattiprolu
2021-06-24 4:13 ` [PATCH net 6/7] ibmvnic: free tx_pool if tso_pool alloc fails Sukadev Bhattiprolu
2021-06-24 4:13 ` [PATCH net 7/7] ibmvnic: parenthesize a check Sukadev Bhattiprolu
2021-06-24 5:50 ` Lijun Pan
2021-06-24 18:30 ` [PATCH net 0/7] ibmvnic: Assorted bug fixes patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fcabc0b3-8b1f-3690-37ca-047ea34101e2@linux.vnet.ibm.com \
--to=ricklind@linux.vnet.ibm.com \
--cc=abdhalee@in.ibm.com \
--cc=brking@linux.ibm.com \
--cc=cforno12@linux.ibm.com \
--cc=drt@linux.ibm.com \
--cc=johaansmith74@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=ricklind@linux.ibm.com \
--cc=sukadev@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.