From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH] drm/i915/execlists: Move the assertion we have the rpm wakeref down Date: Thu, 19 Jul 2018 12:49:13 +0100 Message-ID: References: <20180719075029.28643-1-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTPS id 030AF6E205 for ; Thu, 19 Jul 2018 11:49:15 +0000 (UTC) In-Reply-To: <20180719075029.28643-1-chris@chris-wilson.co.uk> Content-Language: en-GB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Ck9uIDE5LzA3LzIwMTggMDg6NTAsIENocmlzIFdpbHNvbiB3cm90ZToKPiBUaGVyZSdzIGEgcmFj ZSBiZXR3ZWVuIGlkbGluZyB0aGUgZW5naW5lIGFuZCBmaW5pc2hpbmcgb2ZmIHRoZSBsYXN0Cj4g dGFza2xldCAoYXMgd2UgbWF5IGtpY2sgdGhlIHRhc2tsZXRzIGFmdGVyIGRlY2xhcmluZyBhbiBp bmRpdmlkdWFsCj4gZW5naW5lIGlkbGUpLiBIb3dldmVyLCBzaW5jZSB3ZSBkbyBub3QgbmVlZCB0 byBhY2Nlc3MgdGhlIGRldmljZSB1bnRpbAo+IHdlIHRyeSB0byBzdWJtaXQgdG8gdGhlIEVMU1Ag cmVnaXN0ZXIgKHByb2Nlc3NpbmcgdGhlIENTQiBqdXN0IHJlcXVpcmVzCj4gbm9ybWFsIENQVSBh Y2Nlc3MgdG8gdGhlIEhXU1AsIGFuZCB3aGVuIGlkbGUgd2Ugc2hvdWxkIG5vdCBuZWVkIHRvCj4g c3VibWl0ISkgd2UgY2FuIGRlZmVyIHRoZSBhc3NlcnRpb24gdW50byB0aGF0IHBvaW50LiBUaGUg YXNzZXJ0aW9uIGlzCj4gc3RpbGwgdXNlZnVsIGFzIGl0IGRvZXMgdmVyaWZ5IHRoYXQgd2UgZG8g aG9sZCB0aGUgbG9uZ3Rlcm0gR1Qgd2FrZXJlZgo+IHRha2VuIGZyb20gcmVxdWVzdCBhbGxvY2F0 aW9uIHVudGlsIHJlcXVlc3QgY29tcGxldGlvbi4KPiAKPiBCdWd6aWxsYTogaHR0cHM6Ly9idWdz LmZyZWVkZXNrdG9wLm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA3Mjc0Cj4gRml4ZXM6IDk1MTJmOTg1 YzMyZCAoImRybS9pOTE1L2V4ZWNsaXN0czogRGlyZWN0IHN1Ym1pc3Npb24gb2YgbmV3IHJlcXVl c3RzIChhdm9pZCB0YXNrbGV0L2tzb2Z0aXJxZCkiKQo+IFNpZ25lZC1vZmYtYnk6IENocmlzIFdp bHNvbiA8Y2hyaXNAY2hyaXMtd2lsc29uLmNvLnVrPgo+IENjOiBUdnJ0a28gVXJzdWxpbiA8dHZy dGtvLnVyc3VsaW5AaW50ZWwuY29tPgo+IC0tLQo+ICAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50 ZWxfbHJjLmMgfCAyNSArKysrKysrKysrKy0tLS0tLS0tLS0tLS0tCj4gICAxIGZpbGUgY2hhbmdl ZCwgMTEgaW5zZXJ0aW9ucygrKSwgMTQgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2Ry aXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2xyYy5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50 ZWxfbHJjLmMKPiBpbmRleCBkYjUzNTFlNmEzYTUuLjlkNjkzZTYxNTM2YyAxMDA2NDQKPiAtLS0g YS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9scmMuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2Ry bS9pOTE1L2ludGVsX2xyYy5jCj4gQEAgLTQ1Miw2ICs0NTIsMTYgQEAgc3RhdGljIHZvaWQgZXhl Y2xpc3RzX3N1Ym1pdF9wb3J0cyhzdHJ1Y3QgaW50ZWxfZW5naW5lX2NzICplbmdpbmUpCj4gICAJ c3RydWN0IGV4ZWNsaXN0X3BvcnQgKnBvcnQgPSBleGVjbGlzdHMtPnBvcnQ7Cj4gICAJdW5zaWdu ZWQgaW50IG47Cj4gICAKPiArCS8qCj4gKwkgKiBXZSBjYW4gc2tpcCBhY3F1aXJpbmcgaW50ZWxf cnVudGltZV9wbV9nZXQoKSBoZXJlIGFzIGl0IHdhcyB0YWtlbgo+ICsJICogb24gb3VyIGJlaGFs ZiBieSB0aGUgcmVxdWVzdCAoc2VlIGk5MTVfZ2VtX21hcmtfYnVzeSgpKSBhbmQgaXQgd2lsbAo+ ICsJICogbm90IGJlIHJlbGlucXVpc2hlZCB1bnRpbCB0aGUgZGV2aWNlIGlzIGlkbGUgKHNlZQo+ ICsJICogaTkxNV9nZW1faWRsZV93b3JrX2hhbmRsZXIoKSkuIEFzIGEgcHJlY2F1dGlvbiwgd2Ug bWFrZSBzdXJlCj4gKwkgKiB0aGF0IGFsbCBFTFNQIGFyZSBkcmFpbmVkIGkuZS4gd2UgaGF2ZSBw cm9jZXNzZWQgdGhlIENTQiwKPiArCSAqIGJlZm9yZSBhbGxvd2luZyBvdXJzZWx2ZXMgdG8gaWRs ZSBhbmQgY2FsbGluZyBpbnRlbF9ydW50aW1lX3BtX3B1dCgpLgo+ICsJICovCj4gKwlHRU1fQlVH X09OKCFlbmdpbmUtPmk5MTUtPmd0LmF3YWtlKTsKPiArCj4gICAJLyoKPiAgIAkgKiBFTFNRIG5v dGU6IHRoZSBzdWJtaXQgcXVldWUgaXMgbm90IGNsZWFyZWQgYWZ0ZXIgYmVpbmcgc3VibWl0dGVk Cj4gICAJICogdG8gdGhlIEhXIHNvIHdlIG5lZWQgdG8gbWFrZSBzdXJlIHdlIGFsd2F5cyBjbGVh biBpdCB1cC4gVGhpcyBpcwo+IEBAIC0xMDQzLDE2ICsxMDUzLDYgQEAgc3RhdGljIHZvaWQgX19l eGVjbGlzdHNfc3VibWlzc2lvbl90YXNrbGV0KHN0cnVjdCBpbnRlbF9lbmdpbmVfY3MgKmNvbnN0 IGVuZ2luZSkKPiAgIHsKPiAgIAlsb2NrZGVwX2Fzc2VydF9oZWxkKCZlbmdpbmUtPnRpbWVsaW5l LmxvY2spOwo+ICAgCj4gLQkvKgo+IC0JICogV2UgY2FuIHNraXAgYWNxdWlyaW5nIGludGVsX3J1 bnRpbWVfcG1fZ2V0KCkgaGVyZSBhcyBpdCB3YXMgdGFrZW4KPiAtCSAqIG9uIG91ciBiZWhhbGYg YnkgdGhlIHJlcXVlc3QgKHNlZSBpOTE1X2dlbV9tYXJrX2J1c3koKSkgYW5kIGl0IHdpbGwKPiAt CSAqIG5vdCBiZSByZWxpbnF1aXNoZWQgdW50aWwgdGhlIGRldmljZSBpcyBpZGxlIChzZWUKPiAt CSAqIGk5MTVfZ2VtX2lkbGVfd29ya19oYW5kbGVyKCkpLiBBcyBhIHByZWNhdXRpb24sIHdlIG1h a2Ugc3VyZQo+IC0JICogdGhhdCBhbGwgRUxTUCBhcmUgZHJhaW5lZCBpLmUuIHdlIGhhdmUgcHJv Y2Vzc2VkIHRoZSBDU0IsCj4gLQkgKiBiZWZvcmUgYWxsb3dpbmcgb3Vyc2VsdmVzIHRvIGlkbGUg YW5kIGNhbGxpbmcgaW50ZWxfcnVudGltZV9wbV9wdXQoKS4KPiAtCSAqLwo+IC0JR0VNX0JVR19P TighZW5naW5lLT5pOTE1LT5ndC5hd2FrZSk7Cj4gLQo+ICAgCXByb2Nlc3NfY3NiKGVuZ2luZSk7 Cj4gICAJaWYgKCFleGVjbGlzdHNfaXNfYWN0aXZlKCZlbmdpbmUtPmV4ZWNsaXN0cywgRVhFQ0xJ U1RTX0FDVElWRV9QUkVFTVBUKSkKPiAgIAkJZXhlY2xpc3RzX2RlcXVldWUoZW5naW5lKTsKPiBA QCAtMTA3MywxMCArMTA3Myw3IEBAIHN0YXRpYyB2b2lkIGV4ZWNsaXN0c19zdWJtaXNzaW9uX3Rh c2tsZXQodW5zaWduZWQgbG9uZyBkYXRhKQo+ICAgCQkgIGVuZ2luZS0+ZXhlY2xpc3RzLmFjdGl2 ZSk7Cj4gICAKPiAgIAlzcGluX2xvY2tfaXJxc2F2ZSgmZW5naW5lLT50aW1lbGluZS5sb2NrLCBm bGFncyk7Cj4gLQo+IC0JaWYgKGVuZ2luZS0+aTkxNS0+Z3QuYXdha2UpIC8qIHdlIG1heSBiZSBk ZWxheWVkIHVudGlsIGFmdGVyIHdlIGlkbGUhICovCj4gLQkJX19leGVjbGlzdHNfc3VibWlzc2lv bl90YXNrbGV0KGVuZ2luZSk7Cj4gLQo+ICsJX19leGVjbGlzdHNfc3VibWlzc2lvbl90YXNrbGV0 KGVuZ2luZSk7Cj4gICAJc3Bpbl91bmxvY2tfaXJxcmVzdG9yZSgmZW5naW5lLT50aW1lbGluZS5s b2NrLCBmbGFncyk7Cj4gICB9Cj4gICAKPiAKCldoeSB3ZSB3b24ndCBoaXQgdGhlIGFzc2VydCBv biB0aGUgZWxzcCBzdWJtaXQgc2lkZSBub3c/IEFGQUlSIHRoZSAKZGlzY3Vzc2lvbiBhYm91dCB0 aGlzIHBhcnRpY3VsYXIgbGluZSBjb25jbHVkZWQgdGhhdCBkaXJlY3QgdGFza2xldCBjYWxsIApj YW4gcmFjZSB3aXRoIGJ1c3ktPmlkbGUgdHJhbnNpdGlvbi4gU28gZXZlbiBpcyBwcm9jZXNzX2Nz YiBkb2Vucyd0IG5lZWQgCnRoZSBhc3NlcnQsIHRoYXQgcGFydCBJIGdldCwgdGhlIHBhcnQgYWJv dXQgdGhlIHJhY2Ugbm93IGFnYWluIGJvdGhlcnMgCm1lLiBQZXJoYXBzIEkganVzdCBmb3Jnb3Qg d2hhdCBJIHRob3VnaHQgSSB1bmRlcnN0b29kIGJhY2sgdGhlbi4uIDooCgpTaG91bGQgdGhpcyBj YWxsIHByb2Nlc3NfY3NiIG9ubHkgaWYgIWd0LmF3YWtlPyBCdXQgc291bmRzIHRlcnJpYmx5IApk b2RneS4uIFdoeSB3b3VsZCBleGVjbGlzdHMuYWN0aXZlIGJlIHNldCBpZiB3ZSBhcmUgbm90IGF3 YWtlLi4KClJlZ2FyZHMsCgpUdnJ0a28KX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJl ZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGlu Zm8vaW50ZWwtZ2Z4Cg==