From: "Nguyen Thai Ngoc Duy" <pclouds@gmail.com>
To: "Johannes Schindelin" <Johannes.Schindelin@gmx.de>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 07/10] builtin-archive: mark unused prefix "unused_prefix"
Date: Tue, 11 Mar 2008 21:50:24 +0700 [thread overview]
Message-ID: <fcaeb9bf0803110750rd70a303r3fc522b326ea93b@mail.gmail.com> (raw)
In-Reply-To: <alpine.LSU.1.00.0803111432370.3873@racer.site>
On Tue, Mar 11, 2008 at 8:33 PM, Johannes Schindelin
<Johannes.Schindelin@gmx.de> wrote:
> Hi,
>
>
> On Sun, 2 Mar 2008, Nguyễn Thái Ngọc Duy wrote:
>
> > cmd_archive() is registered without RUN_SETUP so its prefix
> > will be NULL forever. Let's make that clear.
> >
> > Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
> > ---
>
> AFAICT this patch is -- like two others -- an independent fix, and should
> be submitted as such.
It's not really independent. Before the series, setup_dir_gently()
_can_ change the prefix. After the series it does not (semantics
change). The first patch of the series ("git read-tree -m") is
independent and can be cherry picked if necessary.
--
Duy
next prev parent reply other threads:[~2008-03-11 14:51 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1204453703.git.pclouds@gmail.com>
2008-03-02 10:33 ` [PATCH 01/10] "git read-tree -m" and the like require worktree Nguyễn Thái Ngọc Duy
2008-03-11 13:02 ` Johannes Schindelin
2008-03-11 14:57 ` Nguyen Thai Ngoc Duy
2008-03-11 15:06 ` Johannes Schindelin
2008-03-11 15:41 ` Nguyen Thai Ngoc Duy
2008-03-02 10:33 ` [PATCH 02/10] Make sure setup_git_directory is called before accessing repository Nguyễn Thái Ngọc Duy
2008-03-02 10:33 ` [PATCH 03/10] Make get_git_dir() and 'git rev-parse --git-dir' absolute path Nguyễn Thái Ngọc Duy
2008-03-11 13:20 ` Johannes Schindelin
2008-03-11 15:06 ` Nguyen Thai Ngoc Duy
2008-03-11 15:18 ` Johannes Schindelin
2008-03-11 15:39 ` Nguyen Thai Ngoc Duy
2008-03-11 16:20 ` Johannes Schindelin
2008-03-02 10:34 ` [PATCH 04/10] Make setup_work_tree() return new prefix Nguyễn Thái Ngọc Duy
2008-03-11 13:27 ` Johannes Schindelin
2008-03-11 15:18 ` Nguyen Thai Ngoc Duy
2008-03-02 10:34 ` [PATCH 05/10] http-push: Avoid calling setup_git_directory() twice Nguyễn Thái Ngọc Duy
2008-03-11 13:28 ` Johannes Schindelin
2008-03-11 14:54 ` Nguyen Thai Ngoc Duy
2008-03-11 15:08 ` Johannes Schindelin
2008-03-11 16:12 ` Nguyen Thai Ngoc Duy
2008-03-02 10:34 ` [PATCH 06/10] Completely move out worktree setup from setup_git_directory_gently() Nguyễn Thái Ngọc Duy
2008-03-11 13:31 ` Johannes Schindelin
2008-03-11 15:28 ` Nguyen Thai Ngoc Duy
2008-03-11 16:21 ` Johannes Schindelin
2008-03-02 10:34 ` [PATCH 07/10] builtin-archive: mark unused prefix "unused_prefix" Nguyễn Thái Ngọc Duy
2008-03-11 13:33 ` Johannes Schindelin
2008-03-11 14:50 ` Nguyen Thai Ngoc Duy [this message]
2008-03-11 15:38 ` Jay Soffian
2008-03-11 16:21 ` Nguyen Thai Ngoc Duy
2008-03-02 10:35 ` [PATCH 08/10] Make setup_git_directory() auto-setup worktree if found Nguyễn Thái Ngọc Duy
2008-03-02 10:35 ` [PATCH 09/10] Documentation: update api-builtin and api-setup Nguyễn Thái Ngọc Duy
2008-03-02 10:35 ` [PATCH 10/10] Additional tests to capture worktree special cases Nguyễn Thái Ngọc Duy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fcaeb9bf0803110750rd70a303r3fc522b326ea93b@mail.gmail.com \
--to=pclouds@gmail.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.