All of lore.kernel.org
 help / color / mirror / Atom feed
From: Julien Olivain <ju.o@free.fr>
To: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Cc: Akhilesh Nema <nemaakhilesh@gmail.com>,
	buildroot@buildroot.org,
	Guillaume William Brs <guillaume.bressaix@gmail.com>
Subject: Re: [Buildroot] [PATCH 1/1] package/libxcrypt: bump version to 4.4.37
Date: Tue, 14 Jan 2025 19:18:27 +0100	[thread overview]
Message-ID: <fcaf9348ede608925bad155bdbd2bf53@free.fr> (raw)
In-Reply-To: <20250113153412.51ff0e04@windsurf>

Hi Thomas, Akhilesh,

On 13/01/2025 15:34, Thomas Petazzoni via buildroot wrote:
> On Sun, 12 Jan 2025 14:31:42 -0800
> Akhilesh Nema <nemaakhilesh@gmail.com> wrote:
> 
>> diff --git a/package/libxcrypt/Config.in b/package/libxcrypt/Config.in
>> index 38c75b5e63..508e1a43cd 100644
>> --- a/package/libxcrypt/Config.in
>> +++ b/package/libxcrypt/Config.in
>> @@ -1,6 +1,7 @@
>>  config BR2_PACKAGE_LIBXCRYPT
>>  	bool "libxcrypt"
>>  	depends on BR2_TOOLCHAIN_USES_GLIBC
>> +	select BR2_PACKAGE_HOST_PKGCONF
> 
> We really don't enforce selecting this option, so I'd rather see it not
> done, than done inconsistently between packages.
> 
>> +LIBXCRYPT_DEPENDENCIES = host-pkgconf
>> +HOST_LIBXCRYPT_DEPENDENCIES = host-pkgconf
> 
> I'm actually surprised by the dependency on host-pkgconf. host-pkgconf
> is normally used to detect dependencies, but libxcrypt has no
> dependencies other than the toolchain. So why is it needed now?
> Explanations in your commit log would be very useful.

As Akhilesh pointed out in the v1 thread, this was an upstream issue:
https://github.com/besser82/libxcrypt/issues/198

Hopefully, this was quickly fixed upstream. There is already a
new version:
https://github.com/besser82/libxcrypt/releases/tag/v4.4.38

So we could just skip this 4.4.37 version, and bump directly
to 4.4.38 (and not add the dependencies).

Akhilesh: could make sure to test this new bump with at least
a "utils/test-pkg -a -p libxcrypt" please? (or add in a comment
the test you did).

Best regards,

Julien.
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2025-01-14 18:18 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-12 22:31 [Buildroot] [PATCH 1/1] package/libxcrypt: bump version to 4.4.37 Akhilesh Nema
2025-01-13 14:34 ` Thomas Petazzoni via buildroot
2025-01-14 18:18   ` Julien Olivain [this message]
2025-01-15  3:48     ` Akhilesh Nema
  -- strict thread matches above, loose matches on Subject: below --
2025-01-09  1:18 Akhilesh Nema
2025-01-11 13:19 ` Julien Olivain
2025-01-12 20:58   ` Akhilesh Nema

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fcaf9348ede608925bad155bdbd2bf53@free.fr \
    --to=ju.o@free.fr \
    --cc=buildroot@buildroot.org \
    --cc=guillaume.bressaix@gmail.com \
    --cc=nemaakhilesh@gmail.com \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.