From: Mat Martineau <mathew.j.martineau@linux.intel.com>
To: Geliang Tang <geliang.tang@suse.com>
Cc: mptcp@lists.linux.dev
Subject: Re: [PATCH mptcp-next v18 09/15] Squash to "selftests/bpf: Add bpf_rr scheduler"
Date: Thu, 10 Nov 2022 16:29:23 -0800 (PST) [thread overview]
Message-ID: <fcb034ce-ac54-b874-411e-e6156fa5b7bc@linux.intel.com> (raw)
In-Reply-To: <bc0bb04ee334a2a38c7e5603405c16d6af4fff5f.1667897099.git.geliang.tang@suse.com>
On Tue, 8 Nov 2022, Geliang Tang wrote:
> Use new API.
>
> Signed-off-by: Geliang Tang <geliang.tang@suse.com>
After patch 1 is updated, I think the series is looking good up to this
patch.
- Mat
> ---
> tools/testing/selftests/bpf/progs/mptcp_bpf_rr.c | 10 +++++++++-
> 1 file changed, 9 insertions(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/bpf/progs/mptcp_bpf_rr.c b/tools/testing/selftests/bpf/progs/mptcp_bpf_rr.c
> index ce4e98f83e43..e101428e5906 100644
> --- a/tools/testing/selftests/bpf/progs/mptcp_bpf_rr.c
> +++ b/tools/testing/selftests/bpf/progs/mptcp_bpf_rr.c
> @@ -16,8 +16,14 @@ void BPF_PROG(mptcp_sched_rr_release, const struct mptcp_sock *msk)
> {
> }
>
> -void BPF_STRUCT_OPS(bpf_rr_get_subflow, const struct mptcp_sock *msk,
> +void BPF_STRUCT_OPS(bpf_rr_data_init, const struct mptcp_sock *msk,
> struct mptcp_sched_data *data)
> +{
> + mptcp_sched_data_set_contexts(msk, data);
> +}
> +
> +int BPF_STRUCT_OPS(bpf_rr_get_subflow, const struct mptcp_sock *msk,
> + struct mptcp_sched_data *data)
> {
> int nr = 0;
>
> @@ -35,12 +41,14 @@ void BPF_STRUCT_OPS(bpf_rr_get_subflow, const struct mptcp_sock *msk,
> }
>
> mptcp_subflow_set_scheduled(data->contexts[nr], true);
> + return 0;
> }
>
> SEC(".struct_ops")
> struct mptcp_sched_ops rr = {
> .init = (void *)mptcp_sched_rr_init,
> .release = (void *)mptcp_sched_rr_release,
> + .data_init = (void *)bpf_rr_data_init,
> .get_subflow = (void *)bpf_rr_get_subflow,
> .name = "bpf_rr",
> };
> --
> 2.35.3
>
>
>
--
Mat Martineau
Intel
next prev parent reply other threads:[~2022-11-11 0:29 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-08 9:08 [PATCH mptcp-next v18 00/15] BPF redundant scheduler Geliang Tang
2022-11-08 9:08 ` [PATCH mptcp-next v18 01/15] mptcp: refactor push_pending logic Geliang Tang
2022-11-11 0:11 ` Mat Martineau
2022-11-08 9:08 ` [PATCH mptcp-next v18 02/15] mptcp: drop last_snd and MPTCP_RESET_SCHEDULER Geliang Tang
2022-11-08 9:08 ` [PATCH mptcp-next v18 03/15] mptcp: add sched_data_set_contexts helper Geliang Tang
2022-11-08 9:08 ` [PATCH mptcp-next v18 04/15] Squash to "mptcp: add struct mptcp_sched_ops" Geliang Tang
2022-11-08 9:08 ` [PATCH mptcp-next v18 05/15] Squash to "bpf: Add bpf_mptcp_sched_ops" Geliang Tang
2022-11-08 9:08 ` [PATCH mptcp-next v18 06/15] Squash to "bpf: Add bpf_mptcp_sched_kfunc_set" Geliang Tang
2022-11-08 9:08 ` [PATCH mptcp-next v18 07/15] Squash to "selftests/bpf: Add bpf_first scheduler" Geliang Tang
2022-11-08 9:08 ` [PATCH mptcp-next v18 08/15] Squash to "selftests/bpf: Add bpf_bkup scheduler" Geliang Tang
2022-11-08 9:08 ` [PATCH mptcp-next v18 09/15] Squash to "selftests/bpf: Add bpf_rr scheduler" Geliang Tang
2022-11-11 0:29 ` Mat Martineau [this message]
2022-11-08 9:08 ` [PATCH mptcp-next v18 10/15] mptcp: use get_send wrapper Geliang Tang
2022-11-11 1:04 ` Mat Martineau
2022-11-08 9:08 ` [PATCH mptcp-next v18 11/15] mptcp: use get_retrans wrapper Geliang Tang
2022-11-08 9:08 ` [PATCH mptcp-next v18 12/15] mptcp: delay updating first_pending Geliang Tang
2022-11-08 9:08 ` [PATCH mptcp-next v18 13/15] mptcp: delay updating already_sent Geliang Tang
2022-11-08 9:08 ` [PATCH mptcp-next v18 14/15] selftests/bpf: Add bpf_red scheduler Geliang Tang
2022-11-08 9:08 ` [PATCH mptcp-next v18 15/15] selftests/bpf: Add bpf_red test Geliang Tang
2022-11-08 9:34 ` selftests/bpf: Add bpf_red test: Build Failure MPTCP CI
2022-11-08 10:51 ` selftests/bpf: Add bpf_red test: Tests Results MPTCP CI
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fcb034ce-ac54-b874-411e-e6156fa5b7bc@linux.intel.com \
--to=mathew.j.martineau@linux.intel.com \
--cc=geliang.tang@suse.com \
--cc=mptcp@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.