All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sivaprakash Murugesan <sivaprak@codeaurora.org>
To: Rob Herring <robh+dt@kernel.org>
Cc: Andy Gross <agross@kernel.org>,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	Bjorn Helgaas <bhelgaas@google.com>,
	linux-arm-msm <linux-arm-msm@vger.kernel.org>,
	PCI <linux-pci@vger.kernel.org>,
	devicetree@vger.kernel.org,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH V2] dt-bindings: pci: convert QCOM pci bindings to YAML
Date: Wed, 29 Jul 2020 08:19:06 +0530	[thread overview]
Message-ID: <fcb3df88-18bd-add1-5329-92af92948048@codeaurora.org> (raw)
In-Reply-To: <CAL_JsqJU81U5CNSia3Lrzwb2VpPy3YMK=tJfXgU49TuGn1eRyQ@mail.gmail.com>

Hi Rob,

On 7/28/2020 9:24 PM, Rob Herring wrote:
> On Tue, Jul 28, 2020 at 9:27 AM Rob Herring <robh+dt@kernel.org> wrote:
>> On Sun, Jul 26, 2020 at 9:07 AM Sivaprakash Murugesan
>> <sivaprak@qti.qualcomm.com> wrote:
>>> From: Sivaprakash Murugesan <sivaprak@codeaurora.org>
>>>
>>> Convert QCOM pci bindings to YAML schema
>>>
>>> Signed-off-by: Sivaprakash Murugesan <sivaprak@codeaurora.org>
>>> ---
>>> [v2]
>>>    - Referenced pci-bus.yaml
>>>    - removed duplicate properties already referenced by pci-bus.yaml
>>>    - Addressed comments from Rob
>>>   .../devicetree/bindings/pci/qcom,pcie.txt          | 330 ---------------
>>>   .../devicetree/bindings/pci/qcom,pcie.yaml         | 447 +++++++++++++++++++++
>>>   2 files changed, 447 insertions(+), 330 deletions(-)
>>>   delete mode 100644 Documentation/devicetree/bindings/pci/qcom,pcie.txt
>>>   create mode 100644 Documentation/devicetree/bindings/pci/qcom,pcie.yaml
>>
>>> diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml
>>> new file mode 100644
>>> index 000000000000..ddb84f49ac1c
>>> --- /dev/null
>>> +++ b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml
>>> @@ -0,0 +1,447 @@
>>> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
>>> +
>>> +%YAML 1.2
>>> +---
>>> +$id: "http://devicetree.org/schemas/pci/qcom,pcie.yaml#"
>>> +$schema: "http://devicetree.org/meta-schemas/core.yaml#"
>>> +
>>> +title: Qualcomm PCI express root complex
>>> +
>>> +maintainers:
>>> +  - Sivaprakash Murugesan <sivaprak@codeaurora.org>
>>> +
>>> +description:
>>> +  QCOM PCIe controller uses Designware IP with Qualcomm specific hardware
>>> +  wrappers.
>>> +
>>> +properties:
>>> +  compatible:
>>> +    enum:
>>> +      - qcom,pcie-apq8064
>>> +      - qcom,pcie-apq8084
>>> +      - qcom,pcie-ipq4019
>>> +      - qcom,pcie-ipq8064
>>> +      - qcom,pcie-ipq8074
>>> +      - qcom,pcie-msm8996
>>> +      - qcom,pcie-qcs404
>>> +      - qcom,pcie-sdm845
>>> +
>>> +  reg:
>>> +    description: Register ranges as listed in the reg-names property
>> Can drop this.
>>
>>> +    maxItems: 4
>>> +
>>> +  reg-names:
>>> +    items:
>>> +      - const: dbi
>>> +      - const: elbi
>>> +      - const: parf
>>> +      - const: config
>>> +
>>> +  ranges:
>>> +    maxItems: 2
>>> +
>>> +  interrupts:
>>> +    items:
>>> +      - description: MSI interrupts
>>> +
>>> +  interrupt-names:
>>> +    const: msi
>>> +
>>> +  "#interrupt-cells":
>> In pci-bus.yaml, so you can drop.

I am getting the below error if I remove #interrupt-cells alone.

properties: '#interrupt-cells' is a dependency of 'interrupt-map'

interrupt-map is also documented in pci-bus.yaml hence dropping that as 
well.



      reply	other threads:[~2020-07-29  2:49 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-26 15:06 [PATCH V2] dt-bindings: pci: convert QCOM pci bindings to YAML Sivaprakash Murugesan
2020-07-27 21:15 ` Rob Herring
2020-07-28 15:27 ` Rob Herring
2020-07-28 15:54   ` Rob Herring
2020-07-29  2:49     ` Sivaprakash Murugesan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fcb3df88-18bd-add1-5329-92af92948048@codeaurora.org \
    --to=sivaprak@codeaurora.org \
    --cc=agross@kernel.org \
    --cc=bhelgaas@google.com \
    --cc=bjorn.andersson@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.