From: Shan-Chun Hung <shanchun1218@gmail.com>
To: Frank Li <Frank.li@oss.nxp.com>, sashiko-reviews@lists.linux.dev
Cc: dmaengine@vger.kernel.org, devicetree@vger.kernel.org,
robh@kernel.org, conor+dt@kernel.org, vkoul@kernel.org,
Frank.Li@kernel.org
Subject: Re: [PATCH 2/2] dmaengine: ma35d1-pdma: Add MA35D1 PDMA driver
Date: Thu, 5 Nov 2026 11:39:51 +0800 [thread overview]
Message-ID: <fcbd337e-71e4-4b34-b1db-800390a61ffb@gmail.com> (raw)
In-Reply-To: <auuHy9_GAzYZL9V5@SMW015318>
Hi Frank,
Thanks for the feedback. I will address these issues in the next revision.
Best regards,
Shan-Chun
On 11/5/2026 3:30 AM, Frank Li wrote:
> On Tue, Nov 03, 2026 at 02:43:08AM +0000, sashiko-bot@kernel.org wrote:
>> Thank you for your contribution! Sashiko AI review found 11 potential issue(s) to consider:
>> - [Critical] dmaengine: ma35d1: premature register setup in ma35d1_desc_alloc() and prep
>> - [Critical] dmaengine: ma35d1: active DMA after timeout and double completion in IRQ
>> - [High] dmaengine: ma35d1: missing PDMA_TBINTDIS in ma35d1_prep_dma_memcpy()
>> - [High] dmaengine: ma35d1: unvalidated SG segment lengths in ma35d1_prep_slave_sg()
>> - [High] dmaengine: ma35d1: broken residue and status reporting in ma35d1_tx_status()
>> - [High] dmaengine: ma35d1: unlocked PDMA_TOUTEN RMW in ma35d1_pdma_interrupt()
>> - [High] dmaengine: ma35d1: state bugs in ma35d1_of_xlate() and free_chan_resources()
>> - [High] dmaengine: ma35d1-pdma: fix signed dma-channels pointer and zero bounds check
>> - [High] dmaengine: ma35d1-pdma: unsafe teardown order in ma35d1_pdma_remove()
>> - [Medium] dmaengine: ma35d1-pdma: disable channel timeout in ma35d1_terminate_all()
>> - [Medium] dmaengine: ma35d1-pdma: unreleased ch->desc and stale ch->cfg in ma35d1_free_chan_resources()
>> --
>
> Please fix these issues.
>
> Frank
next prev parent reply other threads:[~2026-11-05 3:40 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-03 2:22 [PATCH 0/2] dmaengine: ma35d1-pdma: Add MA35D1 PDMA driver Shan-Chun Hung
2026-11-03 2:22 ` [PATCH 1/2] dt-bindings: dma: nuvoton,ma35d1-pdma: Document MA35D1 PDMA controller Shan-Chun Hung
2026-11-03 2:36 ` sashiko-bot
2026-11-04 14:03 ` Krzysztof Kozlowski
2026-11-05 0:14 ` Shan-Chun Hung
2026-11-03 2:22 ` [PATCH 2/2] dmaengine: ma35d1-pdma: Add MA35D1 PDMA driver Shan-Chun Hung
2026-11-03 2:43 ` sashiko-bot
2026-11-04 19:30 ` Frank Li
2026-11-05 3:39 ` Shan-Chun Hung [this message]
2026-11-04 14:06 ` Krzysztof Kozlowski
2026-11-05 4:11 ` Shan-Chun Hung
2026-11-06 0:39 ` Shan-Chun Hung
2026-11-06 16:57 ` Uwe Kleine-König
2026-11-09 0:14 ` Shan-Chun Hung
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fcbd337e-71e4-4b34-b1db-800390a61ffb@gmail.com \
--to=shanchun1218@gmail.com \
--cc=Frank.Li@kernel.org \
--cc=Frank.li@oss.nxp.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.