From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 559B1EB64DA for ; Fri, 14 Jul 2023 13:51:41 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4R2Xvb6yB0z3c7v for ; Fri, 14 Jul 2023 23:51:39 +1000 (AEST) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=linux.alibaba.com (client-ip=115.124.30.101; helo=out30-101.freemail.mail.aliyun.com; envelope-from=hsiangkao@linux.alibaba.com; receiver=lists.ozlabs.org) Received: from out30-101.freemail.mail.aliyun.com (out30-101.freemail.mail.aliyun.com [115.124.30.101]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4R2XvT6fMZz30hQ for ; Fri, 14 Jul 2023 23:51:32 +1000 (AEST) X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R151e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018045192;MF=hsiangkao@linux.alibaba.com;NM=1;PH=DS;RN=21;SR=0;TI=SMTPD_---0VnMhNu7_1689342677; Received: from 30.25.236.189(mailfrom:hsiangkao@linux.alibaba.com fp:SMTPD_---0VnMhNu7_1689342677) by smtp.aliyun-inc.com; Fri, 14 Jul 2023 21:51:20 +0800 Message-ID: Date: Fri, 14 Jul 2023 21:51:16 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v1] rcu: Fix and improve RCU read lock checks when !CONFIG_DEBUG_LOCK_ALLOC To: Joel Fernandes References: <20230713003201.GA469376@google.com> <161f1615-3d85-cf47-d2d5-695adf1ca7d4@linux.alibaba.com> <0d9e7b4d-6477-47a6-b3d2-2c9d9b64903d@paulmck-laptop> <87292a44-cc02-4d95-940e-e4e31d0bc6f2@paulmck-laptop> <894a3b64-a369-7bc6-c8a8-0910843cc587@linux.alibaba.com> <58b661d0-0ebb-4b45-a10d-c5927fb791cd@paulmck-laptop> <7d433fac-a62d-4e81-b8e5-57cf5f2d1d55@paulmck-laptop> <058e7ee9-0380-eb1b-d9a8-b184cba6ed53@linux.alibaba.com> From: Gao Xiang In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: linux-erofs@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development of Linux EROFS file system List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kernel-team@android.com, paulmck@kernel.org, Will Shiu , linux-erofs@lists.ozlabs.org, Boqun Feng , Lai Jiangshan , Josh Triplett , Steven Rostedt , linux-kernel@vger.kernel.org, rcu@vger.kernel.org, Mathieu Desnoyers , Matthias Brugger , linux-mediatek@lists.infradead.org, Zqiang , Neeraj Upadhyay , Frederic Weisbecker , linux-arm-kernel@lists.infradead.org, AngeloGioacchino Del Regno Errors-To: linux-erofs-bounces+linux-erofs=archiver.kernel.org@lists.ozlabs.org Sender: "Linux-erofs" On 2023/7/14 21:42, Joel Fernandes wrote: > On Thu, Jul 13, 2023 at 11:17 PM Gao Xiang wrote: >> >> >> >> On 2023/7/14 10:16, Paul E. McKenney wrote: >>> On Thu, Jul 13, 2023 at 09:33:35AM -0700, Paul E. McKenney wrote: >>>> On Thu, Jul 13, 2023 at 11:33:24AM -0400, Joel Fernandes wrote: >> >> ... >> >>>>> >>>>> >From what Sandeep described, the code path is in an RCU reader. My >>>>> question is more, why doesn't it use SRCU instead since it clearly >>>>> does so if BLK_MQ_F_BLOCKING. What are the tradeoffs? IMHO, a deeper >>>>> dive needs to be made into that before concluding that the fix is to >>>>> use rcu_read_lock_any_held(). >>>> >>>> How can this be solved? >>>> >>>> 1. Always use a workqueue. Simple, but is said to have performance >>>> issues. >>>> >>>> 2. Pass a flag in that indicates whether or not the caller is in an >>>> RCU read-side critical section. Conceptually simple, but might >>>> or might not be reasonable to actually implement in the code as >>>> it exists now. (You tell me!) >>>> >>>> 3. Create a function in z_erofs that gives you a decent >>>> approximation, maybe something like the following. >>>> >>>> 4. Other ideas here. >>> >>> 5. #3 plus make the corresponding Kconfig option select >>> PREEMPT_COUNT, assuming that any users needing compression in >>> non-preemptible kernels are OK with PREEMPT_COUNT being set. >>> (Some users of non-preemptible kernels object strenuously >>> to the added overhead from CONFIG_PREEMPT_COUNT=y.) >> >> I'm not sure if it's a good idea > > I think it is a fine idea. > >> we need to work on >> CONFIG_PREEMPT_COUNT=n (why not?), we could just always trigger a >> workqueue for this. >> > > So CONFIG_PREEMPT_COUNT=n users don't deserve good performance? ;-) I'm not sure if non-preemptible kernel users really care about such sensitive latencies, I don't know, my 2 cents. Thanks, Gao Xiang > > thanks, > > - Joel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9A584EB64DC for ; Fri, 14 Jul 2023 13:51:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=jpcIq9xBEn3GqPt9qtLJZwLczNi+ePJo4eIHV0FomOc=; b=K2DcISygLs7LuD9miah6gvUsgf 3He3Bwts2jLNuAjUUZsy5P5hXYs/74+WHAbKhw5bvnCWWGfof2num/m4BDshplX2Q0vcxB3+y8IfL o71rrW83IMOKfz1Ploe93CR8JuIiN/qlchU41+VwXBe+QlLJEIOd98SiyiMjpMcwOyhj4zYhwTEUm EYScj1LSkZygB2pzrAkAg6lUsdFIEh/w2mvrTrV/qKyJT0yHT83Bh0QHhUpZ2kXkPwdnME1DLQYO/ sAI9U+OOs6EAHMLJgQufSkqGYXS3vqyU5TX0mU+vHjI7ffeYe6wf+FaWTHrYkIdE2dc9jHcW6KNCD u9KSZT1g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qKJCr-006JiZ-1r; Fri, 14 Jul 2023 13:51:37 +0000 Received: from out30-133.freemail.mail.aliyun.com ([115.124.30.133]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qKJCn-006Jg2-0J; Fri, 14 Jul 2023 13:51:35 +0000 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R151e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018045192;MF=hsiangkao@linux.alibaba.com;NM=1;PH=DS;RN=21;SR=0;TI=SMTPD_---0VnMhNu7_1689342677; Received: from 30.25.236.189(mailfrom:hsiangkao@linux.alibaba.com fp:SMTPD_---0VnMhNu7_1689342677) by smtp.aliyun-inc.com; Fri, 14 Jul 2023 21:51:20 +0800 Message-ID: Date: Fri, 14 Jul 2023 21:51:16 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v1] rcu: Fix and improve RCU read lock checks when !CONFIG_DEBUG_LOCK_ALLOC To: Joel Fernandes Cc: paulmck@kernel.org, Sandeep Dhavale , Frederic Weisbecker , Neeraj Upadhyay , Josh Triplett , Boqun Feng , Steven Rostedt , Mathieu Desnoyers , Lai Jiangshan , Zqiang , Matthias Brugger , AngeloGioacchino Del Regno , linux-erofs@lists.ozlabs.org, xiang@kernel.org, Will Shiu , kernel-team@android.com, rcu@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org References: <20230713003201.GA469376@google.com> <161f1615-3d85-cf47-d2d5-695adf1ca7d4@linux.alibaba.com> <0d9e7b4d-6477-47a6-b3d2-2c9d9b64903d@paulmck-laptop> <87292a44-cc02-4d95-940e-e4e31d0bc6f2@paulmck-laptop> <894a3b64-a369-7bc6-c8a8-0910843cc587@linux.alibaba.com> <58b661d0-0ebb-4b45-a10d-c5927fb791cd@paulmck-laptop> <7d433fac-a62d-4e81-b8e5-57cf5f2d1d55@paulmck-laptop> <058e7ee9-0380-eb1b-d9a8-b184cba6ed53@linux.alibaba.com> From: Gao Xiang In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230714_065133_339951_7EB98A86 X-CRM114-Status: GOOD ( 17.07 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On 2023/7/14 21:42, Joel Fernandes wrote: > On Thu, Jul 13, 2023 at 11:17 PM Gao Xiang wrote: >> >> >> >> On 2023/7/14 10:16, Paul E. McKenney wrote: >>> On Thu, Jul 13, 2023 at 09:33:35AM -0700, Paul E. McKenney wrote: >>>> On Thu, Jul 13, 2023 at 11:33:24AM -0400, Joel Fernandes wrote: >> >> ... >> >>>>> >>>>> >From what Sandeep described, the code path is in an RCU reader. My >>>>> question is more, why doesn't it use SRCU instead since it clearly >>>>> does so if BLK_MQ_F_BLOCKING. What are the tradeoffs? IMHO, a deeper >>>>> dive needs to be made into that before concluding that the fix is to >>>>> use rcu_read_lock_any_held(). >>>> >>>> How can this be solved? >>>> >>>> 1. Always use a workqueue. Simple, but is said to have performance >>>> issues. >>>> >>>> 2. Pass a flag in that indicates whether or not the caller is in an >>>> RCU read-side critical section. Conceptually simple, but might >>>> or might not be reasonable to actually implement in the code as >>>> it exists now. (You tell me!) >>>> >>>> 3. Create a function in z_erofs that gives you a decent >>>> approximation, maybe something like the following. >>>> >>>> 4. Other ideas here. >>> >>> 5. #3 plus make the corresponding Kconfig option select >>> PREEMPT_COUNT, assuming that any users needing compression in >>> non-preemptible kernels are OK with PREEMPT_COUNT being set. >>> (Some users of non-preemptible kernels object strenuously >>> to the added overhead from CONFIG_PREEMPT_COUNT=y.) >> >> I'm not sure if it's a good idea > > I think it is a fine idea. > >> we need to work on >> CONFIG_PREEMPT_COUNT=n (why not?), we could just always trigger a >> workqueue for this. >> > > So CONFIG_PREEMPT_COUNT=n users don't deserve good performance? ;-) I'm not sure if non-preemptible kernel users really care about such sensitive latencies, I don't know, my 2 cents. Thanks, Gao Xiang > > thanks, > > - Joel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D34BAEB64DC for ; Fri, 14 Jul 2023 13:52:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=qtzitg4eHuat/L5Vhe4SJ/w3Dfh18swRDSFPwMqiC9k=; b=qEZYU4RBG/4ScH K5jz+ml2EwWM/RrbgzS6hyzJR+K/+ZgEoqLyYrAWiVDLmjWDtZ0OItBOfeLegKQ+MV0eg6su+zWz1 6F4NNCHfhbypBh48IXUl9Uiw7SzqT/T8Jj1VnhdyoXiEDWC9bRRKLHvzCw6C5Kp1dOjlJUJKIjD0y 93NRX4k2QWHms7UVUOh7VQOJPpiCHRQ6lW+BIkFh2p3ydoS9P7a/3pMhbUay2Cp1OV8QxiA/58sKt os75+6i0Lp0WDrWoKVJX3lAIpTT7qT4DgbzKbxOjysHt9r/rJ+Z0q6031WZ9HcN0ayDS6hlIVzqVQ GxysRR7uxWxSuoCnk84A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qKJCr-006Jhx-0B; Fri, 14 Jul 2023 13:51:37 +0000 Received: from out30-133.freemail.mail.aliyun.com ([115.124.30.133]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qKJCn-006Jg2-0J; Fri, 14 Jul 2023 13:51:35 +0000 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R151e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018045192;MF=hsiangkao@linux.alibaba.com;NM=1;PH=DS;RN=21;SR=0;TI=SMTPD_---0VnMhNu7_1689342677; Received: from 30.25.236.189(mailfrom:hsiangkao@linux.alibaba.com fp:SMTPD_---0VnMhNu7_1689342677) by smtp.aliyun-inc.com; Fri, 14 Jul 2023 21:51:20 +0800 Message-ID: Date: Fri, 14 Jul 2023 21:51:16 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v1] rcu: Fix and improve RCU read lock checks when !CONFIG_DEBUG_LOCK_ALLOC To: Joel Fernandes Cc: paulmck@kernel.org, Sandeep Dhavale , Frederic Weisbecker , Neeraj Upadhyay , Josh Triplett , Boqun Feng , Steven Rostedt , Mathieu Desnoyers , Lai Jiangshan , Zqiang , Matthias Brugger , AngeloGioacchino Del Regno , linux-erofs@lists.ozlabs.org, xiang@kernel.org, Will Shiu , kernel-team@android.com, rcu@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org References: <20230713003201.GA469376@google.com> <161f1615-3d85-cf47-d2d5-695adf1ca7d4@linux.alibaba.com> <0d9e7b4d-6477-47a6-b3d2-2c9d9b64903d@paulmck-laptop> <87292a44-cc02-4d95-940e-e4e31d0bc6f2@paulmck-laptop> <894a3b64-a369-7bc6-c8a8-0910843cc587@linux.alibaba.com> <58b661d0-0ebb-4b45-a10d-c5927fb791cd@paulmck-laptop> <7d433fac-a62d-4e81-b8e5-57cf5f2d1d55@paulmck-laptop> <058e7ee9-0380-eb1b-d9a8-b184cba6ed53@linux.alibaba.com> From: Gao Xiang In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230714_065133_339951_7EB98A86 X-CRM114-Status: GOOD ( 17.07 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org CgpPbiAyMDIzLzcvMTQgMjE6NDIsIEpvZWwgRmVybmFuZGVzIHdyb3RlOgo+IE9uIFRodSwgSnVs IDEzLCAyMDIzIGF0IDExOjE34oCvUE0gR2FvIFhpYW5nIDxoc2lhbmdrYW9AbGludXguYWxpYmFi YS5jb20+IHdyb3RlOgo+Pgo+Pgo+Pgo+PiBPbiAyMDIzLzcvMTQgMTA6MTYsIFBhdWwgRS4gTWNL ZW5uZXkgd3JvdGU6Cj4+PiBPbiBUaHUsIEp1bCAxMywgMjAyMyBhdCAwOTozMzozNUFNIC0wNzAw LCBQYXVsIEUuIE1jS2VubmV5IHdyb3RlOgo+Pj4+IE9uIFRodSwgSnVsIDEzLCAyMDIzIGF0IDEx OjMzOjI0QU0gLTA0MDAsIEpvZWwgRmVybmFuZGVzIHdyb3RlOgo+Pgo+PiAuLi4KPj4KPj4+Pj4K Pj4+Pj4gPkZyb20gd2hhdCBTYW5kZWVwIGRlc2NyaWJlZCwgdGhlIGNvZGUgcGF0aCBpcyBpbiBh biBSQ1UgcmVhZGVyLiBNeQo+Pj4+PiBxdWVzdGlvbiBpcyBtb3JlLCB3aHkgZG9lc24ndCBpdCB1 c2UgU1JDVSBpbnN0ZWFkIHNpbmNlIGl0IGNsZWFybHkKPj4+Pj4gZG9lcyBzbyBpZiBCTEtfTVFf Rl9CTE9DS0lORy4gV2hhdCBhcmUgdGhlIHRyYWRlb2Zmcz8gSU1ITywgYSBkZWVwZXIKPj4+Pj4g ZGl2ZSBuZWVkcyB0byBiZSBtYWRlIGludG8gdGhhdCBiZWZvcmUgY29uY2x1ZGluZyB0aGF0IHRo ZSBmaXggaXMgdG8KPj4+Pj4gdXNlIHJjdV9yZWFkX2xvY2tfYW55X2hlbGQoKS4KPj4+Pgo+Pj4+ IEhvdyBjYW4gdGhpcyBiZSBzb2x2ZWQ/Cj4+Pj4KPj4+PiAxLiAgIEFsd2F5cyB1c2UgYSB3b3Jr cXVldWUuICBTaW1wbGUsIGJ1dCBpcyBzYWlkIHRvIGhhdmUgcGVyZm9ybWFuY2UKPj4+PiAgICAg ICBpc3N1ZXMuCj4+Pj4KPj4+PiAyLiAgIFBhc3MgYSBmbGFnIGluIHRoYXQgaW5kaWNhdGVzIHdo ZXRoZXIgb3Igbm90IHRoZSBjYWxsZXIgaXMgaW4gYW4KPj4+PiAgICAgICBSQ1UgcmVhZC1zaWRl IGNyaXRpY2FsIHNlY3Rpb24uICBDb25jZXB0dWFsbHkgc2ltcGxlLCBidXQgbWlnaHQKPj4+PiAg ICAgICBvciBtaWdodCBub3QgYmUgcmVhc29uYWJsZSB0byBhY3R1YWxseSBpbXBsZW1lbnQgaW4g dGhlIGNvZGUgYXMKPj4+PiAgICAgICBpdCBleGlzdHMgbm93LiAgKFlvdSB0ZWxsIG1lISkKPj4+ Pgo+Pj4+IDMuICAgQ3JlYXRlIGEgZnVuY3Rpb24gaW4gel9lcm9mcyB0aGF0IGdpdmVzIHlvdSBh IGRlY2VudAo+Pj4+ICAgICAgIGFwcHJveGltYXRpb24sIG1heWJlIHNvbWV0aGluZyBsaWtlIHRo ZSBmb2xsb3dpbmcuCj4+Pj4KPj4+PiA0LiAgIE90aGVyIGlkZWFzIGhlcmUuCj4+Pgo+Pj4gNS4g ICAgIzMgcGx1cyBtYWtlIHRoZSBjb3JyZXNwb25kaW5nIEtjb25maWcgb3B0aW9uIHNlbGVjdAo+ Pj4gICAgICAgIFBSRUVNUFRfQ09VTlQsIGFzc3VtaW5nIHRoYXQgYW55IHVzZXJzIG5lZWRpbmcg Y29tcHJlc3Npb24gaW4KPj4+ICAgICAgICBub24tcHJlZW1wdGlibGUga2VybmVscyBhcmUgT0sg d2l0aCBQUkVFTVBUX0NPVU5UIGJlaW5nIHNldC4KPj4+ICAgICAgICAoU29tZSB1c2VycyBvZiBu b24tcHJlZW1wdGlibGUga2VybmVscyBvYmplY3Qgc3RyZW51b3VzbHkKPj4+ICAgICAgICB0byB0 aGUgYWRkZWQgb3ZlcmhlYWQgZnJvbSBDT05GSUdfUFJFRU1QVF9DT1VOVD15LikKPj4KPj4gSSdt IG5vdCBzdXJlIGlmIGl0J3MgYSBnb29kIGlkZWEKPiAKPiBJIHRoaW5rIGl0IGlzIGEgZmluZSBp ZGVhLgo+IAo+PiB3ZSBuZWVkIHRvIHdvcmsgb24KPj4gQ09ORklHX1BSRUVNUFRfQ09VTlQ9biAo d2h5IG5vdD8pLCB3ZSBjb3VsZCBqdXN0IGFsd2F5cyB0cmlnZ2VyIGEKPj4gd29ya3F1ZXVlIGZv ciB0aGlzLgo+Pgo+IAo+IFNvIENPTkZJR19QUkVFTVBUX0NPVU5UPW4gdXNlcnMgZG9uJ3QgZGVz ZXJ2ZSBnb29kIHBlcmZvcm1hbmNlPyA7LSkKCkknbSBub3Qgc3VyZSBpZiBub24tcHJlZW1wdGli bGUga2VybmVsIHVzZXJzIHJlYWxseSBjYXJlIGFib3V0CnN1Y2ggc2Vuc2l0aXZlIGxhdGVuY2ll cywgSSBkb24ndCBrbm93LCBteSAyIGNlbnRzLgoKVGhhbmtzLApHYW8gWGlhbmcKCj4gCj4gdGhh bmtzLAo+IAo+ICAgLSBKb2VsCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVs QGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9s aXN0aW5mby9saW51eC1hcm0ta2VybmVsCg==