All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dave Jiang <dave.jiang@intel.com>
To: Dan Williams <dan.j.williams@intel.com>, alison.schofield@intel.com
Cc: nvdimm@lists.linux.dev, linux-cxl@vger.kernel.org
Subject: Re: [ndctl PATCH 3/5] test: Fix dax.sh expectations
Date: Wed, 18 Jun 2025 15:28:13 -0700	[thread overview]
Message-ID: <fcdaa714-e366-4462-aaec-e62513d49d5a@intel.com> (raw)
In-Reply-To: <20250618222130.672621-4-dan.j.williams@intel.com>



On 6/18/25 3:21 PM, Dan Williams wrote:
> With current kernel+tracecmd combinations stdout is no longer purely trace
> records and column "21" is no longer the vmfault_t result.
> 
> Drop, if present, the diagnostic print of how many CPUs are in the trace
> and use the more universally compatible assumption that the fault result is
> the last column rather than a specific column.
> 
> Signed-off-by: Dan Williams <dan.j.williams@intel.com>

Reviewed-by: Dave Jiang <dave.jiang@intel.com>

> ---
>  test/dax.sh | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/test/dax.sh b/test/dax.sh
> index 3ffbc8079eba..98faaf0eb9b2 100755
> --- a/test/dax.sh
> +++ b/test/dax.sh
> @@ -37,13 +37,14 @@ run_test() {
>  	rc=1
>  	while read -r p; do
>  		[[ $p ]] || continue
> +		[[ $p == cpus=* ]] && continue
>  		if [ "$count" -lt 10 ]; then
>  			if [ "$p" != "0x100" ] && [ "$p" != "NOPAGE" ]; then
>  				cleanup "$1"
>  			fi
>  		fi
>  		count=$((count + 1))
> -	done < <(trace-cmd report | awk '{ print $21 }')
> +	done < <(trace-cmd report | awk '{ print $NF }')
>  
>  	if [ $count -lt 10 ]; then
>  		cleanup "$1"


  reply	other threads:[~2025-06-18 22:28 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-18 22:21 [ndctl PATCH 0/5] ndctl: Add missing test dependencies and other fixups Dan Williams
2025-06-18 22:21 ` [ndctl PATCH 1/5] build: Fix meson feature deprecation warnings Dan Williams
2025-06-18 22:25   ` Dave Jiang
2025-06-18 22:21 ` [ndctl PATCH 2/5] test: Fix 'ndctl' dependency in test/sub-section.sh Dan Williams
2025-06-18 22:26   ` Dave Jiang
2025-06-18 22:21 ` [ndctl PATCH 3/5] test: Fix dax.sh expectations Dan Williams
2025-06-18 22:28   ` Dave Jiang [this message]
2025-06-19  1:06   ` Alison Schofield
2025-06-19  1:09     ` Dan Williams
2025-06-20 20:11     ` Verma, Vishal L
2025-06-20 20:19       ` Alison Schofield
2025-06-18 22:21 ` [ndctl PATCH 4/5] test: Update documentation with required packages to install Dan Williams
2025-06-18 22:31   ` Dave Jiang
2025-06-18 22:21 ` [ndctl PATCH 5/5] test: Fixup fwctl dependency Dan Williams
2025-06-18 22:32   ` Dave Jiang
2025-06-19  1:18 ` [ndctl PATCH 0/5] ndctl: Add missing test dependencies and other fixups Alison Schofield

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fcdaa714-e366-4462-aaec-e62513d49d5a@intel.com \
    --to=dave.jiang@intel.com \
    --cc=alison.schofield@intel.com \
    --cc=dan.j.williams@intel.com \
    --cc=linux-cxl@vger.kernel.org \
    --cc=nvdimm@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.