From mboxrd@z Thu Jan 1 00:00:00 1970 From: Samuel Pitoiset Subject: Re: [PATCH 1/2] drm/amdgpu: drop multiple bo_unreserve() calls in amdgpu_gem_op_ioctl() Date: Fri, 10 Feb 2017 11:22:49 +0100 Message-ID: References: <20170209222824.3267-1-samuel.pitoiset@gmail.com> <589D2B9C.309@amd.com> <0c47615f-6e93-eea1-418c-f846a0c1d3ae@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: =?UTF-8?Q?Christian_K=c3=b6nig?= , zhoucm1 , amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org CgpPbiAwMi8xMC8yMDE3IDExOjE5IEFNLCBDaHJpc3RpYW4gS8O2bmlnIHdyb3RlOgo+IEFtIDEw LjAyLjIwMTcgdW0gMTE6MTEgc2NocmllYiBTYW11ZWwgUGl0b2lzZXQ6Cj4+Cj4+Cj4+IE9uIDAy LzEwLzIwMTcgMDM6NTUgQU0sIHpob3VjbTEgd3JvdGU6Cj4+Pgo+Pj4KPj4+IE9uIDIwMTflubQw MuaciDEw5pelIDA2OjI4LCBTYW11ZWwgUGl0b2lzZXQgd3JvdGU6Cj4+Pj4gTW92ZSBhbWRncHVf Ym9fdW5yZXNlcnZlKCkgb3V0c2lkZSBvZiB0aGUgc3dpdGNoLiBXaGlsZSB3ZSBhcmUKPj4+PiBh dCBpdCwgYWRkIGEgbWlzc2luZyBicmVhayBpbiB0aGUgZGVmYXVsdCBjYXNlLgo+Pj4+Cj4+Pj4g U2lnbmVkLW9mZi1ieTogU2FtdWVsIFBpdG9pc2V0IDxzYW11ZWwucGl0b2lzZXRAZ21haWwuY29t Pgo+Pj4+IC0tLQo+Pj4+ICAgZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X2dlbS5j IHwgNyArKy0tLS0tCj4+Pj4gICAxIGZpbGUgY2hhbmdlZCwgMiBpbnNlcnRpb25zKCspLCA1IGRl bGV0aW9ucygtKQo+Pj4+Cj4+Pj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1k Z3B1L2FtZGdwdV9nZW0uYwo+Pj4+IGIvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1 X2dlbS5jCj4+Pj4gaW5kZXggMWRjNTlhYWZlYzcxLi5hZTQ2NThhMTBlMmMgMTAwNjQ0Cj4+Pj4g LS0tIGEvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X2dlbS5jCj4+Pj4gKysrIGIv ZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X2dlbS5jCj4+Pj4gQEAgLTY2MCw3ICs2 NjAsNiBAQCBpbnQgYW1kZ3B1X2dlbV9vcF9pb2N0bChzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LAo+ Pj4+IHZvaWQgKmRhdGEsCj4+Pj4gICAgICAgICAgIGluZm8uYWxpZ25tZW50ID0gcm9iai0+dGJv Lm1lbS5wYWdlX2FsaWdubWVudCA8PCBQQUdFX1NISUZUOwo+Pj4+ICAgICAgICAgICBpbmZvLmRv bWFpbnMgPSByb2JqLT5wcmVmZXJlZF9kb21haW5zOwo+Pj4+ICAgICAgICAgICBpbmZvLmRvbWFp bl9mbGFncyA9IHJvYmotPmZsYWdzOwo+Pj4+IC0gICAgICAgIGFtZGdwdV9ib191bnJlc2VydmUo cm9iaik7Cj4+Pj4gICAgICAgICAgIGlmIChjb3B5X3RvX3VzZXIob3V0LCAmaW5mbywgc2l6ZW9m KGluZm8pKSkKPj4+PiAgICAgICAgICAgICAgIHIgPSAtRUZBVUxUOwo+Pj4gTkFLLCB5b3VyIHRo aXMgY2hhbmdlIHdpbGwgYnJlYWsgb3VyIHByZXZpb3VzIGRlYWRsb2NrIGZpeCBmb3Igd3dfbXV0 ZXgKPj4+IGFuZCBtbS0+bW1hcF9zZW0gaWYgSSByZW1lbWJlciBjb3JyZWN0bHkuCj4+Cj4+IE1t aCwgcmVhbGx5PyBDYW4geW91IHBpbnBvaW50IHRoZSBjb21taXQ/IEkgZG9uJ3Qgc2VlIGFueXRo aW5nIG9idmlvdXMKPj4gaW4gdGhlIGhpc3RvcnkgYWJvdXQgdGhhdC4KPgo+IERhdmlkIGlzIHJp Z2h0IGhlcmUuIE5vdCBzdXJlIHdoZW4gd2UgZml4ZWQgdGhhdCwgYnV0IGluIGdlbmVyYWwgY2Fs bGluZwo+IGNvcHlfdG8vZnJvbV91c2VyIHdoaWxlIGEgQk8gaXMgcmVzZXJ2ZWQgaXMgaWxsZWdh bC4KPgo+IE90aGVyd2lzZSBzb21lYm9keSBjb3VsZCBzZW5kIHRoZSBrZXJuZWwgYSBtZW1vcnkg bWFwcGVkIEJPIGFzIGFkZHJlc3MKPiBhbmQgdGhlIGNvcHlfdG8vZnJvbV91c2VyIHdvdWxkIGp1 c3QgZGVhZGxvY2sgYmVjYXVzZSBpdCB0cmllcyB0bwo+IHJlc2VydmUgYSBCTyB3aGlsZSBhbm90 aGVyIChvciB0aGUgc2FtZSkgQk8gaXMgYWxyZWFkeSByZXNlcnZlZCBpbiB0aGUKPiBjYWxsIHBh dGguCgpPa2F5LCBtYWtlcyBtb3JlIHNlbnNlLgoKVGhhbmtzIGZvciB0aGUgcmV2aWV3LiBNeSBn b2FsIGlzIG5vdCB0byBpbnRyb2R1Y2UgbmV3IHJlZ3Jlc3Npb25zIGJ1dCBJIApkaWRuJ3Qga25v dyB0aGF0LgoKTWF5YmUgdGhpcyBzaG91bGQgYmUgZXhwbGFpbmVkIGluIHRoZSBjb2RlPyBKdXN0 IGEgdGhvdWdodC4KCj4KPiBSZWdhcmRzLAo+IENocmlzdGlhbi4KPgo+Pgo+PiBUaGFua3MuCj4+ Cj4+Pgo+Pj4gUmVnYXJkcywKPj4+IERhdmlkIFpob3UKPj4+PiAgICAgICAgICAgYnJlYWs7Cj4+ Pj4gQEAgLTY2OCw3ICs2NjcsNiBAQCBpbnQgYW1kZ3B1X2dlbV9vcF9pb2N0bChzdHJ1Y3QgZHJt X2RldmljZSAqZGV2LAo+Pj4+IHZvaWQgKmRhdGEsCj4+Pj4gICAgICAgY2FzZSBBTURHUFVfR0VN X09QX1NFVF9QTEFDRU1FTlQ6Cj4+Pj4gICAgICAgICAgIGlmIChhbWRncHVfdHRtX3R0X2dldF91 c2VybW0ocm9iai0+dGJvLnR0bSkpIHsKPj4+PiAgICAgICAgICAgICAgIHIgPSAtRVBFUk07Cj4+ Pj4gLSAgICAgICAgICAgIGFtZGdwdV9ib191bnJlc2VydmUocm9iaik7Cj4+Pj4gICAgICAgICAg ICAgICBicmVhazsKPj4+PiAgICAgICAgICAgfQo+Pj4+ICAgICAgICAgICByb2JqLT5wcmVmZXJl ZF9kb21haW5zID0gYXJncy0+dmFsdWUgJgo+Pj4+IChBTURHUFVfR0VNX0RPTUFJTl9WUkFNIHwK Pj4+PiBAQCAtNjc3LDE0ICs2NzUsMTMgQEAgaW50IGFtZGdwdV9nZW1fb3BfaW9jdGwoc3RydWN0 IGRybV9kZXZpY2UgKmRldiwKPj4+PiB2b2lkICpkYXRhLAo+Pj4+ICAgICAgICAgICByb2JqLT5h bGxvd2VkX2RvbWFpbnMgPSByb2JqLT5wcmVmZXJlZF9kb21haW5zOwo+Pj4+ICAgICAgICAgICBp ZiAocm9iai0+YWxsb3dlZF9kb21haW5zID09IEFNREdQVV9HRU1fRE9NQUlOX1ZSQU0pCj4+Pj4g ICAgICAgICAgICAgICByb2JqLT5hbGxvd2VkX2RvbWFpbnMgfD0gQU1ER1BVX0dFTV9ET01BSU5f R1RUOwo+Pj4+IC0KPj4+PiAtICAgICAgICBhbWRncHVfYm9fdW5yZXNlcnZlKHJvYmopOwo+Pj4+ ICAgICAgICAgICBicmVhazsKPj4+PiAgICAgICBkZWZhdWx0Ogo+Pj4+IC0gICAgICAgIGFtZGdw dV9ib191bnJlc2VydmUocm9iaik7Cj4+Pj4gICAgICAgICAgIHIgPSAtRUlOVkFMOwo+Pj4+ICsg ICAgICAgIGJyZWFrOwo+Pj4+ICAgICAgIH0KPj4+PiAgICsgICAgYW1kZ3B1X2JvX3VucmVzZXJ2 ZShyb2JqKTsKPj4+PiAgIG91dDoKPj4+PiAgICAgICBkcm1fZ2VtX29iamVjdF91bnJlZmVyZW5j ZV91bmxvY2tlZChnb2JqKTsKPj4+PiAgICAgICByZXR1cm4gcjsKPj4+Cj4+IF9fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCj4+IGFtZC1nZnggbWFpbGluZyBs aXN0Cj4+IGFtZC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4+IGh0dHBzOi8vbGlzdHMuZnJl ZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vYW1kLWdmeAo+Cj4KX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KYW1kLWdmeCBtYWlsaW5nIGxpc3QKYW1k LWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcv bWFpbG1hbi9saXN0aW5mby9hbWQtZ2Z4Cg==