From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 44B1AC88E6F for ; Mon, 14 Sep 2026 19:38:46 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 8FA8510F1B0; Mon, 14 Sep 2026 19:38:45 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (1024-bit key; unprotected) header.d=samsung.com header.i=@samsung.com header.b="WTY8xEi6"; dkim-atps=neutral Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) by gabe.freedesktop.org (Postfix) with ESMTPS id 97FC910F1B0 for ; Mon, 14 Sep 2026 19:38:44 +0000 (UTC) Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20260914193842euoutp01953e61d38ec40643bc4d7157964f6df4~VRzWra7uK0314903149euoutp01E; Mon, 14 Sep 2026 19:38:42 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20260914193842euoutp01953e61d38ec40643bc4d7157964f6df4~VRzWra7uK0314903149euoutp01E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1789414722; bh=l4wDoWVeNywfcIR5L4rg3J/vDfSoW2zWF07vjDkO78A=; h=Date:Subject:To:Cc:From:In-Reply-To:References:From; b=WTY8xEi6jJOa1gLnOSUBPvlQpMk4v2dS5Nlb2zkZtStSIF1Pr3VZihsDFbmaj+Y4h 48ffokqJfJoWOeBrkZRq1liliRT+IYnxf1/b09yAMsjlsgBoE69rhThGKgRG7auZzS XuVmAtFsH2iSO/zueW7kE3R3lnmCSs0qp5222L1M= Received: from eusmtip1.samsung.com (unknown [203.254.199.221]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20260914193842eucas1p27f2871f925584e946f2bb24c04b38b90~VRzWUs-Iu3205232052eucas1p2N; Mon, 14 Sep 2026 19:38:42 +0000 (GMT) Received: from [192.168.1.44] (unknown [106.210.136.40]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20260914193840eusmtip1c6e3388713b55ee3f14ee6a855ba8b6e~VRzUiiOIx1812818128eusmtip1N; Mon, 14 Sep 2026 19:38:40 +0000 (GMT) Message-ID: Date: Mon, 14 Sep 2026 21:38:40 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 18/19] riscv: dts: starfive: jh7110: Update DT for display subsystem To: Krzysztof Kozlowski Cc: Vinod Koul , Neil Armstrong , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Andrzej Hajda , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Luca Ceresoli , David Airlie , Simona Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Lee Jones , Andy Yan , Philipp Zabel , Emil Renner Berthing , Hal Feng , Michael Turquette , Stephen Boyd , Brian Masney , Heiko Stuebner , Conor Dooley , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , Dominique Belhachemi , Brian Masney , Jerome Brunet , linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, mfd@lists.linux.dev, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-riscv@lists.infradead.org, Andy Yan , Marek Szyprowski , Maud Spierings , Graham Markall , Icenowy Zheng Content-Language: en-US From: Michal Wilczynski In-Reply-To: <20260910-determined-fantastic-seriema-3ff701@quoll> Content-Transfer-Encoding: 7bit X-CMS-MailID: 20260914193842eucas1p27f2871f925584e946f2bb24c04b38b90 X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" X-RootMTR: 20260904132743eucas1p1e02218d3fb38af95c3dd4bfa24904cab X-EPHeader: CA X-CMS-RootMailID: 20260904132743eucas1p1e02218d3fb38af95c3dd4bfa24904cab References: <20260904-jh7110-clean-send-v3-0-484f9ae72715@samsung.com> <20260904-jh7110-clean-send-v3-18-484f9ae72715@samsung.com> <20260910-determined-fantastic-seriema-3ff701@quoll> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 9/10/26 10:37, Krzysztof Kozlowski wrote: > On Fri, Sep 04, 2026 at 03:27:19PM +0200, Michal Wilczynski wrote: >> diff --git a/arch/riscv/boot/dts/starfive/jh7110.dtsi b/arch/riscv/boot/dts/starfive/jh7110.dtsi >> index 9c3e4598747eb5541effe697044484715569a285..0f981f4c89586269b987be8591037c9461e04703 100644 >> --- a/arch/riscv/boot/dts/starfive/jh7110.dtsi >> +++ b/arch/riscv/boot/dts/starfive/jh7110.dtsi >> @@ -290,12 +290,6 @@ gmac1_rmii_refin: gmac1-rmii-refin-clock { >> #clock-cells = <0>; >> }; >> >> - hdmitx0_pixelclk: hdmitx0-pixel-clock { >> - compatible = "fixed-clock"; >> - clock-output-names = "hdmitx0_pixelclk"; >> - #clock-cells = <0>; >> - }; >> - >> i2srx_bclk_ext: i2srx-bclk-ext-clock { >> compatible = "fixed-clock"; >> clock-output-names = "i2srx_bclk_ext"; >> @@ -352,6 +346,13 @@ tdm_ext: tdm-ext-clock { >> #clock-cells = <0>; >> }; >> >> + xin24m: xin24m { > > Other clocks are called foo-clock, so follow this as well (even though > it does not follow recommended practice of clock-foo, but at least some > consistency). will rename to to xin24m-clock > > Best regards, > Krzysztof > > Best regards, -- Michal Wilczynski From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A1589C88E6F for ; Mon, 14 Sep 2026 19:38:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:References:In-Reply-To:From:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=gD+8QIrj9SZYsSZg+g3rRud4bA8JVVze9L/ZfhnQXfE=; b=w7wMmTdkyO+yxm Bxq/H9MIyBmOVsU6Uje3eiqGabhdVUiV9lMNthFQtDCqt4i064MIgXQiMYGDVoA0bVNrWRRE1n2tk EzxPy7iE9DvU1oBuhZvcDyi3jGeTaF/DKWgddOdd4uFG8+l9izD3nqa3C2fMkreRaPxKkuf+lOLVj 3EHQhbTbPQ8byKEr8aJmydWOIIAIIrq4HGs9PPFUFwwbWgL0QAuy2+RoU4FIMcwM86zrta3e73YhB rDe/lDsKMYl/VAI1HqUaRHwjF/AiadCJQJeWnbjK/9N8fcA5gsv5i/YF+HTM7ApRRUUBzlKoaQ/lU uujwsjZW+23/wEoZWD6w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1x6CVz-00000004Xor-1Xog; Mon, 14 Sep 2026 19:38:55 +0000 Received: from mailout1.w1.samsung.com ([210.118.77.11]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1x6CVq-00000004Xkq-0vAr; Mon, 14 Sep 2026 19:38:47 +0000 Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20260914193842euoutp01953e61d38ec40643bc4d7157964f6df4~VRzWra7uK0314903149euoutp01E; Mon, 14 Sep 2026 19:38:42 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20260914193842euoutp01953e61d38ec40643bc4d7157964f6df4~VRzWra7uK0314903149euoutp01E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1789414722; bh=l4wDoWVeNywfcIR5L4rg3J/vDfSoW2zWF07vjDkO78A=; h=Date:Subject:To:Cc:From:In-Reply-To:References:From; b=WTY8xEi6jJOa1gLnOSUBPvlQpMk4v2dS5Nlb2zkZtStSIF1Pr3VZihsDFbmaj+Y4h 48ffokqJfJoWOeBrkZRq1liliRT+IYnxf1/b09yAMsjlsgBoE69rhThGKgRG7auZzS XuVmAtFsH2iSO/zueW7kE3R3lnmCSs0qp5222L1M= Received: from eusmtip1.samsung.com (unknown [203.254.199.221]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20260914193842eucas1p27f2871f925584e946f2bb24c04b38b90~VRzWUs-Iu3205232052eucas1p2N; Mon, 14 Sep 2026 19:38:42 +0000 (GMT) Received: from [192.168.1.44] (unknown [106.210.136.40]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20260914193840eusmtip1c6e3388713b55ee3f14ee6a855ba8b6e~VRzUiiOIx1812818128eusmtip1N; Mon, 14 Sep 2026 19:38:40 +0000 (GMT) Message-ID: Date: Mon, 14 Sep 2026 21:38:40 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 18/19] riscv: dts: starfive: jh7110: Update DT for display subsystem To: Krzysztof Kozlowski Cc: Vinod Koul , Neil Armstrong , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Andrzej Hajda , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Luca Ceresoli , David Airlie , Simona Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Lee Jones , Andy Yan , Philipp Zabel , Emil Renner Berthing , Hal Feng , Michael Turquette , Stephen Boyd , Brian Masney , Heiko Stuebner , Conor Dooley , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , Dominique Belhachemi , Brian Masney , Jerome Brunet , linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, mfd@lists.linux.dev, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-riscv@lists.infradead.org, Andy Yan , Marek Szyprowski , Maud Spierings , Graham Markall , Icenowy Zheng Content-Language: en-US From: Michal Wilczynski In-Reply-To: <20260910-determined-fantastic-seriema-3ff701@quoll> X-CMS-MailID: 20260914193842eucas1p27f2871f925584e946f2bb24c04b38b90 X-Msg-Generator: CA X-RootMTR: 20260904132743eucas1p1e02218d3fb38af95c3dd4bfa24904cab X-EPHeader: CA X-CMS-RootMailID: 20260904132743eucas1p1e02218d3fb38af95c3dd4bfa24904cab References: <20260904-jh7110-clean-send-v3-0-484f9ae72715@samsung.com> <20260904-jh7110-clean-send-v3-18-484f9ae72715@samsung.com> <20260910-determined-fantastic-seriema-3ff701@quoll> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260914_123846_525192_CAF2C1C2 X-CRM114-Status: GOOD ( 14.16 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org On 9/10/26 10:37, Krzysztof Kozlowski wrote: > On Fri, Sep 04, 2026 at 03:27:19PM +0200, Michal Wilczynski wrote: >> diff --git a/arch/riscv/boot/dts/starfive/jh7110.dtsi b/arch/riscv/boot/dts/starfive/jh7110.dtsi >> index 9c3e4598747eb5541effe697044484715569a285..0f981f4c89586269b987be8591037c9461e04703 100644 >> --- a/arch/riscv/boot/dts/starfive/jh7110.dtsi >> +++ b/arch/riscv/boot/dts/starfive/jh7110.dtsi >> @@ -290,12 +290,6 @@ gmac1_rmii_refin: gmac1-rmii-refin-clock { >> #clock-cells = <0>; >> }; >> >> - hdmitx0_pixelclk: hdmitx0-pixel-clock { >> - compatible = "fixed-clock"; >> - clock-output-names = "hdmitx0_pixelclk"; >> - #clock-cells = <0>; >> - }; >> - >> i2srx_bclk_ext: i2srx-bclk-ext-clock { >> compatible = "fixed-clock"; >> clock-output-names = "i2srx_bclk_ext"; >> @@ -352,6 +346,13 @@ tdm_ext: tdm-ext-clock { >> #clock-cells = <0>; >> }; >> >> + xin24m: xin24m { > > Other clocks are called foo-clock, so follow this as well (even though > it does not follow recommended practice of clock-foo, but at least some > consistency). will rename to to xin24m-clock > > Best regards, > Krzysztof > > Best regards, -- Michal Wilczynski -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy