From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maarten Lankhorst Subject: Re: [PATCH 1/2] drm/fourcc: add a 10bits fully packed variant of NV12 Date: Tue, 22 May 2018 11:12:06 +0200 Message-ID: References: <20180520171705.29690-1-ayaka@soulik.info> <20180520171705.29690-2-ayaka@soulik.info> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20180520171705.29690-2-ayaka@soulik.info> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Randy Li , dri-devel@lists.freedesktop.org Cc: airlied@linux.ie, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, nicolas.dufresne@collabora.com, linux-arm-kernel@lists.infradead.org List-Id: linux-rockchip.vger.kernel.org T3AgMjAtMDUtMTggb20gMTk6MTcgc2NocmVlZiBSYW5keSBMaToKPiBUaGlzIHBpeGVsIGZvcm1h dCBpcyBhIGZ1bGx5IHBhY2tlZCBhbmQgMTBiaXRzIHZhcmlhbnQgb2YgTlYxMi4KPiBBIGx1bWEg cGl4ZWwgd291bGQgdGFrZSAxMGJpdHMgaW4gbWVtb3J5LCB3aXRob3V0IGFueQo+IGZpbGxlZCBi aXRzIGJldHdlZW4gcGl4ZWxzIGluIGEgc3RyaWRlLiBUaGUgY29sb3IgZ2FtdXQKPiBmb2xsb3dz IHRoZSBCVC4yMDIwIHN0YW5kYXJkLgo+Cj4gU2lnbmVkLW9mZi1ieTogUmFuZHkgTGkgPGF5YWth QHNvdWxpay5pbmZvPgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vZHJtX2ZvdXJjYy5jICB8IDEg Kwo+ICBpbmNsdWRlL3VhcGkvZHJtL2RybV9mb3VyY2MuaCB8IDMgKysrCj4gIDIgZmlsZXMgY2hh bmdlZCwgNCBpbnNlcnRpb25zKCspCj4KPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2Ry bV9mb3VyY2MuYyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fZm91cmNjLmMKPiBpbmRleCA1Y2E2Mzk1 Y2Q0ZDMuLjFmNDM5NjdjNDAxMyAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vZHJtX2Zv dXJjYy5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2RybV9mb3VyY2MuYwo+IEBAIC0xNzMsNiAr MTczLDcgQEAgY29uc3Qgc3RydWN0IGRybV9mb3JtYXRfaW5mbyAqX19kcm1fZm9ybWF0X2luZm8o dTMyIGZvcm1hdCkKPiAgCQl7IC5mb3JtYXQgPSBEUk1fRk9STUFUX1VZVlksCQkuZGVwdGggPSAw LCAgLm51bV9wbGFuZXMgPSAxLCAuY3BwID0geyAyLCAwLCAwIH0sIC5oc3ViID0gMiwgLnZzdWIg PSAxIH0sCj4gIAkJeyAuZm9ybWF0ID0gRFJNX0ZPUk1BVF9WWVVZLAkJLmRlcHRoID0gMCwgIC5u dW1fcGxhbmVzID0gMSwgLmNwcCA9IHsgMiwgMCwgMCB9LCAuaHN1YiA9IDIsIC52c3ViID0gMSB9 LAo+ICAJCXsgLmZvcm1hdCA9IERSTV9GT1JNQVRfQVlVViwJCS5kZXB0aCA9IDAsICAubnVtX3Bs YW5lcyA9IDEsIC5jcHAgPSB7IDQsIDAsIDAgfSwgLmhzdWIgPSAxLCAudnN1YiA9IDEsIC5oYXNf YWxwaGEgPSB0cnVlIH0sCj4gKwkJeyAuZm9ybWF0ID0gRFJNX0ZPUk1BVF9OVjEyXzEwTEU0MCwJ LmRlcHRoID0gMCwgIC5udW1fcGxhbmVzID0gMiwgLmNwcCA9IHsgMSwgMiwgMCB9LCAuaHN1YiA9 IDIsIC52c3ViID0gMiB9LAo+ICAJfTsKPiAgCj4gIAl1bnNpZ25lZCBpbnQgaTsKPiBkaWZmIC0t Z2l0IGEvaW5jbHVkZS91YXBpL2RybS9kcm1fZm91cmNjLmggYi9pbmNsdWRlL3VhcGkvZHJtL2Ry bV9mb3VyY2MuaAo+IGluZGV4IGUwNDYxM2QzMGExMy4uOGVhYmYwMWU5NjZmIDEwMDY0NAo+IC0t LSBhL2luY2x1ZGUvdWFwaS9kcm0vZHJtX2ZvdXJjYy5oCj4gKysrIGIvaW5jbHVkZS91YXBpL2Ry bS9kcm1fZm91cmNjLmgKPiBAQCAtMTQwLDYgKzE0MCw5IEBAIGV4dGVybiAiQyIgewo+ICAjZGVm aW5lIERSTV9GT1JNQVRfTlY2MQkJZm91cmNjX2NvZGUoJ04nLCAnVicsICc2JywgJzEnKSAvKiAy eDEgc3Vic2FtcGxlZCBDYjpDciBwbGFuZSAqLwo+ICAjZGVmaW5lIERSTV9GT1JNQVRfTlYyNAkJ Zm91cmNjX2NvZGUoJ04nLCAnVicsICcyJywgJzQnKSAvKiBub24tc3Vic2FtcGxlZCBDcjpDYiBw bGFuZSAqLwo+ICAjZGVmaW5lIERSTV9GT1JNQVRfTlY0MgkJZm91cmNjX2NvZGUoJ04nLCAnVics ICc0JywgJzInKSAvKiBub24tc3Vic2FtcGxlZCBDYjpDciBwbGFuZSAqLwo+ICsvKiBBIGZ1bGx5 IHBhY2tlZCB2YXJpYW50IG9mIE5WMTJfMTBMRTMyICovCj4gKyNkZWZpbmUgRFJNX0ZPUk1BVF9O VjEyXzEwTEU0MAlmb3VyY2NfY29kZSgnUicsICdLJywgJzInLCAnMCcpIC8qIDJ4MiBzdWJzYW1w bGVkIENyOkNiIHBsYW5lICovCj4gKwo+ICAKPiAgLyoKPiAgICogMyBwbGFuZSBZQ2JDcgoKSSB0 aGluayB0aGUgZGVzY3JpcHRpb24gaGVyZSBpcyBzbGlnaHRseSB0b28gdGVyc2UgZm9yIGFkZGlu ZyBhIG5ldyBwYWNrZWQgZm9ybWF0LiBJIHRoaW5rIGl0IHdvdWxkIGJlIGJldHRlcgp0byBkZWZp bmUgYSBuZXcgY2F0ZWdvcnkgZm9yIDEwLWJpdCAyIHBsYW5lIGZvcm1hdHMuCgp+TWFhcnRlbgoK X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 From: maarten.lankhorst@linux.intel.com (Maarten Lankhorst) Date: Tue, 22 May 2018 11:12:06 +0200 Subject: [PATCH 1/2] drm/fourcc: add a 10bits fully packed variant of NV12 In-Reply-To: <20180520171705.29690-2-ayaka@soulik.info> References: <20180520171705.29690-1-ayaka@soulik.info> <20180520171705.29690-2-ayaka@soulik.info> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Op 20-05-18 om 19:17 schreef Randy Li: > This pixel format is a fully packed and 10bits variant of NV12. > A luma pixel would take 10bits in memory, without any > filled bits between pixels in a stride. The color gamut > follows the BT.2020 standard. > > Signed-off-by: Randy Li > --- > drivers/gpu/drm/drm_fourcc.c | 1 + > include/uapi/drm/drm_fourcc.h | 3 +++ > 2 files changed, 4 insertions(+) > > diff --git a/drivers/gpu/drm/drm_fourcc.c b/drivers/gpu/drm/drm_fourcc.c > index 5ca6395cd4d3..1f43967c4013 100644 > --- a/drivers/gpu/drm/drm_fourcc.c > +++ b/drivers/gpu/drm/drm_fourcc.c > @@ -173,6 +173,7 @@ const struct drm_format_info *__drm_format_info(u32 format) > { .format = DRM_FORMAT_UYVY, .depth = 0, .num_planes = 1, .cpp = { 2, 0, 0 }, .hsub = 2, .vsub = 1 }, > { .format = DRM_FORMAT_VYUY, .depth = 0, .num_planes = 1, .cpp = { 2, 0, 0 }, .hsub = 2, .vsub = 1 }, > { .format = DRM_FORMAT_AYUV, .depth = 0, .num_planes = 1, .cpp = { 4, 0, 0 }, .hsub = 1, .vsub = 1, .has_alpha = true }, > + { .format = DRM_FORMAT_NV12_10LE40, .depth = 0, .num_planes = 2, .cpp = { 1, 2, 0 }, .hsub = 2, .vsub = 2 }, > }; > > unsigned int i; > diff --git a/include/uapi/drm/drm_fourcc.h b/include/uapi/drm/drm_fourcc.h > index e04613d30a13..8eabf01e966f 100644 > --- a/include/uapi/drm/drm_fourcc.h > +++ b/include/uapi/drm/drm_fourcc.h > @@ -140,6 +140,9 @@ extern "C" { > #define DRM_FORMAT_NV61 fourcc_code('N', 'V', '6', '1') /* 2x1 subsampled Cb:Cr plane */ > #define DRM_FORMAT_NV24 fourcc_code('N', 'V', '2', '4') /* non-subsampled Cr:Cb plane */ > #define DRM_FORMAT_NV42 fourcc_code('N', 'V', '4', '2') /* non-subsampled Cb:Cr plane */ > +/* A fully packed variant of NV12_10LE32 */ > +#define DRM_FORMAT_NV12_10LE40 fourcc_code('R', 'K', '2', '0') /* 2x2 subsampled Cr:Cb plane */ > + > > /* > * 3 plane YCbCr I think the description here is slightly too terse for adding a new packed format. I think it would be better to define a new category for 10-bit 2 plane formats. ~Maarten From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751340AbeEVJMO (ORCPT ); Tue, 22 May 2018 05:12:14 -0400 Received: from mga02.intel.com ([134.134.136.20]:61358 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750707AbeEVJMN (ORCPT ); Tue, 22 May 2018 05:12:13 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,429,1520924400"; d="scan'208";a="226263775" Subject: Re: [PATCH 1/2] drm/fourcc: add a 10bits fully packed variant of NV12 To: Randy Li , dri-devel@lists.freedesktop.org Cc: hjc@rock-chips.com, heiko@sntech.de, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, nicolas.dufresne@collabora.com, gustavo@padovan.org, seanpaul@chromium.org, airlied@linux.ie References: <20180520171705.29690-1-ayaka@soulik.info> <20180520171705.29690-2-ayaka@soulik.info> From: Maarten Lankhorst Message-ID: Date: Tue, 22 May 2018 11:12:06 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <20180520171705.29690-2-ayaka@soulik.info> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Op 20-05-18 om 19:17 schreef Randy Li: > This pixel format is a fully packed and 10bits variant of NV12. > A luma pixel would take 10bits in memory, without any > filled bits between pixels in a stride. The color gamut > follows the BT.2020 standard. > > Signed-off-by: Randy Li > --- > drivers/gpu/drm/drm_fourcc.c | 1 + > include/uapi/drm/drm_fourcc.h | 3 +++ > 2 files changed, 4 insertions(+) > > diff --git a/drivers/gpu/drm/drm_fourcc.c b/drivers/gpu/drm/drm_fourcc.c > index 5ca6395cd4d3..1f43967c4013 100644 > --- a/drivers/gpu/drm/drm_fourcc.c > +++ b/drivers/gpu/drm/drm_fourcc.c > @@ -173,6 +173,7 @@ const struct drm_format_info *__drm_format_info(u32 format) > { .format = DRM_FORMAT_UYVY, .depth = 0, .num_planes = 1, .cpp = { 2, 0, 0 }, .hsub = 2, .vsub = 1 }, > { .format = DRM_FORMAT_VYUY, .depth = 0, .num_planes = 1, .cpp = { 2, 0, 0 }, .hsub = 2, .vsub = 1 }, > { .format = DRM_FORMAT_AYUV, .depth = 0, .num_planes = 1, .cpp = { 4, 0, 0 }, .hsub = 1, .vsub = 1, .has_alpha = true }, > + { .format = DRM_FORMAT_NV12_10LE40, .depth = 0, .num_planes = 2, .cpp = { 1, 2, 0 }, .hsub = 2, .vsub = 2 }, > }; > > unsigned int i; > diff --git a/include/uapi/drm/drm_fourcc.h b/include/uapi/drm/drm_fourcc.h > index e04613d30a13..8eabf01e966f 100644 > --- a/include/uapi/drm/drm_fourcc.h > +++ b/include/uapi/drm/drm_fourcc.h > @@ -140,6 +140,9 @@ extern "C" { > #define DRM_FORMAT_NV61 fourcc_code('N', 'V', '6', '1') /* 2x1 subsampled Cb:Cr plane */ > #define DRM_FORMAT_NV24 fourcc_code('N', 'V', '2', '4') /* non-subsampled Cr:Cb plane */ > #define DRM_FORMAT_NV42 fourcc_code('N', 'V', '4', '2') /* non-subsampled Cb:Cr plane */ > +/* A fully packed variant of NV12_10LE32 */ > +#define DRM_FORMAT_NV12_10LE40 fourcc_code('R', 'K', '2', '0') /* 2x2 subsampled Cr:Cb plane */ > + > > /* > * 3 plane YCbCr I think the description here is slightly too terse for adding a new packed format. I think it would be better to define a new category for 10-bit 2 plane formats. ~Maarten