From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: References: <20200211003742.863630-1-chris@chris-wilson.co.uk> <20200211004255.GA2535@jack.zhora.eu> <158141747934.5235.15646593670790864278@skylake-alporthouse-com> <52e2f277-e709-05b2-d66a-833fe8b234f1@linux.intel.com> <158142634160.2303.16060810217569990410@skylake-alporthouse-com> From: Tvrtko Ursulin Message-ID: Date: Tue, 11 Feb 2020 13:21:10 +0000 MIME-Version: 1.0 In-Reply-To: <158142634160.2303.16060810217569990410@skylake-alporthouse-com> Content-Language: en-US Subject: Re: [igt-dev] [Intel-gfx] [PATCH i-g-t] i915/gem_exec_nop: Keep a copy of the names List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Chris Wilson , Andi Shyti Cc: igt-dev@lists.freedesktop.org, intel-gfx@lists.freedesktop.org List-ID: On 11/02/2020 13:05, Chris Wilson wrote: > Quoting Tvrtko Ursulin (2020-02-11 13:00:19) >> >> On 11/02/2020 10:37, Chris Wilson wrote: >>> Quoting Andi Shyti (2020-02-11 00:42:55) >>>> Hi Chris, >>>> >>>> On Tue, Feb 11, 2020 at 12:37:42AM +0000, Chris Wilson wrote: >>>>> The engine names are now stored inside the iterator and not as static >>>>> strings. If we wish to use them later, we need to make a copy. >>>> >>>> But we are not using them later. Your patch just copies and frees >>>> an array. >>> >>> They are used inside an igt_info() in the child processes. Output at the >>> moment is quite strange. >> >> I also don't get this - child has a copy of everything how can it not work? > > A copy of what? The intel_engine_data is scoped to the for_each_engine > loop. We're leaking pointers to locations on stack, so they get > clobbered and we print garbage in %s. I misread the the patch while glancing it as forking being done inside the for_engine_loop. Reviewed-by: Tvrtko Ursulin Regards, Tvrtko _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, HK_RANDOM_FROM,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B2E8FC352A3 for ; Tue, 11 Feb 2020 13:21:17 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6C47C206D7 for ; Tue, 11 Feb 2020 13:21:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6C47C206D7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E70886EA5E; Tue, 11 Feb 2020 13:21:16 +0000 (UTC) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4EE636EA5D; Tue, 11 Feb 2020 13:21:15 +0000 (UTC) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Feb 2020 05:21:14 -0800 X-IronPort-AV: E=Sophos;i="5.70,428,1574150400"; d="scan'208";a="226501432" Received: from ayashfe-mobl1.ger.corp.intel.com (HELO [10.251.86.31]) ([10.251.86.31]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/AES256-SHA; 11 Feb 2020 05:21:12 -0800 To: Chris Wilson , Andi Shyti References: <20200211003742.863630-1-chris@chris-wilson.co.uk> <20200211004255.GA2535@jack.zhora.eu> <158141747934.5235.15646593670790864278@skylake-alporthouse-com> <52e2f277-e709-05b2-d66a-833fe8b234f1@linux.intel.com> <158142634160.2303.16060810217569990410@skylake-alporthouse-com> From: Tvrtko Ursulin Organization: Intel Corporation UK Plc Message-ID: Date: Tue, 11 Feb 2020 13:21:10 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <158142634160.2303.16060810217569990410@skylake-alporthouse-com> Content-Language: en-US Subject: Re: [Intel-gfx] [igt-dev] [PATCH i-g-t] i915/gem_exec_nop: Keep a copy of the names X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: igt-dev@lists.freedesktop.org, intel-gfx@lists.freedesktop.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On 11/02/2020 13:05, Chris Wilson wrote: > Quoting Tvrtko Ursulin (2020-02-11 13:00:19) >> >> On 11/02/2020 10:37, Chris Wilson wrote: >>> Quoting Andi Shyti (2020-02-11 00:42:55) >>>> Hi Chris, >>>> >>>> On Tue, Feb 11, 2020 at 12:37:42AM +0000, Chris Wilson wrote: >>>>> The engine names are now stored inside the iterator and not as static >>>>> strings. If we wish to use them later, we need to make a copy. >>>> >>>> But we are not using them later. Your patch just copies and frees >>>> an array. >>> >>> They are used inside an igt_info() in the child processes. Output at the >>> moment is quite strange. >> >> I also don't get this - child has a copy of everything how can it not work? > > A copy of what? The intel_engine_data is scoped to the for_each_engine > loop. We're leaking pointers to locations on stack, so they get > clobbered and we print garbage in %s. I misread the the patch while glancing it as forking being done inside the for_engine_loop. Reviewed-by: Tvrtko Ursulin Regards, Tvrtko _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx