From: Krzysztof Kozlowski <krzk@kernel.org>
To: Christophe Leroy <christophe.leroy@csgroup.eu>,
Qiang Zhao <qiang.zhao@nxp.com>,
Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <brgl@bgdev.pl>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH 3/4] soc: fsl: qe: Add support of IRQ in QE GPIO
Date: Tue, 12 Aug 2025 17:30:28 +0200 [thread overview]
Message-ID: <fd39f667-9153-4c62-9993-2156f2cebf1d@kernel.org> (raw)
In-Reply-To: <22b3847fd0011024c10aff48f1e5223894ce718a.1754996033.git.christophe.leroy@csgroup.eu>
On 12/08/2025 13:02, Christophe Leroy wrote:
>
> qe_gc = kzalloc(sizeof(*qe_gc), GFP_KERNEL);
> if (!qe_gc) {
> @@ -313,6 +324,14 @@ static int qe_gpio_probe(struct platform_device *ofdev)
>
> spin_lock_init(&qe_gc->lock);
>
> + if (!of_property_read_u32(np, "fsl,qe-gpio-irq-mask", &mask)) {
Undocumented ABI. You cannot add such stuff and testing your DTS would
point it out.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-08-12 19:23 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-12 11:02 [PATCH 0/4] Add support of IRQs to QUICC ENGINE GPIOs Christophe Leroy
2025-08-12 11:02 ` [PATCH 1/4] soc: fsl: qe: Add an interrupt controller for QUICC Engine Ports Christophe Leroy
2025-08-13 7:49 ` kernel test robot
2025-08-12 11:02 ` [PATCH 2/4] soc: fsl: qe: Change GPIO driver to a proper platform driver Christophe Leroy
2025-08-12 14:16 ` Bartosz Golaszewski
2025-08-12 14:20 ` Bartosz Golaszewski
2025-08-12 11:02 ` [PATCH 3/4] soc: fsl: qe: Add support of IRQ in QE GPIO Christophe Leroy
2025-08-12 14:21 ` Bartosz Golaszewski
2025-08-18 8:33 ` Christophe Leroy
2025-08-12 15:30 ` Krzysztof Kozlowski [this message]
2025-08-12 11:02 ` [PATCH 4/4] dt-bindings: soc: fsl: qe: Add an interrupt controller for QUICC Engine Ports Christophe Leroy
2025-08-12 14:32 ` Rob Herring (Arm)
2025-08-12 15:23 ` Krzysztof Kozlowski
2025-08-12 17:16 ` Rob Herring
2025-08-18 8:39 ` Christophe Leroy
2025-08-18 8:37 ` Christophe Leroy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fd39f667-9153-4c62-9993-2156f2cebf1d@kernel.org \
--to=krzk@kernel.org \
--cc=brgl@bgdev.pl \
--cc=christophe.leroy@csgroup.eu \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=qiang.zhao@nxp.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.