Re: [PATCH v2] drm: Only select I2C_ALGOBIT for drivers that actually need it

[Javier Martinez Canillas <javierm@redhat.com>]

On 11/28/22 19:16, Thomas Zimmermann wrote:
> Hi
> 
> Am 12.09.22 um 11:15 schrieb Uwe Kleine-König:
>> While working on a drm driver that doesn't need the i2c algobit stuff I
>> noticed that DRM selects this code even tough only 8 drivers actually use
>> it. While also only some drivers use i2c, keep the select for I2C for the
>> next cleanup patch. Still prepare this already by also selecting I2C for
>> the individual drivers.
>>
>> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
>> ---
>> Changes since v1
>> (20210514100142.1182997-1-u.kleine-koenig@pengutronix.de) from
>> 2021-05-14:
>>
>>   - rebased to next-20220909
>>     was something around v5.13-rc2 before, required to fix context
>>     changes in the nouveau Kconfig file. git am -3 handled it just fine.
>>
>> I reverified that no new drivers were added that need a corresponding
>> select.
>>
>> Best regards
>> Uwe
>>
>>   drivers/gpu/drm/Kconfig                 | 5 ++++-
>>   drivers/gpu/drm/ast/Kconfig             | 2 ++
>>   drivers/gpu/drm/gma500/Kconfig          | 2 ++
>>   drivers/gpu/drm/hisilicon/hibmc/Kconfig | 2 ++
>>   drivers/gpu/drm/i915/Kconfig            | 2 ++
>>   drivers/gpu/drm/mgag200/Kconfig         | 2 ++
>>   drivers/gpu/drm/nouveau/Kconfig         | 2 ++
>>   7 files changed, 16 insertions(+), 1 deletion(-)
> 
> amdgpu and radeon also include <linux/i2c-algo-bit.h>. Are they special 
> in some way?
> 

Uwe, do you have an answer for this question? I wan to merge this patch
but don't know if need to wait for a v3 including those drivers too.

-- 
Best regards,

Javier Martinez Canillas
Core Platforms
Red Hat