From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8F12FC83F22 for ; Wed, 16 Jul 2025 10:40:44 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id DA42610E275; Wed, 16 Jul 2025 10:40:43 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; secure) header.d=mailbox.org header.i=@mailbox.org header.b="B7hYPd0s"; dkim-atps=neutral Received: from mout-p-202.mailbox.org (mout-p-202.mailbox.org [80.241.56.172]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9FB7710E275 for ; Wed, 16 Jul 2025 10:40:41 +0000 (UTC) Received: from smtp202.mailbox.org (smtp202.mailbox.org [10.196.197.202]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-202.mailbox.org (Postfix) with ESMTPS id 4bhsys4LmDz9t74; Wed, 16 Jul 2025 12:40:37 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mailbox.org; s=mail20150812; t=1752662437; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wXRQmJDPVKJRTM9t2/aWWBgsSj1CebZBIyG26mAoACM=; b=B7hYPd0sXGdusAka78IUvduxe0Ci1p+1oHluDY03ol10uUz+fenwc70EG27+o+sdiki/p9 grQxAW1HOEmefALZQMCJ/ZgxucS/k9m4RqwN5KSc6MfiDautBp1TkkdZRLdeON/L1tUb/6 NIbUDCHgpxodT8SJ3mKpvFij4FcvvPpfQ82hWzMA5+kZRquCmcofle1igFv/vY8utkgFer 2CnLWIFGPHE9D3TY+zyU6aOY81+9vjN3MoB36XLSTvTfqBmcJRGjvwfz41yP5YUNvt+6sc U3j4qLvOQmelWWEjZjiHTTZJ7ks2TyANAdnoUDC9fMQvyg/ZB3+MVKdnxZQ4wA== Message-ID: Date: Wed, 16 Jul 2025 12:40:35 +0200 MIME-Version: 1.0 Subject: Re: [PATCH] drm/sched: Remove optimization that causes hang when killing dependent jobs To: phasta@kernel.org, "cao, lin" , "dri-devel@lists.freedesktop.org" Cc: "Yin, ZhenGuo (Chris)" , "Deng, Emily" , "Koenig, Christian" , "dakr@kernel.org" , "matthew.brost@intel.com" References: <20250715135033.706126-1-lincao12@amd.com> From: =?UTF-8?Q?Michel_D=C3=A4nzer?= Content-Language: de-CH-frami, en-CA In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-MBO-RS-ID: a53cba667e746d60af1 X-MBO-RS-META: sfpp931esq7hpzddyk8yf3iqdnpiykeq X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 16.07.25 11:57, Philipp Stanner wrote: > On Wed, 2025-07-16 at 09:43 +0000, cao, lin wrote: >> >> Hi Philipp, >> >> >> Thank you for the review. I found that this optimization was >> introduced 9 years ago in commit >> 777dbd458c89d4ca74a659f85ffb5bc817f29a35 ("drm/amdgpu: drop a dummy >> wakeup scheduler"). >> >> >> Given that the codebase has undergone significant changes over these >> 9 years. May I ask if I still need to include the Fixes: tag? > > Yes. It's a helpful marker to see where the problem comes from, and it > adds redundancy helping the stable-kernel maintainers in figuring out > to which kernels to backport it to. > > If stable can't apply a patch to a very old stable kernel because the > code base changed too much, they'll ping us and we might provide a > dedicated fix. > > So like that: > > Cc: stable@vger.kernel.org # v4.6+ > Fixes: 777dbd458c89 ("drm/amdgpu: drop a dummy wakeup scheduler") FWIW, Fixes: alone is enough for getting backported to stable branches, Cc: stable is redundant with it. -- Earthling Michel Dänzer \ GNOME / Xwayland / Mesa developer https://redhat.com \ Libre software enthusiast