All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alex <alex.g@adaptrum.com>
To: Teresa Remmet <t.remmet@phytec.de>, Andrew Lunn <andrew@lunn.ch>
Cc: "David S. Miller" <davem@davemloft.net>,
	Mugunthan V N <mugunthanvnm@ti.com>,
	Grygorii Strashko <grygorii.strashko@ti.com>,
	linux-omap@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: net: ti: cpsw-phy-sel: RGMII is not working on AM335x
Date: Wed, 11 Jan 2017 12:18:54 -0800	[thread overview]
Message-ID: <fd690450-e2a2-9bc6-1dd5-59cfce4e9caf@adaptrum.com> (raw)
In-Reply-To: <1484150255.3777.13.camel@phytec.de>

Hi Teresa

On 01/11/2017 07:57 AM, Teresa Remmet wrote:
> The phy we use is a KSZ9021. And yes we add delays to the
> phy, as you can see. When looking to the dts documentation I probably
> need to set the phy-mode to "rgmii-id" instead, as the phy is providing
> the delays.

Before the change I submitted, every "rgmii*" link was being set up as 
"rgmii-id", regardless of phy-mode. I suspected there might have been 
the odd board here or there that used "rgmii" when the actual mode is 
"rgmii-id".

What confused me the first time around was that I didn't realize the 
delay applies to the phy, not the mac. So "-id" means "the PHY provides 
the delays, so don't add delays on the MAC", just like you realized.

> I make a quick test with that change and it is working. So this seems
> to solve my problem. Thank you for the hint.

I'm glad it was an easy fix. Last time I had issues with RGMII, I had to 
pull out the oscilloscope.

Alex

> Regards,
> Teresa
>

      reply	other threads:[~2017-01-11 20:18 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-11  8:14 net: ti: cpsw-phy-sel: RGMII is not working on AM335x Teresa Remmet
2017-01-11 15:14 ` Andrew Lunn
2017-01-11 15:57   ` Teresa Remmet
2017-01-11 20:18     ` Alex [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fd690450-e2a2-9bc6-1dd5-59cfce4e9caf@adaptrum.com \
    --to=alex.g@adaptrum.com \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=grygorii.strashko@ti.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=mugunthanvnm@ti.com \
    --cc=netdev@vger.kernel.org \
    --cc=t.remmet@phytec.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.