From: Jan Beulich <jbeulich@suse.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: "Andrew Cooper" <andrew.cooper3@citrix.com>,
"Julien Grall" <julien@xen.org>,
"Stefano Stabellini" <sstabellini@kernel.org>,
"Anthony PERARD" <anthony.perard@vates.tech>,
"Michal Orzel" <michal.orzel@amd.com>,
"Roger Pau Monné" <roger@xenproject.org>
Subject: [PATCH v2 2/2] symbols: also special-case symbols aliasing _sinittext
Date: Tue, 25 Aug 2026 16:29:25 +0200 [thread overview]
Message-ID: <fd7dc2f7-6505-42e2-8eaf-fb8e9af21bd4@suse.com> (raw)
In-Reply-To: <bd5ed50e-e537-4033-b5b9-98167886690a@suse.com>
A recent 4.22 randconfig build job hit a situation where (LIVEPATCH=n,
i.e. --all-symbols not specified) both __note_gnu_build_id_end and
_erodata aliased _sinittext on the 1st linking pass, but they didn't on
the 2nd one. As a result two fewer symbols were emitted on the 2nd pass,
causing $(call compare-symbol-tables, ...) to fail.
Extend the existing "corner case" by also considering aliases with
_sinittext (_stext really shouldn't have anything ahead of it), but
discard only non-text symbols.
Signed-off-by: Jan Beulich <jbeulich@suse.com>
---
v2: Re-base over _{s,e}extratext removal. Add const to cast.
--- a/xen/tools/symbols.c
+++ b/xen/tools/symbols.c
@@ -217,6 +217,11 @@ static int symbol_valid(struct sym_entry
if ((s->addr == _etext && strcmp((char*)s->sym + offset, "_etext")) ||
(s->addr == _einittext && strcmp((char*)s->sym + offset, "_einittext")))
return 0;
+ /* Same for non-text aliases of _sinittext or _sextratext. */
+ if (toupper(*s->sym) != 'T'
+ && s->addr == _sinittext
+ && strcmp((const char *)s->sym + offset, "_sinittext"))
+ return 0;
}
/* Exclude symbols which vary between passes. */
next prev parent reply other threads:[~2026-08-25 14:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-25 14:26 [PATCH v2 0/2] symbols: aliasing at text section boundaries Jan Beulich
2026-08-25 14:27 ` [PATCH v2 1/2] symbols: drop _{s,e}extratext Jan Beulich
2026-08-25 14:29 ` Jan Beulich [this message]
2026-08-26 8:28 ` [PATCH v2 2/2] symbols: also special-case symbols aliasing _sinittext Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fd7dc2f7-6505-42e2-8eaf-fb8e9af21bd4@suse.com \
--to=jbeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=anthony.perard@vates.tech \
--cc=julien@xen.org \
--cc=michal.orzel@amd.com \
--cc=roger@xenproject.org \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.