All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Zhang, Qi Z" <qi.z.zhang@intel.com>
To: "Su, Simei" <simei.su@intel.com>, "Yang, Qiming" <qiming.yang@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
	"Wu, Wenjun1" <wenjun1.wu@intel.com>,
	"stable@dpdk.org" <stable@dpdk.org>
Subject: RE: [PATCH] net/ice: fix ieee1588fwd not show PTP timestamp
Date: Tue, 25 Jan 2022 00:56:43 +0000	[thread overview]
Message-ID: <fd882ee6372346dba53ffda996a84a35@intel.com> (raw)
In-Reply-To: <20220120102152.281951-1-simei.su@intel.com>



> -----Original Message-----
> From: Su, Simei <simei.su@intel.com>
> Sent: Thursday, January 20, 2022 6:22 PM
> To: Zhang, Qi Z <qi.z.zhang@intel.com>; Yang, Qiming
> <qiming.yang@intel.com>
> Cc: dev@dpdk.org; Wu, Wenjun1 <wenjun1.wu@intel.com>; Su, Simei
> <simei.su@intel.com>; stable@dpdk.org
> Subject: [PATCH] net/ice: fix ieee1588fwd not show PTP timestamp

Renamed to 
fix missing mbuf offload flag for Rx timestamp

> 
> For received PTP packets, the flag "RTE_MBUF_F_RX_IEEE1588_TMST" has
> not been set which leads to received PTP packet not timestamped by
> hardware shown in testpmd/ieee1588 fwd.
> 
> Fixes: 646dcbe6c701 ("net/ice: support IEEE 1588 PTP")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Simei Su <simei.su@intel.com>

Acked-by: Qi Zhang <qi.z.zhang@intel.com>

Applied to dpdk-next-net-intel.

Thanks
Qi

> ---
>  drivers/net/ice/ice_rxtx.c | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/drivers/net/ice/ice_rxtx.c b/drivers/net/ice/ice_rxtx.c index
> d50acf5..d7276d7 100644
> --- a/drivers/net/ice/ice_rxtx.c
> +++ b/drivers/net/ice/ice_rxtx.c
> @@ -1554,6 +1554,9 @@ ice_rxd_to_vlan_tci(struct rte_mbuf *mb, volatile
> union ice_rx_flex_desc *rxdp)  #if (ICE_LOOK_AHEAD != 8)  #error "PMD ICE:
> ICE_LOOK_AHEAD must be 8\n"
>  #endif
> +
> +#define ICE_PTP_TS_VALID 0x1
> +
>  static inline int
>  ice_rx_scan_hw_ring(struct ice_rx_queue *rxq)  { @@ -1634,6 +1637,10 @@
> ice_rx_scan_hw_ring(struct ice_rx_queue *rxq)
> 
> rte_le_to_cpu_32(rxdp[j].wb.flex_ts.ts_high);
>  				mb->timesync = rxq->queue_id;
>  				pkt_flags |= RTE_MBUF_F_RX_IEEE1588_PTP;
> +				if (rxdp[j].wb.time_stamp_low &
> +				    ICE_PTP_TS_VALID)
> +					pkt_flags |=
> +
> 	RTE_MBUF_F_RX_IEEE1588_TMST;
>  			}
>  #endif
>  			mb->ol_flags |= pkt_flags;
> --
> 2.9.5


      reply	other threads:[~2022-01-25  0:56 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-20 10:21 [PATCH] net/ice: fix ieee1588fwd not show PTP timestamp Simei Su
2022-01-25  0:56 ` Zhang, Qi Z [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fd882ee6372346dba53ffda996a84a35@intel.com \
    --to=qi.z.zhang@intel.com \
    --cc=dev@dpdk.org \
    --cc=qiming.yang@intel.com \
    --cc=simei.su@intel.com \
    --cc=stable@dpdk.org \
    --cc=wenjun1.wu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.