From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-183.mta0.migadu.com (out-183.mta0.migadu.com [91.218.175.183]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DB362274B58 for ; Tue, 1 Jul 2025 15:35:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.183 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751384136; cv=none; b=tM4Of71BnG35+VmQsORqDcRRo3K4Ij86WQ1hl/EXhU40djlN7TR60XvfaFd1eOq2OW8yS6+t5S+Ng9lK6ZaygQBDXwQs2bmlTiR6lzRFacXXDwlPuqxQXrzNyt2XWyZFH7F+/kc73nurdlIXq0NNJfpvEAMG3/YhdBUOj66TZKI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751384136; c=relaxed/simple; bh=Dpe36OfClugyKwIMcaBC3dcK7aOGRu8qtIlgMAQ+2ro=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=YTmzU9ph3hgTsPZUR8/bP8OyAsRvoz/hpDkMP5HOScFC1RS4fugb22ekecS9paxYaNYse7m+/p3gamiFYreETr7Y6MI8s+Nt0gTqxuRiZ+gwNLG/0rxny+ap4lSWyTnK9XS99k+ADtO04lu0VaGEvt2EMrybROp4pN3RN2y70Tw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=HZW+nI2M; arc=none smtp.client-ip=91.218.175.183 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="HZW+nI2M" Message-ID: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1751384121; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+INSP/GK6T+8bv6Vx93kwG7+YR+IlBFm0hRiAEEEXmI=; b=HZW+nI2MTAledHyxlbBKwh7aSa9Lm5EiIUfLAfvH9NMJgPJieoRCcoNNRHtX3e+mw71sFd 4NOewdCxEfciPMKGTCz8e/Yg7H/3mHMEyWf20a0ZlW8cmuQ90oufqHW7gZk6d8Sw7M25gv TQpuKFw/O3FnJLya2Tl1WY3AHBRcnbc= Date: Tue, 1 Jul 2025 11:35:10 -0400 Precedence: bulk X-Mailing-List: linux-mips@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Subject: Re: [PATCH net-next v2 05/18] net: macb: use BIT() macro for capability definitions To: =?UTF-8?Q?Th=C3=A9o_Lebrun?= , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Nicolas Ferre , Claudiu Beznea , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , Samuel Holland , Richard Cochran , Russell King , Thomas Bogendoerfer , Vladimir Kondratiev , Gregory CLEMENT , Cyrille Pitchen , Harini Katakam , Rafal Ozieblo , Haavard Skinnemoen , Jeff Garzik Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, linux-mips@vger.kernel.org, Thomas Petazzoni , Tawfik Bayouk , Andrew Lunn References: <20250627-macb-v2-0-ff8207d0bb77@bootlin.com> <20250627-macb-v2-5-ff8207d0bb77@bootlin.com> Content-Language: en-US X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Sean Anderson In-Reply-To: <20250627-macb-v2-5-ff8207d0bb77@bootlin.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT On 6/27/25 05:08, Théo Lebrun wrote: > Replace all capabilities values by calls to the BIT() macro. > > Reviewed-by: Andrew Lunn > Signed-off-by: Théo Lebrun > --- > drivers/net/ethernet/cadence/macb.h | 40 ++++++++++++++++++------------------- > 1 file changed, 20 insertions(+), 20 deletions(-) > > diff --git a/drivers/net/ethernet/cadence/macb.h b/drivers/net/ethernet/cadence/macb.h > index c9a5c8beb2fa8166195d1d83f187d2d0c62668a8..3b43cb9468e3618754ff2bc6c5f360447bdeeed0 100644 > --- a/drivers/net/ethernet/cadence/macb.h > +++ b/drivers/net/ethernet/cadence/macb.h > @@ -727,26 +727,26 @@ > #define MACB_MAN_C45_CODE 2 > > /* Capability mask bits */ > -#define MACB_CAPS_ISR_CLEAR_ON_WRITE 0x00000001 > -#define MACB_CAPS_USRIO_HAS_CLKEN 0x00000002 > -#define MACB_CAPS_USRIO_DEFAULT_IS_MII_GMII 0x00000004 > -#define MACB_CAPS_NO_GIGABIT_HALF 0x00000008 > -#define MACB_CAPS_USRIO_DISABLED 0x00000010 > -#define MACB_CAPS_JUMBO 0x00000020 > -#define MACB_CAPS_GEM_HAS_PTP 0x00000040 > -#define MACB_CAPS_BD_RD_PREFETCH 0x00000080 > -#define MACB_CAPS_NEEDS_RSTONUBR 0x00000100 > -#define MACB_CAPS_MIIONRGMII 0x00000200 > -#define MACB_CAPS_NEED_TSUCLK 0x00000400 > -#define MACB_CAPS_QUEUE_DISABLE 0x00000800 > -#define MACB_CAPS_PCS 0x01000000 > -#define MACB_CAPS_HIGH_SPEED 0x02000000 > -#define MACB_CAPS_CLK_HW_CHG 0x04000000 > -#define MACB_CAPS_MACB_IS_EMAC 0x08000000 > -#define MACB_CAPS_FIFO_MODE 0x10000000 > -#define MACB_CAPS_GIGABIT_MODE_AVAILABLE 0x20000000 > -#define MACB_CAPS_SG_DISABLED 0x40000000 > -#define MACB_CAPS_MACB_IS_GEM 0x80000000 > +#define MACB_CAPS_ISR_CLEAR_ON_WRITE BIT(0) > +#define MACB_CAPS_USRIO_HAS_CLKEN BIT(1) > +#define MACB_CAPS_USRIO_DEFAULT_IS_MII_GMII BIT(2) > +#define MACB_CAPS_NO_GIGABIT_HALF BIT(3) > +#define MACB_CAPS_USRIO_DISABLED BIT(4) > +#define MACB_CAPS_JUMBO BIT(5) > +#define MACB_CAPS_GEM_HAS_PTP BIT(6) > +#define MACB_CAPS_BD_RD_PREFETCH BIT(7) > +#define MACB_CAPS_NEEDS_RSTONUBR BIT(8) > +#define MACB_CAPS_MIIONRGMII BIT(9) > +#define MACB_CAPS_NEED_TSUCLK BIT(10) > +#define MACB_CAPS_QUEUE_DISABLE BIT(11) > +#define MACB_CAPS_PCS BIT(24) > +#define MACB_CAPS_HIGH_SPEED BIT(25) > +#define MACB_CAPS_CLK_HW_CHG BIT(26) > +#define MACB_CAPS_MACB_IS_EMAC BIT(27) > +#define MACB_CAPS_FIFO_MODE BIT(28) > +#define MACB_CAPS_GIGABIT_MODE_AVAILABLE BIT(29) > +#define MACB_CAPS_SG_DISABLED BIT(30) > +#define MACB_CAPS_MACB_IS_GEM BIT(31) > > /* LSO settings */ > #define MACB_LSO_UFO_ENABLE 0x01 > Reviewed-by: Sean Anderson But since these capabilities don't correspond to hardware registers, can you add a follow-up patch to remove the gap between QUEUE_DISABLE and PCS? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 03A55C83F04 for ; Tue, 1 Jul 2025 18:31:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=tJJ0ksMnwFeKA2qiw2RRTDi/vJHQnvpIiGaccohLebk=; b=j7U173GYc2lpOb eZn3BRDvlh6vX7+yN4S3LgRfSU9oMdgijLiFmAwqnDBUIyQFpbf2iFycVzZUFEHLPrqU2jwWZltqx hdHJ33VOp5rXoze18D4ukqB3PRfZ3cwMqjTnjzJvjIjU9SbsoOJeYRVA1TUSZkbeZa093e8TBPgoJ 2qPAgtKoiSjt6ns9PIqpTFiwho4vnpILVs2VUVOxPlxv9z0HLLVxs8zw1gkftXnMOlhLJCamjbnXq A9zuwEqBEn1xw9bCOTcVVZbl7THZrcgJtZ5M+x1OWDKTGVrD6ksfh9rbZFgN7kWUOAcu3d6/OLorV zoHonvL3uVeXT6eFM9Cw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1uWflL-00000006Knq-3XTD; Tue, 01 Jul 2025 18:31:23 +0000 Received: from out-174.mta0.migadu.com ([2001:41d0:1004:224b::ae]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1uWd1E-00000005uKp-3rrD for linux-riscv@lists.infradead.org; Tue, 01 Jul 2025 15:35:38 +0000 Message-ID: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1751384121; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+INSP/GK6T+8bv6Vx93kwG7+YR+IlBFm0hRiAEEEXmI=; b=HZW+nI2MTAledHyxlbBKwh7aSa9Lm5EiIUfLAfvH9NMJgPJieoRCcoNNRHtX3e+mw71sFd 4NOewdCxEfciPMKGTCz8e/Yg7H/3mHMEyWf20a0ZlW8cmuQ90oufqHW7gZk6d8Sw7M25gv TQpuKFw/O3FnJLya2Tl1WY3AHBRcnbc= Date: Tue, 1 Jul 2025 11:35:10 -0400 MIME-Version: 1.0 Subject: Re: [PATCH net-next v2 05/18] net: macb: use BIT() macro for capability definitions To: =?UTF-8?Q?Th=C3=A9o_Lebrun?= , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Nicolas Ferre , Claudiu Beznea , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , Samuel Holland , Richard Cochran , Russell King , Thomas Bogendoerfer , Vladimir Kondratiev , Gregory CLEMENT , Cyrille Pitchen , Harini Katakam , Rafal Ozieblo , Haavard Skinnemoen , Jeff Garzik Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, linux-mips@vger.kernel.org, Thomas Petazzoni , Tawfik Bayouk , Andrew Lunn References: <20250627-macb-v2-0-ff8207d0bb77@bootlin.com> <20250627-macb-v2-5-ff8207d0bb77@bootlin.com> Content-Language: en-US X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Sean Anderson In-Reply-To: <20250627-macb-v2-5-ff8207d0bb77@bootlin.com> X-Migadu-Flow: FLOW_OUT X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250701_083537_101686_DA7D28AF X-CRM114-Status: GOOD ( 11.68 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org T24gNi8yNy8yNSAwNTowOCwgVGjDqW8gTGVicnVuIHdyb3RlOgo+IFJlcGxhY2UgYWxsIGNhcGFi aWxpdGllcyB2YWx1ZXMgYnkgY2FsbHMgdG8gdGhlIEJJVCgpIG1hY3JvLgo+IAo+IFJldmlld2Vk LWJ5OiBBbmRyZXcgTHVubiA8YW5kcmV3QGx1bm4uY2g+Cj4gU2lnbmVkLW9mZi1ieTogVGjDqW8g TGVicnVuIDx0aGVvLmxlYnJ1bkBib290bGluLmNvbT4KPiAtLS0KPiAgZHJpdmVycy9uZXQvZXRo ZXJuZXQvY2FkZW5jZS9tYWNiLmggfCA0MCArKysrKysrKysrKysrKysrKystLS0tLS0tLS0tLS0t LS0tLS0tCj4gIDEgZmlsZSBjaGFuZ2VkLCAyMCBpbnNlcnRpb25zKCspLCAyMCBkZWxldGlvbnMo LSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9uZXQvZXRoZXJuZXQvY2FkZW5jZS9tYWNiLmgg Yi9kcml2ZXJzL25ldC9ldGhlcm5ldC9jYWRlbmNlL21hY2IuaAo+IGluZGV4IGM5YTVjOGJlYjJm YTgxNjYxOTVkMWQ4M2YxODdkMmQwYzYyNjY4YTguLjNiNDNjYjk0NjhlMzYxODc1NGZmMmJjNmM1 ZjM2MDQ0N2JkZWVlZDAgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9uZXQvZXRoZXJuZXQvY2FkZW5j ZS9tYWNiLmgKPiArKysgYi9kcml2ZXJzL25ldC9ldGhlcm5ldC9jYWRlbmNlL21hY2IuaAo+IEBA IC03MjcsMjYgKzcyNywyNiBAQAo+ICAjZGVmaW5lIE1BQ0JfTUFOX0M0NV9DT0RFCQkJMgo+ICAK PiAgLyogQ2FwYWJpbGl0eSBtYXNrIGJpdHMgKi8KPiAtI2RlZmluZSBNQUNCX0NBUFNfSVNSX0NM RUFSX09OX1dSSVRFCQkweDAwMDAwMDAxCj4gLSNkZWZpbmUgTUFDQl9DQVBTX1VTUklPX0hBU19D TEtFTgkJMHgwMDAwMDAwMgo+IC0jZGVmaW5lIE1BQ0JfQ0FQU19VU1JJT19ERUZBVUxUX0lTX01J SV9HTUlJCTB4MDAwMDAwMDQKPiAtI2RlZmluZSBNQUNCX0NBUFNfTk9fR0lHQUJJVF9IQUxGCQkw eDAwMDAwMDA4Cj4gLSNkZWZpbmUgTUFDQl9DQVBTX1VTUklPX0RJU0FCTEVECQkweDAwMDAwMDEw Cj4gLSNkZWZpbmUgTUFDQl9DQVBTX0pVTUJPCQkJCTB4MDAwMDAwMjAKPiAtI2RlZmluZSBNQUNC X0NBUFNfR0VNX0hBU19QVFAJCQkweDAwMDAwMDQwCj4gLSNkZWZpbmUgTUFDQl9DQVBTX0JEX1JE X1BSRUZFVENICQkweDAwMDAwMDgwCj4gLSNkZWZpbmUgTUFDQl9DQVBTX05FRURTX1JTVE9OVUJS CQkweDAwMDAwMTAwCj4gLSNkZWZpbmUgTUFDQl9DQVBTX01JSU9OUkdNSUkJCQkweDAwMDAwMjAw Cj4gLSNkZWZpbmUgTUFDQl9DQVBTX05FRURfVFNVQ0xLCQkJMHgwMDAwMDQwMAo+IC0jZGVmaW5l IE1BQ0JfQ0FQU19RVUVVRV9ESVNBQkxFCQkJMHgwMDAwMDgwMAo+IC0jZGVmaW5lIE1BQ0JfQ0FQ U19QQ1MJCQkJMHgwMTAwMDAwMAo+IC0jZGVmaW5lIE1BQ0JfQ0FQU19ISUdIX1NQRUVECQkJMHgw MjAwMDAwMAo+IC0jZGVmaW5lIE1BQ0JfQ0FQU19DTEtfSFdfQ0hHCQkJMHgwNDAwMDAwMAo+IC0j ZGVmaW5lIE1BQ0JfQ0FQU19NQUNCX0lTX0VNQUMJCQkweDA4MDAwMDAwCj4gLSNkZWZpbmUgTUFD Ql9DQVBTX0ZJRk9fTU9ERQkJCTB4MTAwMDAwMDAKPiAtI2RlZmluZSBNQUNCX0NBUFNfR0lHQUJJ VF9NT0RFX0FWQUlMQUJMRQkweDIwMDAwMDAwCj4gLSNkZWZpbmUgTUFDQl9DQVBTX1NHX0RJU0FC TEVECQkJMHg0MDAwMDAwMAo+IC0jZGVmaW5lIE1BQ0JfQ0FQU19NQUNCX0lTX0dFTQkJCTB4ODAw MDAwMDAKPiArI2RlZmluZSBNQUNCX0NBUFNfSVNSX0NMRUFSX09OX1dSSVRFCQlCSVQoMCkKPiAr I2RlZmluZSBNQUNCX0NBUFNfVVNSSU9fSEFTX0NMS0VOCQlCSVQoMSkKPiArI2RlZmluZSBNQUNC X0NBUFNfVVNSSU9fREVGQVVMVF9JU19NSUlfR01JSQlCSVQoMikKPiArI2RlZmluZSBNQUNCX0NB UFNfTk9fR0lHQUJJVF9IQUxGCQlCSVQoMykKPiArI2RlZmluZSBNQUNCX0NBUFNfVVNSSU9fRElT QUJMRUQJCUJJVCg0KQo+ICsjZGVmaW5lIE1BQ0JfQ0FQU19KVU1CTwkJCQlCSVQoNSkKPiArI2Rl ZmluZSBNQUNCX0NBUFNfR0VNX0hBU19QVFAJCQlCSVQoNikKPiArI2RlZmluZSBNQUNCX0NBUFNf QkRfUkRfUFJFRkVUQ0gJCUJJVCg3KQo+ICsjZGVmaW5lIE1BQ0JfQ0FQU19ORUVEU19SU1RPTlVC UgkJQklUKDgpCj4gKyNkZWZpbmUgTUFDQl9DQVBTX01JSU9OUkdNSUkJCQlCSVQoOSkKPiArI2Rl ZmluZSBNQUNCX0NBUFNfTkVFRF9UU1VDTEsJCQlCSVQoMTApCj4gKyNkZWZpbmUgTUFDQl9DQVBT X1FVRVVFX0RJU0FCTEUJCQlCSVQoMTEpCj4gKyNkZWZpbmUgTUFDQl9DQVBTX1BDUwkJCQlCSVQo MjQpCj4gKyNkZWZpbmUgTUFDQl9DQVBTX0hJR0hfU1BFRUQJCQlCSVQoMjUpCj4gKyNkZWZpbmUg TUFDQl9DQVBTX0NMS19IV19DSEcJCQlCSVQoMjYpCj4gKyNkZWZpbmUgTUFDQl9DQVBTX01BQ0Jf SVNfRU1BQwkJCUJJVCgyNykKPiArI2RlZmluZSBNQUNCX0NBUFNfRklGT19NT0RFCQkJQklUKDI4 KQo+ICsjZGVmaW5lIE1BQ0JfQ0FQU19HSUdBQklUX01PREVfQVZBSUxBQkxFCUJJVCgyOSkKPiAr I2RlZmluZSBNQUNCX0NBUFNfU0dfRElTQUJMRUQJCQlCSVQoMzApCj4gKyNkZWZpbmUgTUFDQl9D QVBTX01BQ0JfSVNfR0VNCQkJQklUKDMxKQo+ICAKPiAgLyogTFNPIHNldHRpbmdzICovCj4gICNk ZWZpbmUgTUFDQl9MU09fVUZPX0VOQUJMRQkJCTB4MDEKPiAKClJldmlld2VkLWJ5OiBTZWFuIEFu ZGVyc29uIDxzZWFuLmFuZGVyc29uQGxpbnV4LmRldj4KCkJ1dCBzaW5jZSB0aGVzZSBjYXBhYmls aXRpZXMgZG9uJ3QgY29ycmVzcG9uZCB0byBoYXJkd2FyZSByZWdpc3RlcnMsIGNhbgp5b3UgYWRk IGEgZm9sbG93LXVwIHBhdGNoIHRvIHJlbW92ZSB0aGUgZ2FwIGJldHdlZW4gUVVFVUVfRElTQUJM RSBhbmQKUENTPwoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X18KbGludXgtcmlzY3YgbWFpbGluZyBsaXN0CmxpbnV4LXJpc2N2QGxpc3RzLmluZnJhZGVhZC5v cmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1yaXNj dgo=