From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Jacopo Mondi <jacopo.mondi@ideasonboard.com>,
Keke Li <keke.li@amlogic.com>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-media@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, kieran.bingham@ideasonboard.com,
laurent.pinchart@ideasonboard.com, dan.scally@ideasonboard.com
Subject: Re: [PATCH v5 01/10] dt-bindings: media: Add amlogic,c3-mipi-csi2.yaml
Date: Wed, 22 Jan 2025 14:48:07 +0100 [thread overview]
Message-ID: <fd993f74-1d95-4cb8-b6d4-dfbe0931a03d@linaro.org> (raw)
In-Reply-To: <htggncswmu7on2btxkkzvhgrey3yvafjsedtpx3a5ze2gtyxb3@ecyuawmn6q2v>
On 22/01/2025 14:36, Jacopo Mondi wrote:
>>>> + assigned-clocks: true
>>>> +
>>>> + assigned-clock-rates: true
>>> NAK
>>>
>>> Adding new properties *INVALIDATES REVIEW*. Otherwise you can sneak
>>> whatever crap past reviewers.
>>>
>>> Drop all new properties and drop my review tag.
>>
>>
>> OK, will drop all new properties and drop your review tag. Thanks
>>
>
> Krzysztof why should new properties added in-between two revisions be
> dropped ?
You connected two independent issues.
It is not that some new properties should be dropped, because I don't
like new stuff. It's that these two particular properties - added in
this version, but that's coincidence - are not appropriate and should be
dropped because of that reason: not appropriateness.
>
> I understand the "drop my tag if you make changes" but I don't get why
> the newly added properties should be removed.
They are neither needed, nor beneficial. Core schema provides them.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-01-22 13:48 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-27 7:09 [PATCH v5 00/10] Amlogic C3 ISP support Keke Li
2024-12-27 7:09 ` Keke Li via B4 Relay
2024-12-27 7:09 ` [PATCH v5 01/10] dt-bindings: media: Add amlogic,c3-mipi-csi2.yaml Keke Li
2024-12-27 7:09 ` Keke Li via B4 Relay
2024-12-27 7:19 ` Krzysztof Kozlowski
2024-12-27 7:38 ` Keke Li
2025-01-22 13:36 ` Jacopo Mondi
2025-01-22 13:48 ` Krzysztof Kozlowski [this message]
2025-01-22 14:00 ` Jacopo Mondi
2024-12-27 7:09 ` [PATCH v5 02/10] media: platform: Add C3 MIPI CSI-2 driver Keke Li
2024-12-27 7:09 ` Keke Li via B4 Relay
2025-01-22 14:03 ` Jacopo Mondi
2025-02-05 5:49 ` Keke Li
2025-01-23 8:59 ` Jacopo Mondi
2025-02-05 6:00 ` Keke Li
2024-12-27 7:09 ` [PATCH v5 03/10] dt-bindings: media: Add amlogic,c3-mipi-adapter.yaml Keke Li
2024-12-27 7:09 ` Keke Li via B4 Relay
2024-12-27 7:20 ` Krzysztof Kozlowski
2024-12-27 7:40 ` Keke Li
2024-12-27 7:09 ` [PATCH v5 04/10] media: platform: Add C3 MIPI adapter driver Keke Li
2024-12-27 7:09 ` Keke Li via B4 Relay
2025-01-22 16:55 ` Jacopo Mondi
2024-12-27 7:09 ` [PATCH v5 05/10] dt-bindings: media: Add amlogic,c3-isp.yaml Keke Li
2024-12-27 7:09 ` Keke Li via B4 Relay
2024-12-27 7:22 ` Krzysztof Kozlowski
2024-12-27 7:42 ` Keke Li
2025-01-22 13:38 ` Jacopo Mondi
2025-01-23 7:23 ` Krzysztof Kozlowski
2024-12-27 7:09 ` [PATCH v5 06/10] media: Add C3ISP_PARAMS and C3ISP_STATS meta formats Keke Li
2024-12-27 7:09 ` Keke Li via B4 Relay
2024-12-27 7:09 ` [PATCH v5 07/10] media: uapi: Add stats info and parameters buffer for c3 ISP Keke Li
2024-12-27 7:09 ` Keke Li via B4 Relay
2025-01-23 9:57 ` Jacopo Mondi
2025-02-05 6:14 ` Keke Li
2024-12-27 7:09 ` [PATCH v5 08/10] media: platform: Add c3 ISP driver Keke Li
2024-12-27 7:09 ` Keke Li via B4 Relay
2025-01-23 9:50 ` Jacopo Mondi
2025-02-05 6:21 ` Keke Li
2024-12-27 7:09 ` [PATCH v5 09/10] Documentation: media: add documentation file metafmt-c3-isp.rst Keke Li
2024-12-27 7:09 ` Keke Li via B4 Relay
2025-01-23 9:59 ` Jacopo Mondi
2024-12-27 7:09 ` [PATCH v5 10/10] Documentation: media: add documentation file c3-isp.rst Keke Li
2024-12-27 7:09 ` Keke Li via B4 Relay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fd993f74-1d95-4cb8-b6d4-dfbe0931a03d@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=conor+dt@kernel.org \
--cc=dan.scally@ideasonboard.com \
--cc=devicetree@vger.kernel.org \
--cc=jacopo.mondi@ideasonboard.com \
--cc=keke.li@amlogic.com \
--cc=kieran.bingham@ideasonboard.com \
--cc=krzk+dt@kernel.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.