From: Dinh Nguyen <dinguyen@kernel.org>
To: Thorsten Blum <thorsten.blum@linux.dev>
Cc: Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RESEND PATCH] clk: socfpga: clk-pll: Optimize local variables
Date: Thu, 24 Apr 2025 17:33:16 -0500 [thread overview]
Message-ID: <fdb7423f-3bb5-4921-a27f-c8db6f3a6f16@kernel.org> (raw)
In-Reply-To: <FC8B34B6-642F-4228-90FB-D8B3148C03D3@linux.dev>
On 4/22/25 07:22, Thorsten Blum wrote:
> On 8. Apr 2025, at 19:45, Thorsten Blum wrote:
>> On 19. Feb 2025, at 13:42, Dinh Nguyen wrote:
>>> On 2/19/25 04:42, Thorsten Blum wrote:
>>>> Since readl() returns a u32, the local variables reg and bypass can also
>>>> have the data type u32. Furthermore, divf and divq are derived from reg
>>>> and can also be a u32.
>>>> Since do_div() casts the divisor to u32 anyway, changing the data type
>>>> of divq to u32 removes the following Coccinelle/coccicheck warning
>>>> reported by do_div.cocci:
>>>> WARNING: do_div() does a 64-by-32 division, please consider using div64_ul instead
>>>> Compile-tested only.
>>>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>>>> Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
>>>> ---
>>>> drivers/clk/socfpga/clk-pll.c | 4 ++--
>>>
>>> Applied!
>>
>> Did this patch and [*] get lost somehow?
>>
>> They aren't in -next and also didn't make it into the last merge window.
>
> Does anybody else know what happened or where I could find them?
>
This is my bad. I missed the merge window for the PR. I'll resend it
this time.
Dinh
prev parent reply other threads:[~2025-04-24 22:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-19 10:42 [RESEND PATCH] clk: socfpga: clk-pll: Optimize local variables Thorsten Blum
2025-02-19 12:42 ` Dinh Nguyen
2025-04-08 17:45 ` Thorsten Blum
2025-04-22 12:22 ` Thorsten Blum
2025-04-24 22:33 ` Dinh Nguyen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fdb7423f-3bb5-4921-a27f-c8db6f3a6f16@kernel.org \
--to=dinguyen@kernel.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=sboyd@kernel.org \
--cc=thorsten.blum@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.