From: Jarkko Nikula <jarkko.nikula@linux.intel.com>
To: Andi Shyti <andi.shyti@kernel.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Florian Fainelli <florian.fainelli@broadcom.com>,
linux-kernel@vger.kernel.org,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Jan Dabros <jsd@semihalf.com>, Lee Jones <lee@kernel.org>,
Jiawen Wu <jiawenwu@trustnetic.com>,
Mengyuan Lou <mengyuanlou@net-swift.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Maciej Fijalkowski <maciej.fijalkowski@intel.com>,
Andrew Lunn <andrew@lunn.ch>,
Duanqiang Wen <duanqiangwen@net-swift.com>,
"open list:SYNOPSYS DESIGNWARE I2C DRIVER"
<linux-i2c@vger.kernel.org>,
"open list:WANGXUN ETHERNET DRIVER" <netdev@vger.kernel.org>
Subject: Re: [PATCH v3 4/5] mfd: intel_quark_i2c_gpio: Utilize i2c-designware.h
Date: Thu, 2 May 2024 12:19:22 +0300 [thread overview]
Message-ID: <fdbf6547-7e6d-408d-8ed8-13e449de181d@linux.intel.com> (raw)
In-Reply-To: <fidbc7locp32lypdui67crj3qkj3nbcp5vpxcnlxrdmme2sn4c@npdan5ncxxog>
On 4/30/24 12:36 PM, Andi Shyti wrote:
> Hi Andy,
>
> On Fri, Apr 26, 2024 at 05:30:24PM +0300, Andy Shevchenko wrote:
>> On Thu, Apr 25, 2024 at 02:44:37PM -0700, Florian Fainelli wrote:
>>> Rather than open code the i2c_designware string, utilize the newly
>>> defined constant in i2c-designware.h.
>>
>> Acked-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>>
>> P.S>
>> Note, my tags for MFD patches does not imply that I agree on the general idea
>> of this series, it's just in case if it will be approved by the respective
>> maintainers (I²C / MFD / etc).
>
> I waited a bit to see if more comments were coming.
>
Well I had doubts about the idea will it help maintaining code or do the
opposite but didn't receive a reply from the patch author:
https://lore.kernel.org/linux-i2c/62e58960-f568-459d-8690-0c9c608a4d9f@linux.intel.com/
Also Lee Jones have similar concerns:
https://lore.kernel.org/linux-i2c/20240502071751.GA5338@google.com/
next prev parent reply other threads:[~2024-05-02 9:19 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-25 21:44 [PATCH v3 0/5] Define i2c_designware in a header file Florian Fainelli
2024-04-25 21:44 ` [PATCH v3 1/5] i2c: designware: Replace MODULE_ALIAS() with MODULE_DEVICE_TABLE() Florian Fainelli
2024-04-25 21:44 ` [PATCH v3 2/5] i2c: designware: Create shared header hosting driver name Florian Fainelli
2024-04-25 21:44 ` [PATCH v3 3/5] mfd: intel-lpss: Utilize i2c-designware.h Florian Fainelli
2024-04-25 21:44 ` [PATCH v3 4/5] mfd: intel_quark_i2c_gpio: " Florian Fainelli
2024-04-26 14:30 ` Andy Shevchenko
2024-04-30 9:36 ` Andi Shyti
2024-05-02 9:19 ` Jarkko Nikula [this message]
2024-05-02 10:11 ` Lee Jones
2024-05-02 16:08 ` Florian Fainelli
2024-04-25 21:44 ` [PATCH v3 5/5] net: txgbe: " Florian Fainelli
2024-05-02 23:09 ` (subset) [PATCH v3 0/5] Define i2c_designware in a header file Andi Shyti
2024-05-03 6:30 ` Jarkko Nikula
2024-05-03 15:38 ` Andy Shevchenko
2024-05-03 18:26 ` Andi Shyti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fdbf6547-7e6d-408d-8ed8-13e449de181d@linux.intel.com \
--to=jarkko.nikula@linux.intel.com \
--cc=andi.shyti@kernel.org \
--cc=andrew@lunn.ch \
--cc=andriy.shevchenko@linux.intel.com \
--cc=davem@davemloft.net \
--cc=duanqiangwen@net-swift.com \
--cc=edumazet@google.com \
--cc=florian.fainelli@broadcom.com \
--cc=jiawenwu@trustnetic.com \
--cc=jsd@semihalf.com \
--cc=kuba@kernel.org \
--cc=lee@kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maciej.fijalkowski@intel.com \
--cc=mengyuanlou@net-swift.com \
--cc=mika.westerberg@linux.intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.