From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 18A70EB64DA for ; Fri, 21 Jul 2023 01:33:11 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 64689867D1; Fri, 21 Jul 2023 03:33:09 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=starfivetech.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by phobos.denx.de (Postfix, from userid 109) id 8E084867E1; Fri, 21 Jul 2023 03:33:08 +0200 (CEST) Received: from fd01.gateway.ufhost.com (fd01.gateway.ufhost.com [61.152.239.71]) by phobos.denx.de (Postfix) with ESMTP id 7250C86332 for ; Fri, 21 Jul 2023 03:33:06 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=starfivetech.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=minda.chen@starfivetech.com Received: from EXMBX166.cuchost.com (unknown [175.102.18.54]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "EXMBX166", Issuer "EXMBX166" (not verified)) by fd01.gateway.ufhost.com (Postfix) with ESMTP id 0391D81EA; Fri, 21 Jul 2023 09:32:59 +0800 (CST) Received: from EXMBX171.cuchost.com (172.16.6.91) by EXMBX166.cuchost.com (172.16.6.76) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Fri, 21 Jul 2023 09:32:58 +0800 Received: from [192.168.125.127] (113.72.147.86) by EXMBX171.cuchost.com (172.16.6.91) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Fri, 21 Jul 2023 09:32:58 +0800 Message-ID: Date: Fri, 21 Jul 2023 09:32:57 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH v7 1/4] i2c: designware: Add CONFIG_ACPIGEN limitation to designware_i2c_pci.c Content-Language: en-US To: Simon Glass CC: Heiko Schocher , Stefan Roese , Andrew Scull , =?UTF-8?Q?Pali_Roh=c3=a1r?= , "Mark Kettenis" , Rick Chen , Leo , , Mason Huo , Leyfoon Tan , Kevin Xie References: <20230720112333.9255-1-minda.chen@starfivetech.com> <20230720112333.9255-2-minda.chen@starfivetech.com> From: Minda Chen In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [113.72.147.86] X-ClientProxiedBy: EXCAS065.cuchost.com (172.16.6.25) To EXMBX171.cuchost.com (172.16.6.91) X-YovoleRuleAgent: yovoleflag X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean On 2023/7/21 3:42, Simon Glass wrote: > Hi, > > On Thu, 20 Jul 2023 at 05:24, Minda Chen wrote: >> >> As the designware_i2c_pci.c uses ACPI APIs, If some SoCs (StarFive >> JH7110) contain designware i2c and PCI but do not use ACPI, >> This file will be can't be compiled. So add ACPIGEN to >> designware_i2c_pci.c >> >> Signed-off-by: Minda Chen >> --- >> drivers/i2c/Makefile | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/drivers/i2c/Makefile b/drivers/i2c/Makefile >> index 99545df2e5..92b1ec6bc3 100644 >> --- a/drivers/i2c/Makefile >> +++ b/drivers/i2c/Makefile >> @@ -18,9 +18,11 @@ obj-$(CONFIG_SYS_I2C_CADENCE) += i2c-cdns.o >> obj-$(CONFIG_SYS_I2C_CA) += i2c-cortina.o >> obj-$(CONFIG_SYS_I2C_DAVINCI) += davinci_i2c.o >> obj-$(CONFIG_SYS_I2C_DW) += designware_i2c.o >> +ifdef CONFIG_ACPIGEN > > You should use Kconfig to see SYS_I2C_DW depends on ACPIGEN. You might > need a separate I2C_DW_PCI Kconfig. > I think so. I can add Kconfig like this. config SYS_I2C_DW_PCI bool "Designware PCI I2C Controller" depends on SYS_I2C_DW && PCI && APIGEN default y > But that sounds bad to me. Why does it have to generate ACPI tables? > It should work fine without that. > designware_i2c_pci.c contain ACPI and lpss related codes. >> ifdef CONFIG_PCI >> obj-$(CONFIG_SYS_I2C_DW) += designware_i2c_pci.o >> endif >> +endif >> obj-$(CONFIG_SYS_I2C_FSL) += fsl_i2c.o >> obj-$(CONFIG_SYS_I2C_IHS) += ihs_i2c.o >> obj-$(CONFIG_SYS_I2C_INTEL) += intel_i2c.o >> -- >> 2.17.1 >> > > Regards, > Simon