From: Jan Beulich <jbeulich@suse.com>
To: "Marek Marczykowski-Górecki" <marmarek@invisiblethingslab.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
George Dunlap <george.dunlap@citrix.com>,
Julien Grall <julien@xen.org>,
Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
xen-devel@lists.xenproject.org
Subject: Re: [PATCH v6 09/10] drivers/char: fix handling cable re-plug in XHCI console driver
Date: Tue, 6 Sep 2022 11:21:26 +0200 [thread overview]
Message-ID: <fdc79941-361a-b604-238f-4133acfd9ee9@suse.com> (raw)
In-Reply-To: <c53d287bf741831e1eb19137091c00efc3f9b3c8.1662124370.git-series.marmarek@invisiblethingslab.com>
On 02.09.2022 15:17, Marek Marczykowski-Górecki wrote:
> When cable is unplugged, dbc_ensure_running() correctly detects this
> situation (DBC_CTRL_DCR flag is clear), and prevent sending data
> immediately to the device. It gets only queued in work ring buffers.
> When cable is plugged in again, subsequent dbc_flush() will send the
> buffered data.
> But there is a corner case, where no subsequent data was buffered in the
> work buffer, but a TRB was still pending. Ring the doorbell to let the
> controller re-send them. For console output it is rare corner case (TRB
> is pending for a very short time), but for console input it is very
> normal case (there is always one pending TRB for input).
>
> Extract doorbell ringing into separate function to avoid duplication.
>
> Signed-off-by: Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
Acked-by: Jan Beulich <jbeulich@suse.com>
next prev parent reply other threads:[~2022-09-06 9:21 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-02 13:17 [PATCH v6 00/10] Add Xue - console over USB 3 Debug Capability Marek Marczykowski-Górecki
2022-09-02 13:17 ` [PATCH v6 01/10] drivers/char: allow using both dbgp=xhci and dbgp=ehci Marek Marczykowski-Górecki
2022-09-06 15:07 ` Jan Beulich
2022-09-06 15:46 ` Marek Marczykowski-Górecki
2022-09-06 15:54 ` Jan Beulich
2022-09-02 13:17 ` [PATCH v6 02/10] console: support multiple serial console simultaneously Marek Marczykowski-Górecki
2022-09-02 13:17 ` [PATCH v6 03/10] IOMMU: add common API for device reserved memory Marek Marczykowski-Górecki
2022-09-02 13:17 ` [PATCH v6 04/10] IOMMU/VT-d: wire common device reserved memory API Marek Marczykowski-Górecki
2022-09-02 13:17 ` [PATCH v6 05/10] IOMMU/AMD: " Marek Marczykowski-Górecki
2022-09-02 13:17 ` [PATCH v6 06/10] drivers/char: mark DMA buffers as reserved for the XHCI Marek Marczykowski-Górecki
2022-09-02 13:17 ` [PATCH v6 07/10] drivers/char: add RX support to the XHCI driver Marek Marczykowski-Górecki
2022-09-02 13:17 ` [PATCH v6 08/10] drivers/char: allow driving the rest of XHCI by a domain while Xen uses DbC Marek Marczykowski-Górecki
2022-09-02 13:17 ` [PATCH v6 09/10] drivers/char: fix handling cable re-plug in XHCI console driver Marek Marczykowski-Górecki
2022-09-06 9:21 ` Jan Beulich [this message]
2022-09-02 13:17 ` [PATCH v6 10/10] drivers/char: use smp barriers in xhci driver Marek Marczykowski-Górecki
2022-09-06 9:23 ` Jan Beulich
2022-09-06 15:11 ` [PATCH v6 00/10] Add Xue - console over USB 3 Debug Capability Jan Beulich
2022-09-06 16:05 ` Marek Marczykowski-Górecki
2022-09-06 16:12 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fdc79941-361a-b604-238f-4133acfd9ee9@suse.com \
--to=jbeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=george.dunlap@citrix.com \
--cc=julien@xen.org \
--cc=marmarek@invisiblethingslab.com \
--cc=sstabellini@kernel.org \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.