From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C53CEC64EC4 for ; Thu, 9 Mar 2023 12:04:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:References:In-Reply-To:Subject:Cc:To:From :Date:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=JoA0BA5Hx5+lERqiUtu2C52ezpb0dVJG0A2JkeztrY0=; b=qxj1qqjNCsRozG6iCD0Ka1uvvP kZmOTQ+QVQhdNOfb///W21Fo+JRGTFlNXaRiBPwnGY3ad3z3lvU6hrL8hg9L6b20FbqWcXT/S+ZZf 2yKMuDHhFtEXF6mdy6iOq85z+t1E5DR5uIHXpEhKKNFrsQ8LlVDE7iHpf7Asov7PI8o0sFGVo9Lv8 XE5Wtmu9o9jua7gGs0525fi/ggpsncvPiwI2lnyawGIvLNHEnW3ZQgCrw1W4dIIQQGIHNLggwwpoV g6fkr99CQfkEzKKgS34ukKsoatHb6JQ06zic3pc0+HghjkqF9XadTXIitYFGlf9GnTZjR3A2nTmYG saRrJAYQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1paEzK-009lGf-J7; Thu, 09 Mar 2023 12:03:15 +0000 Received: from 3.mo576.mail-out.ovh.net ([188.165.52.203]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1paEpB-009gWo-Sh for linux-arm-kernel@lists.infradead.org; Thu, 09 Mar 2023 11:52:48 +0000 Received: from director4.ghost.mail-out.ovh.net (unknown [10.109.138.76]) by mo576.mail-out.ovh.net (Postfix) with ESMTP id EF0842742B for ; Thu, 9 Mar 2023 11:52:39 +0000 (UTC) Received: from ghost-submission-6684bf9d7b-ml9bn (unknown [10.108.1.233]) by director4.ghost.mail-out.ovh.net (Postfix) with ESMTPS id 23E731FE55; Thu, 9 Mar 2023 11:52:38 +0000 (UTC) Received: from RCM-web10.webmail.mail.ovh.net ([151.80.29.18]) by ghost-submission-6684bf9d7b-ml9bn with ESMTPSA id Tff4BobICWQMaB4AKXspMQ (envelope-from ); Thu, 09 Mar 2023 11:52:38 +0000 MIME-Version: 1.0 Date: Thu, 09 Mar 2023 12:52:37 +0100 From: =?UTF-8?Q?Rafa=C5=82_Mi=C5=82ecki?= To: Srinivas Kandagatla Cc: Miquel Raynal , =?UTF-8?Q?Rafa=C5=82_Mi?= =?UTF-8?Q?=C5=82ecki?= , Rob Herring , Krzysztof Kozlowski , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Michael Walle , gregkh@linuxfoundation.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, u-boot@lists.denx.de Subject: Re: [PATCH 2/4] nvmem: core: allow nvmem_cell_post_process_t callbacks to adjust buffer In-Reply-To: References: <20230222172245.6313-1-zajec5@gmail.com> <20230222172245.6313-3-zajec5@gmail.com> <37f821b8-f681-08e4-d4f1-d37be191ff7f@linaro.org> <20230309113211.6321ce3d@xps-13> <2dc096f5-f5ce-f99b-42ac-0fb24682239a@linaro.org> <20230309122324.4b012a58@xps-13> User-Agent: Roundcube Webmail/1.4.13 Message-ID: X-Sender: rafal@milecki.pl X-Originating-IP: 194.187.74.233 X-Webmail-UserID: rafal@milecki.pl X-Ovh-Tracer-Id: 14449517931571489705 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedvhedrvdduiedgfedvucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuqfggjfdpvefjgfevmfevgfenuceurghilhhouhhtmecuhedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhepggffhffvvefujghffgfkgihitgfgsehtkehjtddtreejnecuhfhrohhmpeftrghfrghlucfoihhlvggtkhhiuceorhgrfhgrlhesmhhilhgvtghkihdrphhlqeenucggtffrrghtthgvrhhnpeejvdelgfeutdfhfeelheegfedtleduleeuvdfgfeefvefhvedtheetjeetfeehgeenucfkphepuddvjedrtddrtddruddpudelgedrudekjedrjeegrddvfeefpdduhedurdektddrvdelrddukeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepihhnvghtpeduvdejrddtrddtrddupdhmrghilhhfrhhomhepoehrrghfrghlsehmihhlvggtkhhirdhplheqpdhnsggprhgtphhtthhopedupdhrtghpthhtoheplhhinhhugidqrghrmhdqkhgvrhhnvghlsehlihhsthhsrdhinhhfrhgruggvrggurdhorhhgpdfovfetjfhoshhtpehmohehjeeipdhmohguvgepshhmthhpohhuth X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230309_035246_271195_65A2C1DC X-CRM114-Status: GOOD ( 17.47 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gMjAyMy0wMy0wOSAxMjo0NCwgU3Jpbml2YXMgS2FuZGFnYXRsYSB3cm90ZToKPiBPbiAwOS8w My8yMDIzIDExOjIzLCBNaXF1ZWwgUmF5bmFsIHdyb3RlOgo+PiBIaSBTcmluaXZhcywKPj4gCj4+ IHNyaW5pdmFzLmthbmRhZ2F0bGFAbGluYXJvLm9yZyB3cm90ZSBvbiBUaHUsIDkgTWFyIDIwMjMg MTA6NTM6MDcgCj4+ICswMDAwOgo+PiAKPj4+IE9uIDA5LzAzLzIwMjMgMTA6MzIsIE1pcXVlbCBS YXluYWwgd3JvdGU6Cj4+Pj4gSGkgU3Jpbml2YXMsCj4+Pj4gCj4+Pj4gc3Jpbml2YXMua2FuZGFn YXRsYUBsaW5hcm8ub3JnIHdyb3RlIG9uIFRodSwgOSBNYXIgMjAyMyAxMDoxMjoyNCAKPj4+PiAr MDAwMDoKPj4+PiAKPj4+Pj4gT24gMjIvMDIvMjAyMyAxNzoyMiwgUmFmYcWCIE1pxYJlY2tpIHdy b3RlOgo+Pj4+Pj4gQEAgLTE3OTEsMTEgKzE3OTIsMTUgQEAgc3NpemVfdCBudm1lbV9kZXZpY2Vf Y2VsbF9yZWFkKHN0cnVjdCAKPj4+Pj4+IG52bWVtX2RldmljZSAqbnZtZW0sCj4+Pj4+PiAgICAg CWlmICghbnZtZW0pCj4+Pj4+PiAgICAgCQlyZXR1cm4gLUVJTlZBTDsKPj4+Pj4+ICAgICA+ICsJ LyogQ2VsbHMgd2l0aCByZWFkX3Bvc3RfcHJvY2VzcyBob29rIG1heSByZWFsbG9jIGJ1ZmZlciB3 ZSAKPj4+Pj4+IGNhbid0IGFsbG93IGhlcmUgKi8KPj4+Pj4+ICsJaWYgKGluZm8tPnJlYWRfcG9z dF9wcm9jZXNzKQo+Pj4+Pj4gKwkJcmV0dXJuIC1FSU5WQUw7Cj4+Pj4+IFRoaXMgc2hvdWxkIHBy b2JhYmx5IGdvIGluIDEvNCBwYXRjaC4gT3RoZXIgdGhhbiB0aGF0IHNlcmllcyBsb29rcyAKPj4+ Pj4gZ29vZCB0byBtZS4KPj4+PiAKPj4+PiBGWUkgcGF0Y2ggMS80IGlzIGFsc28gY2FycmllZCBi eSB0aGUgbnZtZW0tbGF5b3V0cyBzZXJpZXMsIHNvIGl0J3MKPj4+PiBwcm9iYWJseSBiZXN0IHRv IGtlZXAgdGhlc2UgMiBwYXRjaGVzIHNlcGFyYXRlZCB0byBzaW1wbGlmeSB0aGUgCj4+Pj4gbWVy Z2luZy4KPj4+IHRoYXQgaXMgaW50ZXJtZWRpYXRlIHRoaW5nLCBidXQgSWRlYWxseSB0aGlzIGNo YW5nZSBiZWxvbmdzIHRvIDEvNCAKPj4+IHBhdGNoLCBzbyBvbmNlIEkgYXBwbHkgdGhlc2UgcGF0 Y2hlcyB0aGVuIHdlIGNhbiBhbHdheXMgcmViYXNlIGxheW91dCAKPj4+IHNlcmllcyBvbiB0b3Ag b2YgbnZtZW0tbmV4dAo+PiAKPj4gV2VsbCwgSSBzdGlsbCBkb24ndCBzZWUgdGhlIG5lZWQgZm9y IHRoaXMgcGF0Y2ggYmVjYXVzZSB3ZSBoYXZlIG5vIHVzZQo+PiBmb3IgaXQgKmFmdGVyKiB0aGUg aW50cm9kdWN0aW9uIG9mIGxheW91dHMuIFllcyBpbiBzb21lIGNhc2VzIGNoYW5naW5nCj4+IHRo ZSBzaXplIG9mIGEgY2VsbCBtaWdodCBtYXliZSBiZSBuZWVkZWQsIGJ1dCByaWdodCBub3cgdGhl IHVzZSBjYXNlIAo+PiBpcwo+PiB0byBwcm92aWRlIGEgTUFDIGFkZHJlc3MsIHdlIGtub3cgYmVm b3JlaGFuZCB0aGUgc2l6ZSBvZiB0aGUgY2VsbCwgc28KPj4gdGhlcmUgaXMgbm8gbmVlZCwgY3Vy cmVudGx5LCBmb3IgdGhpcyBoYWNrLgo+PiAKPiBBbSBjb25mdXNlZCwgc2hvdWxkIEkgaWdub3Jl IHRoaXMgc2VyaWVzID8KCkknbSBjb25mdXNlZCBubyBsZXNzLgoKSSB0aGluayB3ZSBoYXZlIDMg ZGlmZmVyZW50IG9waW5pb25zIGFuZCBubyBhZ3JlZW1lbnQgb24gaG93IHRvIHByb2NlZWQuCgoK UmFmYcWCIChtZSk6Ck5WTUVNIGNlbGxzIHNob3VsZCBiZSByZWdpc3RlcmVkIGFzIHRoZXkgYXJl IGluIHRoZSByYXcgZm9ybWF0LiBObyBzaXplCmFkanVzdG1lbnRzIHNob3VsZCBoYXBwZW4gd2hp bGUgcmVnaXN0ZXJpbmcgdGhlbS4gSWYgTlZNRU0gY2VsbCByZXF1aXJlcwpzb21lIHJlYWQgcG9z dC1wcm9jZXNzaW5nIHRoZW4gaXRzIHNpemUgc2hvdWxkIGJlIGFkanVzdGVkICp3aGlsZSoKcmVh ZGluZy4KCgpNaWNoYWVsOgoucmVhZF9wb3N0X3Byb2Nlc3MoKSBzaG91bGQgYmUgcmVhbGxvYyB0 aGUgYnVmZmVyCgoKTWlxdWVsOgpXaGlsZSByZWdpc3RlcmluZyBOVk1FTSBjZWxsIGl0cyBzaXpl IHNob3VsZCBiZSBhbHJlYWR5IGFkanVzdGVkIHRvCm1hdGNoIHdoYXQgLnJlYWRfcG9zdF9wcm9j ZXNzKCkgaXMgYWJvdXQgdG8gcmV0dXJuLgoKCkknbSByZWFsbHkgc29ycnkgaWYgSSBnb3QgYW55 b25lJ3MgdmlldyB3cm9uZy4KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxA bGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xp c3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82E01C61DA4 for ; Thu, 9 Mar 2023 11:52:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229768AbjCILwv (ORCPT ); Thu, 9 Mar 2023 06:52:51 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51816 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231564AbjCILwo (ORCPT ); Thu, 9 Mar 2023 06:52:44 -0500 Received: from 3.mo575.mail-out.ovh.net (3.mo575.mail-out.ovh.net [46.105.58.60]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1804CE774C for ; Thu, 9 Mar 2023 03:52:42 -0800 (PST) Received: from director4.ghost.mail-out.ovh.net (unknown [10.108.1.239]) by mo575.mail-out.ovh.net (Postfix) with ESMTP id 0E5FC26CE5 for ; Thu, 9 Mar 2023 11:52:39 +0000 (UTC) Received: from ghost-submission-6684bf9d7b-ml9bn (unknown [10.108.1.233]) by director4.ghost.mail-out.ovh.net (Postfix) with ESMTPS id 23E731FE55; Thu, 9 Mar 2023 11:52:38 +0000 (UTC) Received: from RCM-web10.webmail.mail.ovh.net ([151.80.29.18]) by ghost-submission-6684bf9d7b-ml9bn with ESMTPSA id Tff4BobICWQMaB4AKXspMQ (envelope-from ); Thu, 09 Mar 2023 11:52:38 +0000 MIME-Version: 1.0 Date: Thu, 09 Mar 2023 12:52:37 +0100 From: =?UTF-8?Q?Rafa=C5=82_Mi=C5=82ecki?= To: Srinivas Kandagatla Cc: Miquel Raynal , =?UTF-8?Q?Rafa=C5=82_Mi?= =?UTF-8?Q?=C5=82ecki?= , Rob Herring , Krzysztof Kozlowski , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Michael Walle , gregkh@linuxfoundation.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, u-boot@lists.denx.de Subject: Re: [PATCH 2/4] nvmem: core: allow nvmem_cell_post_process_t callbacks to adjust buffer In-Reply-To: References: <20230222172245.6313-1-zajec5@gmail.com> <20230222172245.6313-3-zajec5@gmail.com> <37f821b8-f681-08e4-d4f1-d37be191ff7f@linaro.org> <20230309113211.6321ce3d@xps-13> <2dc096f5-f5ce-f99b-42ac-0fb24682239a@linaro.org> <20230309122324.4b012a58@xps-13> User-Agent: Roundcube Webmail/1.4.13 Message-ID: X-Sender: rafal@milecki.pl X-Originating-IP: 194.187.74.233 X-Webmail-UserID: rafal@milecki.pl Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Ovh-Tracer-Id: 14449517931571489705 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedvhedrvdduiedgfedvucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuqfggjfdpvefjgfevmfevgfenuceurghilhhouhhtmecuhedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhepggffhffvvefujghffgfkgihitgfgsehtkehjtddtreejnecuhfhrohhmpeftrghfrghlucfoihhlvggtkhhiuceorhgrfhgrlhesmhhilhgvtghkihdrphhlqeenucggtffrrghtthgvrhhnpeejvdelgfeutdfhfeelheegfedtleduleeuvdfgfeefvefhvedtheetjeetfeehgeenucfkphepuddvjedrtddrtddruddpudelgedrudekjedrjeegrddvfeefpdduhedurdektddrvdelrddukeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepihhnvghtpeduvdejrddtrddtrddupdhmrghilhhfrhhomhepoehrrghfrghlsehmihhlvggtkhhirdhplheqpdhnsggprhgtphhtthhopedupdhrtghpthhtohepuggvvhhitggvthhrvggvsehvghgvrhdrkhgvrhhnvghlrdhorhhgpdfovfetjfhoshhtpehmohehjeehpdhmohguvgepshhmthhpohhuth Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 2023-03-09 12:44, Srinivas Kandagatla wrote: > On 09/03/2023 11:23, Miquel Raynal wrote: >> Hi Srinivas, >> >> srinivas.kandagatla@linaro.org wrote on Thu, 9 Mar 2023 10:53:07 >> +0000: >> >>> On 09/03/2023 10:32, Miquel Raynal wrote: >>>> Hi Srinivas, >>>> >>>> srinivas.kandagatla@linaro.org wrote on Thu, 9 Mar 2023 10:12:24 >>>> +0000: >>>> >>>>> On 22/02/2023 17:22, Rafał Miłecki wrote: >>>>>> @@ -1791,11 +1792,15 @@ ssize_t nvmem_device_cell_read(struct >>>>>> nvmem_device *nvmem, >>>>>> if (!nvmem) >>>>>> return -EINVAL; >>>>>> > + /* Cells with read_post_process hook may realloc buffer we >>>>>> can't allow here */ >>>>>> + if (info->read_post_process) >>>>>> + return -EINVAL; >>>>> This should probably go in 1/4 patch. Other than that series looks >>>>> good to me. >>>> >>>> FYI patch 1/4 is also carried by the nvmem-layouts series, so it's >>>> probably best to keep these 2 patches separated to simplify the >>>> merging. >>> that is intermediate thing, but Ideally this change belongs to 1/4 >>> patch, so once I apply these patches then we can always rebase layout >>> series on top of nvmem-next >> >> Well, I still don't see the need for this patch because we have no use >> for it *after* the introduction of layouts. Yes in some cases changing >> the size of a cell might maybe be needed, but right now the use case >> is >> to provide a MAC address, we know beforehand the size of the cell, so >> there is no need, currently, for this hack. >> > Am confused, should I ignore this series ? I'm confused no less. I think we have 3 different opinions and no agreement on how to proceed. Rafał (me): NVMEM cells should be registered as they are in the raw format. No size adjustments should happen while registering them. If NVMEM cell requires some read post-processing then its size should be adjusted *while* reading. Michael: .read_post_process() should be realloc the buffer Miquel: While registering NVMEM cell its size should be already adjusted to match what .read_post_process() is about to return. I'm really sorry if I got anyone's view wrong.