From: Dov Murik <dovmurik@linux.ibm.com>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>, qemu-devel@nongnu.org
Cc: Tom Lendacky <thomas.lendacky@amd.com>,
Eduardo Habkost <ehabkost@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
Richard Henderson <richard.henderson@linaro.org>,
Dov Murik <dovmurik@linux.ibm.com>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH v3 1/2] hw/i386/pc: pc_system_ovmf_table_find: Assert that flash was parsed
Date: Thu, 1 Jul 2021 12:28:29 +0300 [thread overview]
Message-ID: <fdee08fe-c0bf-eb4b-a914-cd26daa476df@linux.ibm.com> (raw)
In-Reply-To: <cf931732-2bae-4ed1-6c62-784f36647fa1@redhat.com>
On 01/07/2021 11:54, Philippe Mathieu-Daudé wrote:
> On 7/1/21 7:27 AM, Dov Murik wrote:
>> Add assertion in pc_system_ovmf_table_find that verifies that the flash
>> was indeed previously parsed (looking for the OVMF table) by
>> pc_system_parse_ovmf_flash.
>>
>> Now pc_system_ovmf_table_find distinguishes between "no one called
>> pc_system_parse_ovmf_flash" (which will abort due to assertion failure)
>> and "the flash was parsed but no OVMF table was found, or it is invalid"
>> (which will return false).
>>
>> Suggested-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>> Signed-off-by: Dov Murik <dovmurik@linux.ibm.com>
>> Reviewed-by: Tom Lendacky <thomas.lendacky@amd.com>
>
> For obvious / checkpatch fixes you can keep the tags ;)
>
> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>
Thanks Phil.
-Dov
next prev parent reply other threads:[~2021-07-01 9:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-01 5:27 [PATCH v3 0/2] hw/i386/pc: Clarify pc_system_ovmf_table_find usage Dov Murik
2021-07-01 5:27 ` [PATCH v3 1/2] hw/i386/pc: pc_system_ovmf_table_find: Assert that flash was parsed Dov Murik
2021-07-01 8:54 ` Philippe Mathieu-Daudé
2021-07-01 9:28 ` Dov Murik [this message]
2021-07-01 5:27 ` [PATCH v3 2/2] hw/i386/pc: Document pc_system_ovmf_table_find Dov Murik
2021-07-12 14:35 ` [PATCH v3 0/2] hw/i386/pc: Clarify pc_system_ovmf_table_find usage Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fdee08fe-c0bf-eb4b-a914-cd26daa476df@linux.ibm.com \
--to=dovmurik@linux.ibm.com \
--cc=ehabkost@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=thomas.lendacky@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.