Re: [cocci] behavior change in semantic patches since c36b51ffc889 …

[Markus Elfring <Markus.Elfring@web.de>]

> For what its worth, I was finally able to get things working pretty much
> the same as before with the following semantic patches:

This is a nice feedback.


>> @@
>> expression hw;
>> @@
>> -ice_free
>> +devm_kfree
>>  (
>> +ice_hw_to_dev(
>>  hw
>> +)
>>  , ...)

Did you observe that the omission of a semicolon at the end
triggered desirable effects?



> and
>
>> @disable drop_cast@
>> void * void_ptr;
>> type T;
>> @@
>> -(T *)void_ptr
>> +void_ptr

Would another SmPL code variant be occasionally helpful?

-(T *)
 void_ptr


Are there cases to consider where casts should be preserved?

Regards,
Markus