From: Taehee Yoo <ap420073@gmail.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: linux-crypto@vger.kernel.org, davem@davemloft.net,
tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com,
jussi.kivilinna@iki.fi, elliott@hpe.com
Subject: Re: [PATCH v3 2/3] crypto: aria-avx: add AES-NI/AVX/x86_64/GFNI assembler implementation of aria cipher
Date: Fri, 16 Sep 2022 19:44:33 +0900 [thread overview]
Message-ID: <fdf50b63-2793-d0bb-04d2-aead6523ad91@gmail.com> (raw)
In-Reply-To: <YyRPVxdZSAqvAXoL@gondor.apana.org.au>
Hi Herbert,
Thanks for your review!
2022. 9. 16. 오후 7:26에 Herbert Xu 이(가) 쓴 글:
> On Mon, Sep 05, 2022 at 09:45:02AM +0000, Taehee Yoo wrote:
>>
>> +struct aria_avx_ops aria_ops;
>
> This creates a new sparse warning:
>
> CHECK ../arch/x86/crypto/aria_aesni_avx_glue.c
> ../arch/x86/crypto/aria_aesni_avx_glue.c:34:21: warning: symbol
'aria_ops' was not declared. Should it be static?
>
> Please fix.
>
Thanks a lot, I checked it with C=1 option.
So I will fix this in the v4 patch.
Thanks a lot!
Taehee Yoo
next prev parent reply other threads:[~2022-09-16 10:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-05 9:45 [PATCH v3 0/3] crypto: aria: add ARIA AES-NI/AVX/x86_64/GFNI implementation Taehee Yoo
2022-09-05 9:45 ` [PATCH v3 1/3] crypto: aria: prepare generic module for optimized implementations Taehee Yoo
2022-09-05 9:45 ` [PATCH v3 2/3] crypto: aria-avx: add AES-NI/AVX/x86_64/GFNI assembler implementation of aria cipher Taehee Yoo
2022-09-16 10:26 ` Herbert Xu
2022-09-16 10:44 ` Taehee Yoo [this message]
2022-09-16 10:52 ` Peter Zijlstra
2022-09-16 12:24 ` Taehee Yoo
2022-09-05 9:45 ` [PATCH v3 3/3] crypto: tcrypt: add async speed test for " Taehee Yoo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fdf50b63-2793-d0bb-04d2-aead6523ad91@gmail.com \
--to=ap420073@gmail.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=davem@davemloft.net \
--cc=elliott@hpe.com \
--cc=herbert@gondor.apana.org.au \
--cc=hpa@zytor.com \
--cc=jussi.kivilinna@iki.fi \
--cc=linux-crypto@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.