All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Wachowski, Karol" <karol.wachowski@linux.intel.com>
To: Jeff Hugo <jeff.hugo@oss.qualcomm.com>, dri-devel@lists.freedesktop.org
Cc: oded.gabbay@gmail.com, lizhi.hou@amd.com,
	andrzej.kacprowski@linux.intel.com,
	dawid.osuchowski@linux.intel.com
Subject: Re: [PATCH] accel/ivpu: Limit SSIDs to 128 on all generations
Date: Wed, 4 Nov 2026 19:13:46 +0100	[thread overview]
Message-ID: <fdf68dde-569d-48f5-be5b-0e18261c7c20@linux.intel.com> (raw)
In-Reply-To: <c7f834be-ab48-41f4-a860-2978eeadb225@oss.qualcomm.com>

On 04-Nov-26 18:41, Jeff Hugo wrote:
> On 11/4/2026 1:29 AM, Karol Wachowski wrote:
>> Some generations support only 128 SSIDs, while the KMD configured 256
>> CD table entries and allowed user contexts up to SSID 130. Align the
>> limit across all generations.
> 
> When I read this, I have the question, why limit to 128 for all 
> generations when I assume some generations support more than 128. Would 
> that not be a handicap for users on the gen(s) which can utilize more? 
> It seems like the justification for applying this lowest common 
> denominator across everything is not quite clear to an outsider.
> 
>> Limit the CD table to 128 entries and the user SSID range to 2-127, so
>> root can create 126 contexts and non-root users 64. Also fix the off by
>> one SSID bounds checks against the CD table size.

Hi,

The commit message could have been clearer. Before this patch the driver 
allowed 128 user contexts (MIN_SSID + 128). Now the limit is 128 SSIDs 
in total, which leaves 126 user contexts.

So the real cost is 2 contexts for root. Non-root stays at 64.
In return the SSID range, the CD table size and the bounds checks all 
match. Testing gets simpler, because we can check exact limits instead 
of loose minimums. The userspace interface also becomes consistent, with 
the same limits everywhere.

I'll add this to the commit message in v2.

Thanks,
Karol

>>
>> Signed-off-by: Karol Wachowski <karol.wachowski@linux.intel.com>
> 


      reply	other threads:[~2026-11-04 18:14 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-04  8:29 [PATCH] accel/ivpu: Limit SSIDs to 128 on all generations Karol Wachowski
2026-11-04 17:41 ` Jeff Hugo
2026-11-04 18:13   ` Wachowski, Karol [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fdf68dde-569d-48f5-be5b-0e18261c7c20@linux.intel.com \
    --to=karol.wachowski@linux.intel.com \
    --cc=andrzej.kacprowski@linux.intel.com \
    --cc=dawid.osuchowski@linux.intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jeff.hugo@oss.qualcomm.com \
    --cc=lizhi.hou@amd.com \
    --cc=oded.gabbay@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.