From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH 28/39] drm/i915: Move intel_execlists_show_requests() aside Date: Wed, 2 Jan 2019 15:15:22 +0000 Message-ID: References: <20190102094139.24014-1-chris@chris-wilson.co.uk> <20190102094139.24014-28-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTPS id 186B16E7DE for ; Wed, 2 Jan 2019 15:15:25 +0000 (UTC) In-Reply-To: <20190102094139.24014-28-chris@chris-wilson.co.uk> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Ck9uIDAyLzAxLzIwMTkgMDk6NDEsIENocmlzIFdpbHNvbiB3cm90ZToKPiBNb3ZlIHRoZSBkZWJ1 ZyBwcmV0dHkgcHJpbnRlciBpbnRvIGEgc3RhbmRhbG9uZSByb3V0aW5lIHByaW9yIHRvCj4gZXh0 ZW5kaW5nIGl0IGluIHVwY29taW5nIGZlYXR1cmUgd29yay4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBD aHJpcyBXaWxzb24gPGNocmlzQGNocmlzLXdpbHNvbi5jby51az4KPiAtLS0KPiAgIGRyaXZlcnMv Z3B1L2RybS9pOTE1L2ludGVsX2VuZ2luZV9jcy5jIHwgNTUgKystLS0tLS0tLS0tLS0tLS0tLS0t LS0tCj4gICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9scmMuYyAgICAgICB8IDU4ICsrKysr KysrKysrKysrKysrKysrKysrKysrCj4gICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9scmMu aCAgICAgICB8IDEwICsrKystCj4gICAzIGZpbGVzIGNoYW5nZWQsIDcxIGluc2VydGlvbnMoKyks IDUyIGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9p bnRlbF9lbmdpbmVfY3MuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2VuZ2luZV9jcy5j Cj4gaW5kZXggNTliOTM0OTAxMmUzLi4zNjE3NzU0NmY2OGIgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVy cy9ncHUvZHJtL2k5MTUvaW50ZWxfZW5naW5lX2NzLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0v aTkxNS9pbnRlbF9lbmdpbmVfY3MuYwo+IEBAIC0xNDIxLDE1ICsxNDIxLDEyIEBAIHZvaWQgaW50 ZWxfZW5naW5lX2R1bXAoc3RydWN0IGludGVsX2VuZ2luZV9jcyAqZW5naW5lLAo+ICAgCQkgICAg ICAgc3RydWN0IGRybV9wcmludGVyICptLAo+ICAgCQkgICAgICAgY29uc3QgY2hhciAqaGVhZGVy LCAuLi4pCj4gICB7Cj4gLQljb25zdCBpbnQgTUFYX1JFUVVFU1RTX1RPX1NIT1cgPSA4Owo+ICAg CXN0cnVjdCBpbnRlbF9icmVhZGNydW1icyAqIGNvbnN0IGIgPSAmZW5naW5lLT5icmVhZGNydW1i czsKPiAtCWNvbnN0IHN0cnVjdCBpbnRlbF9lbmdpbmVfZXhlY2xpc3RzICogY29uc3QgZXhlY2xp c3RzID0gJmVuZ2luZS0+ZXhlY2xpc3RzOwo+ICAgCXN0cnVjdCBpOTE1X2dwdV9lcnJvciAqIGNv bnN0IGVycm9yID0gJmVuZ2luZS0+aTkxNS0+Z3B1X2Vycm9yOwo+IC0Jc3RydWN0IGk5MTVfcmVx dWVzdCAqcnEsICpsYXN0Owo+ICsJc3RydWN0IGk5MTVfcmVxdWVzdCAqcnE7Cj4gICAJaW50ZWxf d2FrZXJlZl90IHdha2VyZWY7Cj4gICAJdW5zaWduZWQgbG9uZyBmbGFnczsKPiAgIAlzdHJ1Y3Qg cmJfbm9kZSAqcmI7Cj4gLQlpbnQgY291bnQ7Cj4gICAKPiAgIAlpZiAoaGVhZGVyKSB7Cj4gICAJ CXZhX2xpc3QgYXA7Cj4gQEAgLTE0OTMsNTIgKzE0OTAsOSBAQCB2b2lkIGludGVsX2VuZ2luZV9k dW1wKHN0cnVjdCBpbnRlbF9lbmdpbmVfY3MgKmVuZ2luZSwKPiAgIAkJZHJtX3ByaW50ZihtLCAi XHREZXZpY2UgaXMgYXNsZWVwOyBza2lwcGluZyByZWdpc3RlciBkdW1wXG4iKTsKPiAgIAl9Cj4g ICAKPiAtCWxvY2FsX2lycV9zYXZlKGZsYWdzKTsKPiAtCXNwaW5fbG9jaygmZW5naW5lLT50aW1l bGluZS5sb2NrKTsKPiAtCj4gLQlsYXN0ID0gTlVMTDsKPiAtCWNvdW50ID0gMDsKPiAtCWxpc3Rf Zm9yX2VhY2hfZW50cnkocnEsICZlbmdpbmUtPnRpbWVsaW5lLnJlcXVlc3RzLCBsaW5rKSB7Cj4g LQkJaWYgKGNvdW50KysgPCBNQVhfUkVRVUVTVFNfVE9fU0hPVyAtIDEpCj4gLQkJCXByaW50X3Jl cXVlc3QobSwgcnEsICJcdFx0RSAiKTsKPiAtCQllbHNlCj4gLQkJCWxhc3QgPSBycTsKPiAtCX0K PiAtCWlmIChsYXN0KSB7Cj4gLQkJaWYgKGNvdW50ID4gTUFYX1JFUVVFU1RTX1RPX1NIT1cpIHsK PiAtCQkJZHJtX3ByaW50ZihtLAo+IC0JCQkJICAgIlx0XHQuLi5za2lwcGluZyAlZCBleGVjdXRp bmcgcmVxdWVzdHMuLi5cbiIsCj4gLQkJCQkgICBjb3VudCAtIE1BWF9SRVFVRVNUU19UT19TSE9X KTsKPiAtCQl9Cj4gLQkJcHJpbnRfcmVxdWVzdChtLCBsYXN0LCAiXHRcdEUgIik7Cj4gLQl9Cj4g LQo+IC0JbGFzdCA9IE5VTEw7Cj4gLQljb3VudCA9IDA7Cj4gLQlkcm1fcHJpbnRmKG0sICJcdFx0 UXVldWUgcHJpb3JpdHk6ICVkXG4iLCBleGVjbGlzdHMtPnF1ZXVlX3ByaW9yaXR5KTsKPiAtCWZv ciAocmIgPSByYl9maXJzdF9jYWNoZWQoJmV4ZWNsaXN0cy0+cXVldWUpOyByYjsgcmIgPSByYl9u ZXh0KHJiKSkgewo+IC0JCXN0cnVjdCBpOTE1X3ByaW9saXN0ICpwID0gcmJfZW50cnkocmIsIHR5 cGVvZigqcCksIG5vZGUpOwo+IC0JCWludCBpOwo+IC0KPiAtCQlwcmlvbGlzdF9mb3JfZWFjaF9y ZXF1ZXN0KHJxLCBwLCBpKSB7Cj4gLQkJCWlmIChjb3VudCsrIDwgTUFYX1JFUVVFU1RTX1RPX1NI T1cgLSAxKQo+IC0JCQkJcHJpbnRfcmVxdWVzdChtLCBycSwgIlx0XHRRICIpOwo+IC0JCQllbHNl Cj4gLQkJCQlsYXN0ID0gcnE7Cj4gLQkJfQo+IC0JfQo+IC0JaWYgKGxhc3QpIHsKPiAtCQlpZiAo Y291bnQgPiBNQVhfUkVRVUVTVFNfVE9fU0hPVykgewo+IC0JCQlkcm1fcHJpbnRmKG0sCj4gLQkJ CQkgICAiXHRcdC4uLnNraXBwaW5nICVkIHF1ZXVlZCByZXF1ZXN0cy4uLlxuIiwKPiAtCQkJCSAg IGNvdW50IC0gTUFYX1JFUVVFU1RTX1RPX1NIT1cpOwo+IC0JCX0KPiAtCQlwcmludF9yZXF1ZXN0 KG0sIGxhc3QsICJcdFx0USAiKTsKPiAtCX0KPiAtCj4gLQlzcGluX3VubG9jaygmZW5naW5lLT50 aW1lbGluZS5sb2NrKTsKPiArCWludGVsX2V4ZWNsaXN0c19zaG93X3JlcXVlc3RzKGVuZ2luZSwg bSwgcHJpbnRfcmVxdWVzdCwgOCk7Cj4gICAKPiAtCXNwaW5fbG9jaygmYi0+cmJfbG9jayk7Cj4g KwlzcGluX2xvY2tfaXJxc2F2ZSgmYi0+cmJfbG9jaywgZmxhZ3MpOwo+ICAgCWZvciAocmIgPSBy Yl9maXJzdCgmYi0+d2FpdGVycyk7IHJiOyByYiA9IHJiX25leHQocmIpKSB7Cj4gICAJCXN0cnVj dCBpbnRlbF93YWl0ICp3ID0gcmJfZW50cnkocmIsIHR5cGVvZigqdyksIG5vZGUpOwo+ICAgCj4g QEAgLTE1NDcsOCArMTUwMSw3IEBAIHZvaWQgaW50ZWxfZW5naW5lX2R1bXAoc3RydWN0IGludGVs X2VuZ2luZV9jcyAqZW5naW5lLAo+ICAgCQkJICAgdGFza19zdGF0ZV90b19jaGFyKHctPnRzayks Cj4gICAJCQkgICB3LT5zZXFubyk7Cj4gICAJfQo+IC0Jc3Bpbl91bmxvY2soJmItPnJiX2xvY2sp Owo+IC0JbG9jYWxfaXJxX3Jlc3RvcmUoZmxhZ3MpOwo+ICsJc3Bpbl91bmxvY2tfaXJxcmVzdG9y ZSgmYi0+cmJfbG9jaywgZmxhZ3MpOwo+ICAgCj4gICAJZHJtX3ByaW50ZihtLCAiSFdTUDpcbiIp Owo+ICAgCWhleGR1bXAobSwgZW5naW5lLT5zdGF0dXNfcGFnZS5wYWdlX2FkZHIsIFBBR0VfU0la RSk7Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2xyYy5jIGIvZHJp dmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfbHJjLmMKPiBpbmRleCA5YmRkN2VjMTI5OTEuLmJjYzVl MGQ4ODEzMCAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9scmMuYwo+ ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2xyYy5jCj4gQEAgLTI2NzYsNiArMjY3 Niw2NCBAQCB2b2lkIGludGVsX2xyX2NvbnRleHRfcmVzdW1lKHN0cnVjdCBkcm1faTkxNV9wcml2 YXRlICppOTE1KQo+ICAgCX0KPiAgIH0KPiAgIAo+ICt2b2lkIGludGVsX2V4ZWNsaXN0c19zaG93 X3JlcXVlc3RzKHN0cnVjdCBpbnRlbF9lbmdpbmVfY3MgKmVuZ2luZSwKPiArCQkJCSAgIHN0cnVj dCBkcm1fcHJpbnRlciAqbSwKPiArCQkJCSAgIHZvaWQgKCpzaG93X3JlcXVlc3QpKHN0cnVjdCBk cm1fcHJpbnRlciAqbSwKPiArCQkJCQkJCXN0cnVjdCBpOTE1X3JlcXVlc3QgKnJxLAo+ICsJCQkJ CQkJY29uc3QgY2hhciAqcHJlZml4KSwKPiArCQkJCSAgIHVuc2lnbmVkIGludCBtYXgpCj4gK3sK PiArCWNvbnN0IHN0cnVjdCBpbnRlbF9lbmdpbmVfZXhlY2xpc3RzICpleGVjbGlzdHMgPSAmZW5n aW5lLT5leGVjbGlzdHM7Cj4gKwlzdHJ1Y3QgaTkxNV9yZXF1ZXN0ICpycSwgKmxhc3Q7Cj4gKwl1 bnNpZ25lZCBsb25nIGZsYWdzOwo+ICsJdW5zaWduZWQgaW50IGNvdW50Owo+ICsJc3RydWN0IHJi X25vZGUgKnJiOwo+ICsKPiArCXNwaW5fbG9ja19pcnFzYXZlKCZlbmdpbmUtPnRpbWVsaW5lLmxv Y2ssIGZsYWdzKTsKPiArCj4gKwlsYXN0ID0gTlVMTDsKPiArCWNvdW50ID0gMDsKPiArCWxpc3Rf Zm9yX2VhY2hfZW50cnkocnEsICZlbmdpbmUtPnRpbWVsaW5lLnJlcXVlc3RzLCBsaW5rKSB7Cj4g KwkJaWYgKGNvdW50KysgPCBtYXggLSAxKQo+ICsJCQlzaG93X3JlcXVlc3QobSwgcnEsICJcdFx0 RSAiKTsKPiArCQllbHNlCj4gKwkJCWxhc3QgPSBycTsKPiArCX0KPiArCWlmIChsYXN0KSB7Cj4g KwkJaWYgKGNvdW50ID4gbWF4KSB7Cj4gKwkJCWRybV9wcmludGYobSwKPiArCQkJCSAgICJcdFx0 Li4uc2tpcHBpbmcgJWQgZXhlY3V0aW5nIHJlcXVlc3RzLi4uXG4iLAo+ICsJCQkJICAgY291bnQg LSBtYXgpOwo+ICsJCX0KPiArCQlzaG93X3JlcXVlc3QobSwgbGFzdCwgIlx0XHRFICIpOwo+ICsJ fQo+ICsKPiArCWxhc3QgPSBOVUxMOwo+ICsJY291bnQgPSAwOwo+ICsJZHJtX3ByaW50ZihtLCAi XHRcdFF1ZXVlIHByaW9yaXR5OiAlZFxuIiwgZXhlY2xpc3RzLT5xdWV1ZV9wcmlvcml0eSk7Cj4g Kwlmb3IgKHJiID0gcmJfZmlyc3RfY2FjaGVkKCZleGVjbGlzdHMtPnF1ZXVlKTsgcmI7IHJiID0g cmJfbmV4dChyYikpIHsKPiArCQlzdHJ1Y3QgaTkxNV9wcmlvbGlzdCAqcCA9IHJiX2VudHJ5KHJi LCB0eXBlb2YoKnApLCBub2RlKTsKPiArCQlpbnQgaTsKPiArCj4gKwkJcHJpb2xpc3RfZm9yX2Vh Y2hfcmVxdWVzdChycSwgcCwgaSkgewo+ICsJCQlpZiAoY291bnQrKyA8IG1heCAtIDEpCj4gKwkJ CQlzaG93X3JlcXVlc3QobSwgcnEsICJcdFx0USAiKTsKPiArCQkJZWxzZQo+ICsJCQkJbGFzdCA9 IHJxOwo+ICsJCX0KPiArCX0KPiArCWlmIChsYXN0KSB7Cj4gKwkJaWYgKGNvdW50ID4gbWF4KSB7 Cj4gKwkJCWRybV9wcmludGYobSwKPiArCQkJCSAgICJcdFx0Li4uc2tpcHBpbmcgJWQgcXVldWVk IHJlcXVlc3RzLi4uXG4iLAo+ICsJCQkJICAgY291bnQgLSBtYXgpOwo+ICsJCX0KPiArCQlzaG93 X3JlcXVlc3QobSwgbGFzdCwgIlx0XHRRICIpOwo+ICsJfQo+ICsKPiArCXNwaW5fdW5sb2NrX2ly cXJlc3RvcmUoJmVuZ2luZS0+dGltZWxpbmUubG9jaywgZmxhZ3MpOwo+ICt9Cj4gKwo+ICAgI2lm IElTX0VOQUJMRUQoQ09ORklHX0RSTV9JOTE1X1NFTEZURVNUKQo+ICAgI2luY2x1ZGUgInNlbGZ0 ZXN0cy9pbnRlbF9scmMuYyIKPiAgICNlbmRpZgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9k cm0vaTkxNS9pbnRlbF9scmMuaCBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2xyYy5oCj4g aW5kZXggZjVhNTUwMmVjZjcwLi4zZDg2YzI3YzZiMzIgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9n cHUvZHJtL2k5MTUvaW50ZWxfbHJjLmgKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRl bF9scmMuaAo+IEBAIC05NywxMSArOTcsMTkgQEAgaW50IGxvZ2ljYWxfeGNzX3JpbmdfaW5pdChz dHJ1Y3QgaW50ZWxfZW5naW5lX2NzICplbmdpbmUpOwo+ICAgICovCj4gICAjZGVmaW5lIExSQ19I RUFERVJfUEFHRVMgTFJDX1BQSFdTUF9QTgo+ICAgCj4gK3N0cnVjdCBkcm1fcHJpbnRlcjsKPiAr Cj4gICBzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZTsKPiAgIHN0cnVjdCBpOTE1X2dlbV9jb250ZXh0 Owo+ICAgCj4gICB2b2lkIGludGVsX2xyX2NvbnRleHRfcmVzdW1lKHN0cnVjdCBkcm1faTkxNV9w cml2YXRlICpkZXZfcHJpdik7Cj4gLQo+ICAgdm9pZCBpbnRlbF9leGVjbGlzdHNfc2V0X2RlZmF1 bHRfc3VibWlzc2lvbihzdHJ1Y3QgaW50ZWxfZW5naW5lX2NzICplbmdpbmUpOwo+ICAgCj4gK3Zv aWQgaW50ZWxfZXhlY2xpc3RzX3Nob3dfcmVxdWVzdHMoc3RydWN0IGludGVsX2VuZ2luZV9jcyAq ZW5naW5lLAo+ICsJCQkJICAgc3RydWN0IGRybV9wcmludGVyICptLAo+ICsJCQkJICAgdm9pZCAo KnNob3dfcmVxdWVzdCkoc3RydWN0IGRybV9wcmludGVyICptLAo+ICsJCQkJCQkJc3RydWN0IGk5 MTVfcmVxdWVzdCAqcnEsCj4gKwkJCQkJCQljb25zdCBjaGFyICpwcmVmaXgpLAo+ICsJCQkJICAg dW5zaWduZWQgaW50IG1heCk7Cj4gKwo+ICAgI2VuZGlmIC8qIF9JTlRFTF9MUkNfSF8gKi8KPiAK ClJldmlld2VkLWJ5OiBUdnJ0a28gVXJzdWxpbiA8dHZydGtvLnVyc3VsaW5AaW50ZWwuY29tPgoK UmVnYXJkcywKClR2cnRrbwpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3Rv cC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRl bC1nZngK