From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56638C4332F for ; Tue, 31 Oct 2023 16:23:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345050AbjJaQXn (ORCPT ); Tue, 31 Oct 2023 12:23:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51016 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344836AbjJaQXm (ORCPT ); Tue, 31 Oct 2023 12:23:42 -0400 Received: from mail-pg1-f169.google.com (mail-pg1-f169.google.com [209.85.215.169]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 49522A6; Tue, 31 Oct 2023 09:23:40 -0700 (PDT) Received: by mail-pg1-f169.google.com with SMTP id 41be03b00d2f7-5bcf83a8f6cso20792a12.2; Tue, 31 Oct 2023 09:23:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698769420; x=1699374220; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=CBWUu0tjqfzQQcXAkjZScnGhPDhYF0A6SWvhtDvbljg=; b=e5/0B01YuUwb7dshMbzA+LN1JbglN6ZXHnSln0m/7bciiMynhBR+4CFUghL3B/4AcP IdLxaDWkZsvzYO1q2taB3AUQ8rw1epZcYrtcfPzUENkhBRD7Ov+YFiIGjbhotaZ1u2ii 039/rNleRCkIdCxcmtLf3slTpdlVkkatuq0uZjpuLTWbPAfwpIKwnHWhHHopDa408hrK 3i3PR5OKi7F+O2NT5lRYhgE0YRq5HI38elxvTISd8LU2/hukHhOUElJTXDi4KhSWzLur hIRWpbbxYS1JsXoortwrphx7V6iaDOHAA3TQzOd0DNSrHeCDNDWkfM7HN0rjZ7TuLYIy 7OKg== X-Gm-Message-State: AOJu0YxEIqeFnDRCe5g6jVvsczEhwTNwrBqAiNPh2axgEmHdjbwsgLdw njBcZr3ky25RPcK/f/zO3yr07DyWjyg= X-Google-Smtp-Source: AGHT+IEiqyEA5Jo7RoN3JI58BhuOtNEOxzgSgsyGJ3lhVwY14vx0QWk1I5bxtuTa8wFF2fi+BzbNVQ== X-Received: by 2002:a17:902:f68f:b0:1cc:25b7:e30d with SMTP id l15-20020a170902f68f00b001cc25b7e30dmr10024790plg.60.1698769419503; Tue, 31 Oct 2023 09:23:39 -0700 (PDT) Received: from ?IPV6:2620:15c:211:201:3a79:8603:fbab:a9fd? ([2620:15c:211:201:3a79:8603:fbab:a9fd]) by smtp.gmail.com with ESMTPSA id ik22-20020a170902ab1600b001c5eb2c4d8csm1560142plb.160.2023.10.31.09.23.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 31 Oct 2023 09:23:38 -0700 (PDT) Message-ID: Date: Tue, 31 Oct 2023 09:23:37 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] scsi: ufs: ufs-sysfs: Expose UFS power info Content-Language: en-US To: Can Guo , mani@kernel.org, stanley.chu@mediatek.com, adrian.hunter@intel.com, beanhuo@micron.com, avri.altman@wdc.com, junwoo80.lee@samsung.com, martin.petersen@oracle.com Cc: linux-scsi@vger.kernel.org, Alim Akhtar , "James E.J. Bottomley" , Lu Hongfei , open list References: <1698745992-5699-1-git-send-email-quic_cang@quicinc.com> From: Bart Van Assche In-Reply-To: <1698745992-5699-1-git-send-email-quic_cang@quicinc.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org On 10/31/23 02:53, Can Guo wrote: > +What: /sys/bus/platform/drivers/ufshcd/*/power_info/mode > +What: /sys/bus/platform/devices/*.ufs/power_info/mode > +Date: September 2023 > +Contact: Can Guo > +Description: This file shows the UniPro power mode of UFS link: > + == ==================================================== > + 1 FAST_MODE > + 2 SLOW_MODE > + 4 FASTAUTO_MODE > + 5 SLOWAUTO_MODE > + == ==================================================== > + > + The file is read only. For this attribute and the attributes below, shouldn't these be exported as text instead of as numbers? Shell scripts that read and use these attributes will be much easier to read if these attributes are changed from numeric into a textual. Thanks, Bart.