From: Zhu Yanjun <yanjun.zhu@linux.dev>
To: Jason Gunthorpe <jgg@ziepe.ca>, Bart Van Assche <bvanassche@acm.org>
Cc: Bob Pearson <rpearsonhpe@gmail.com>,
"Daisuke Matsuda (Fujitsu)" <matsuda-daisuke@fujitsu.com>,
Leon Romanovsky <leon@kernel.org>,
"zyjzyj2000@gmail.com" <zyjzyj2000@gmail.com>,
"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
"shinichiro.kawasaki@wdc.com" <shinichiro.kawasaki@wdc.com>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
Zhu Yanjun <yanjun.zhu@intel.com>
Subject: Re: [PATCH 1/1] Revert "RDMA/rxe: Add workqueue support for rxe tasks"
Date: Thu, 12 Oct 2023 19:49:35 +0800 [thread overview]
Message-ID: <fe0fbdd9-93a2-4478-b1ef-9b2420c0d76e@linux.dev> (raw)
In-Reply-To: <20231011231201.GH55194@ziepe.ca>
在 2023/10/12 7:12, Jason Gunthorpe 写道:
> On Wed, Oct 11, 2023 at 01:14:16PM -0700, Bart Van Assche wrote:
>> On 10/11/23 08:51, Jason Gunthorpe wrote:
>>> If we revert it then rxe will probably just stop development
>>> entirely. Daisuke's ODP work will be blocked and if Bob was able to
>>> fix it he would have done so already. Which mean's Bobs ongoing work
>>> is lost too.
>>
>> If Daisuke's work depends on the RXE changes then Daisuke may decide
>> to help with the RXE changes.
>>
>> Introducing regressions while refactoring code is not acceptable.
>
> Generally, but I don't view rxe as a production part of the kernel so
> I prefer to give time to resolve it.
>
>> I don't have enough spare time to help with the RXE driver.
commit 11ab7cc7ee32d6c3e16ac74c34c4bbdbf8f99292
Author: Bart Van Assche <bvanassche@acm.org>
Date: Tue Aug 22 09:57:07 2023 -0700
Change the default RDMA driver from rdma_rxe to siw
Since the siw driver is more stable than the rdma_rxe driver,
change the
default into siw. See e.g.
https://lore.kernel.org/all/c3d1a966-b9b0-d015-38ec-86270b5045fc@acm.org/.
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Signed-off-by: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>
>
> Nor I
>
> Jason
next prev parent reply other threads:[~2023-10-12 11:59 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-22 16:32 [PATCH 1/1] Revert "RDMA/rxe: Add workqueue support for rxe tasks" Zhu Yanjun
2023-09-22 16:42 ` Bart Van Assche
2023-09-26 9:43 ` Leon Romanovsky
2023-09-26 9:43 ` Leon Romanovsky
2023-09-26 14:06 ` Leon Romanovsky
2023-09-26 17:05 ` Bart Van Assche
2023-09-26 18:34 ` Bob Pearson
2023-09-26 20:24 ` Bart Van Assche
2023-09-27 0:08 ` Rain River
2023-09-27 16:36 ` Bob Pearson
2023-09-27 16:51 ` Bob Pearson
2023-10-01 6:30 ` Leon Romanovsky
[not found] ` <8afdc6ac-1f31-c12f-a60c-811a0101fc89@linux.dev>
[not found] ` <88137631-028c-4a60-b7b1-ac55f98badbf@app.fastmail.com>
[not found] ` <a0d05185-7f03-b3a8-1493-2b50302161d2@linux.dev>
[not found] ` <e1576d79-642d-40bd-8e55-c37009cb6426@app.fastmail.com>
[not found] ` <1290ba1d-6102-ea17-c80e-9f1280b26067@linux.dev>
[not found] ` <20231003095901.GA51282@unreal>
[not found] ` <5ea7795a-49a6-2ba0-4caf-02ba7b6961f9@linux.dev>
[not found] ` <20231003181123.GD51282@unreal>
[not found] ` <be4c9b0e-8acf-7fee-5ad0-209df5d3b0f9@linux.dev>
2023-10-04 1:00 ` Zhu Yanjun
2023-10-04 17:44 ` Bart Van Assche
2023-10-04 21:16 ` Bob Pearson
2023-10-04 3:41 ` Zhu Yanjun
2023-10-04 17:43 ` Bart Van Assche
2023-10-04 18:38 ` Jason Gunthorpe
2023-10-05 9:25 ` Zhu Yanjun
2023-10-05 14:21 ` Jason Gunthorpe
2023-10-05 14:50 ` Bart Van Assche
2023-10-05 15:56 ` Jason Gunthorpe
2023-10-06 15:58 ` Bob Pearson
2023-10-07 0:35 ` Zhu Yanjun
2023-10-08 16:01 ` Zhu Yanjun
2023-10-08 17:09 ` Leon Romanovsky
2023-10-10 4:53 ` Daisuke Matsuda (Fujitsu)
2023-10-10 16:09 ` Jason Gunthorpe
2023-10-10 21:29 ` Bart Van Assche
2023-10-11 15:51 ` Jason Gunthorpe
2023-10-11 20:14 ` Bart Van Assche
2023-10-11 23:12 ` Jason Gunthorpe
2023-10-12 11:49 ` Zhu Yanjun [this message]
2023-10-12 15:38 ` Bob Pearson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fe0fbdd9-93a2-4478-b1ef-9b2420c0d76e@linux.dev \
--to=yanjun.zhu@linux.dev \
--cc=bvanassche@acm.org \
--cc=jgg@ziepe.ca \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=matsuda-daisuke@fujitsu.com \
--cc=rpearsonhpe@gmail.com \
--cc=shinichiro.kawasaki@wdc.com \
--cc=yanjun.zhu@intel.com \
--cc=zyjzyj2000@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.