From: Stefan Roese <sr@denx.de>
To: Simon Glass <sjg@chromium.org>
Cc: Tom Rini <trini@konsulko.com>,
U-Boot Mailing List <u-boot@lists.denx.de>,
Aaron Williams <awilliams@marvell.com>,
Chandrakala Chavva <cchavva@marvell.com>
Subject: Re: [PATCH v6 0/8] Add support for cyclic function execution infrastruture
Date: Thu, 15 Sep 2022 06:58:14 +0200 [thread overview]
Message-ID: <fe10f3d4-847e-8863-7d0b-af4319d84119@denx.de> (raw)
In-Reply-To: <CAPnjgZ1YyTw3azwFW34XyuwY7+_+5seKVb4uQwT3SqVxbPLYTQ@mail.gmail.com>
Hi Simon,
On 14.09.22 19:09, Simon Glass wrote:
> Hi Stefan,
>
> On Wed, 14 Sept 2022 at 09:19, Stefan Roese <sr@denx.de> wrote:
>>
>> On 14.09.22 16:47, Tom Rini wrote:
>>> On Wed, Sep 14, 2022 at 04:29:36PM +0200, Stefan Roese wrote:
>>>> On 14.09.22 14:58, Tom Rini wrote:
>>>>> On Fri, 2 Sep 2022 13:57:46 +0200, Stefan Roese wrote:
>>>>>
>>>>>> This patchset adds the basic infrastructure to periodically execute
>>>>>> code, e.g. all 100ms. Examples for such functions might be LED blinking
>>>>>> etc. The functions that are hooked into this cyclic list should be
>>>>>> small timewise as otherwise the execution of the other code that relies
>>>>>> on a high frequent polling (e.g. UART rx char ready check) might be
>>>>>> delayed too much. This patch also adds the Kconfig option
>>>>>> CONFIG_CYCLIC_MAX_CPU_TIME_US, which configures the max allowed time
>>>>>> for such a cyclic function. If it's execution time exceeds this time,
>>>>>> this cyclic function will get removed from the cyclic list.
>>>>>>
>>>>>> [...]
>>>>>
>>>>> For the series, applied to u-boot/next, thanks!
>>>>
>>>> Thanks Tom.
>>>>
>>>> This patch series should not introduce any functional changes. The
>>>> next one though, which migrates the WATCHDOG_RESET into the cyclic
>>>> function execution IF needs a quite some testing. Perhaps it makes
>>>> sense to pull this other series as well quite early in the release
>>>> cycle, so that it receives a lot of "attention"? So that we have
>>>> time to fix potential problems here.
>>>>
>>>> What do you think?
>>>
>>> Yes, the watchdog series should come to next, for v2023.01 as well. Are
>>> you comfortable with it now, or are you planning to v2 it?
>>
>> I've only tested it on an MIPS Octeon platform so far. Where I am a bit
>> hesitant is, the very early watchdog integration and SPL. This
>> definitely needs some extensive testing. I don't have any platform
>> for this here ready right now.
>
> Once it is in -next, people will test it and we'll flush out any problems.
Yes, agreed. This is the way. ;)
Thanks,
Stefan
prev parent reply other threads:[~2022-09-15 4:58 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-02 11:57 [PATCH v6 0/8] Add support for cyclic function execution infrastruture Stefan Roese
2022-09-02 11:57 ` [PATCH v6 1/8] time: Import time_after64() and friends from Linux Stefan Roese
2022-09-02 11:57 ` [PATCH v6 2/8] cyclic: Add basic support for cyclic function execution infrastruture Stefan Roese
2022-09-02 11:57 ` [PATCH v6 3/8] cyclic: Integrate cyclic infrastructure into WATCHDOG_RESET Stefan Roese
2022-09-02 11:57 ` [PATCH v6 4/8] cyclic: Integrate cyclic functionality at bootup in board_r/f Stefan Roese
2022-09-02 11:57 ` [PATCH v6 5/8] cyclic: Add 'cyclic list' and 'cyclic demo' commands Stefan Roese
2022-09-02 11:57 ` [PATCH v6 6/8] mips: octeon_nic23: Add PCIe FLR fixup via cyclic infrastructure Stefan Roese
2022-09-02 11:57 ` [PATCH v6 7/8] cyclic: Add documentation Stefan Roese
2022-09-02 11:57 ` [PATCH v6 8/8] cyclic: Add a simple test Stefan Roese
2022-09-14 12:58 ` [PATCH v6 0/8] Add support for cyclic function execution infrastruture Tom Rini
2022-09-14 14:29 ` Stefan Roese
2022-09-14 14:47 ` Tom Rini
2022-09-14 15:18 ` Stefan Roese
2022-09-14 17:09 ` Simon Glass
2022-09-15 4:58 ` Stefan Roese [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fe10f3d4-847e-8863-7d0b-af4319d84119@denx.de \
--to=sr@denx.de \
--cc=awilliams@marvell.com \
--cc=cchavva@marvell.com \
--cc=sjg@chromium.org \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.