From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 133FBC2BD09 for ; Thu, 27 Jun 2024 16:57:02 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 628AD10E288; Thu, 27 Jun 2024 16:56:59 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="co43xkgV"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.16]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5E5AD10E259; Thu, 27 Jun 2024 16:56:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1719507418; x=1751043418; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=JHz6erOPmMXOL5HH5YPKI+H7g3zJvm9sN1WupPV1hrI=; b=co43xkgVyAoyiJiBjxThByfurLcFMS4B+KHPDxpA9FPLoj5+Y7ow2aNx lFqHaWg8KQIeSWN8ZaBPI347IjzCoU3DvoKSGmVQ30SwLRyxGFkyzhT/o HQMtD5Ul/doG3ART8eyj5ihVijaBsxSFNx75oHX5ZwduyHpDpaErA7TOf CcR4uYRalaIAWv92NOWD3AiVVGwzf+6vIRyL0/u1je1RG+Xhcp0Msr3qg SI9Yt5vvMLyilix/HSNYbdB6Vfh6CnziFoZFjZPiYTWWBqcl8xNJqj+oG KPDIK3XfVnQQueeveA7CP9nIgfnWeWe5H22uMDcrIaeejq1+K3mZtBgSw w==; X-CSE-ConnectionGUID: TTsdpKG9QKeXel2QaHZOsA== X-CSE-MsgGUID: BoIpgg0xRV+Lv5iiRzGmhg== X-IronPort-AV: E=McAfee;i="6700,10204,11116"; a="12286792" X-IronPort-AV: E=Sophos;i="6.09,166,1716274800"; d="scan'208";a="12286792" Received: from orviesa008.jf.intel.com ([10.64.159.148]) by fmvoesa110.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Jun 2024 09:56:57 -0700 X-CSE-ConnectionGUID: XYsooz17Q/C24f9E4U7VdQ== X-CSE-MsgGUID: 2KWJXXdKTaqzqKntxdLpIg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.09,166,1716274800"; d="scan'208";a="45202674" Received: from nirmoyda-mobl.ger.corp.intel.com (HELO [10.94.253.180]) ([10.94.253.180]) by orviesa008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Jun 2024 09:56:56 -0700 Message-ID: Date: Thu, 27 Jun 2024 18:56:53 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] drm/i915/gem: Suppress oom warning in favour of ENOMEM to userspace To: Andi Shyti , Nirmoy Das Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org References: <20240626143318.11600-1-nirmoy.das@intel.com> Content-Language: en-US From: Nirmoy Das In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Hi Andi, On 6/27/2024 12:04 PM, Andi Shyti wrote: > Hi Nirmoy, > > On Wed, Jun 26, 2024 at 04:33:18PM +0200, Nirmoy Das wrote: >> We report object allocation failures to userspace with ENOMEM >> so add __GFP_NOWARN to remove superfluous oom warnings. > I think this should be the default behavior. Yes, when drivers handle ENOMEM situation which is the case for i915/gem code > ENOMEM doesn't > necessarily mean that there is a kernel failure. Most of the time > we just run out of memory, deal with it :-) > > Reviewed-by: Andi Shyti Thanks! > > Thanks, > Andi