From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9E591C001DB for ; Mon, 14 Aug 2023 07:56:54 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.583356.913556 (Exim 4.92) (envelope-from ) id 1qVSRR-0000tN-2V; Mon, 14 Aug 2023 07:56:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 583356.913556; Mon, 14 Aug 2023 07:56:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qVSRQ-0000tG-W0; Mon, 14 Aug 2023 07:56:44 +0000 Received: by outflank-mailman (input) for mailman id 583356; Mon, 14 Aug 2023 07:56:44 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qVSRQ-0000t7-12 for xen-devel@lists.xenproject.org; Mon, 14 Aug 2023 07:56:44 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 1bc2a17c-3a78-11ee-b288-6b7b168915f2; Mon, 14 Aug 2023 09:56:43 +0200 (CEST) Received: from support.bugseng.com (support.bugseng.com [162.55.131.47]) by support.bugseng.com (Postfix) with ESMTPA id F0F1A4EE0737; Mon, 14 Aug 2023 09:56:42 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1bc2a17c-3a78-11ee-b288-6b7b168915f2 MIME-Version: 1.0 Date: Mon, 14 Aug 2023 09:56:42 +0200 From: Nicola Vetrini To: Jan Beulich Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, xen-devel@lists.xenproject.org Subject: Re: [XEN PATCH 6/6] drivers/video: make declarations of defined functions available In-Reply-To: References: User-Agent: Roundcube Webmail/1.4.3 Message-ID: X-Sender: nicola.vetrini@bugseng.com Organization: BUGSENG s.r.l. Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit On 14/08/2023 09:47, Jan Beulich wrote: > On 11.08.2023 09:19, Nicola Vetrini wrote: >> --- a/xen/drivers/video/vga.c >> +++ b/xen/drivers/video/vga.c >> @@ -9,6 +9,7 @@ >> #include >> #include >> #include >> +#include > > xen/vga.h, which you move the declarations to, is already included > here. > Why the need for xen/console.h? > > Jan vga.c needs a declaration for fill_console_start_info, which is declared in console.h, as stated in the commit message (it could be clarified perhaps). -- Nicola Vetrini, BSc Software Engineer, BUGSENG srl (https://bugseng.com)