From: Claudiu Beznea <claudiu.beznea@tuxon.dev>
To: Ryan.Wanner@microchip.com, andrew+netdev@lunn.ch,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org, nicolas.ferre@microchip.com,
alexandre.belloni@bootlin.com
Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 4/5] net: cadence: macb: sama7g5_emac: Remove USARIO CLKEN flag
Date: Fri, 18 Jul 2025 14:00:20 +0300 [thread overview]
Message-ID: <fe20bc48-8532-441d-bc40-e80dd6d30ee0@tuxon.dev> (raw)
In-Reply-To: <1e7a8c324526f631f279925aa8a6aa937d55c796.1752510727.git.Ryan.Wanner@microchip.com>
Hi, Ryan,
On 14.07.2025 19:37, Ryan.Wanner@microchip.com wrote:
> From: Ryan Wanner <Ryan.Wanner@microchip.com>
>
> Remove USARIO_CLKEN flag since this is now a device tree argument and
s/USARIO_CLKEN/USRIO_HAS_CLKEN here and in title as well.
> not fixed to the SoC.
>
> This will instead be selected by the "cdns,refclk-ext"
> device tree property.
>
> Signed-off-by: Ryan Wanner <Ryan.Wanner@microchip.com>
> ---
> drivers/net/ethernet/cadence/macb_main.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/cadence/macb_main.c b/drivers/net/ethernet/cadence/macb_main.c
> index 51667263c01d..cd54e4065690 100644
> --- a/drivers/net/ethernet/cadence/macb_main.c
> +++ b/drivers/net/ethernet/cadence/macb_main.c
> @@ -5113,8 +5113,7 @@ static const struct macb_config sama7g5_gem_config = {
>
> static const struct macb_config sama7g5_emac_config = {
> .caps = MACB_CAPS_USRIO_DEFAULT_IS_MII_GMII |
> - MACB_CAPS_USRIO_HAS_CLKEN | MACB_CAPS_MIIONRGMII |
Will old DTBs still work with new kernels with this change?
Thank you,
Claudiu
> - MACB_CAPS_GEM_HAS_PTP,
> + MACB_CAPS_MIIONRGMII | MACB_CAPS_GEM_HAS_PTP,
> .dma_burst_length = 16,
> .clk_init = macb_clk_init,
> .init = macb_init,
next prev parent reply other threads:[~2025-07-18 12:09 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-14 16:36 [PATCH v2 0/5] Expose REFCLK for RMII and enable RMII Ryan.Wanner
2025-07-14 16:36 ` [PATCH v2 1/5] dt-bindings: net: cdns,macb: Add external REFCLK property Ryan.Wanner
2025-07-14 16:37 ` [PATCH v2 2/5] net: cadence: macb: Expose REFCLK as a device tree property Ryan.Wanner
2025-07-14 16:37 ` [PATCH v2 3/5] net: cadence: macb: Enable RMII for SAMA7 gem Ryan.Wanner
2025-07-14 16:37 ` [PATCH v2 4/5] net: cadence: macb: sama7g5_emac: Remove USARIO CLKEN flag Ryan.Wanner
2025-07-18 11:00 ` Claudiu Beznea [this message]
2025-07-21 15:39 ` Ryan.Wanner
2025-07-26 12:56 ` claudiu beznea
2025-07-29 15:51 ` Ryan Wanner
2025-07-31 8:33 ` Claudiu Beznea
2025-07-14 16:37 ` [PATCH v2 5/5] ARM: dts: microchip: sama7g5: Add RMII ext refclk flag Ryan.Wanner
2025-07-17 0:40 ` [PATCH v2 0/5] Expose REFCLK for RMII and enable RMII patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fe20bc48-8532-441d-bc40-e80dd6d30ee0@tuxon.dev \
--to=claudiu.beznea@tuxon.dev \
--cc=Ryan.Wanner@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=andrew+netdev@lunn.ch \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nicolas.ferre@microchip.com \
--cc=pabeni@redhat.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.