From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1azglN-0008JZ-17
	for mharc-grub-devel@gnu.org; Mon, 09 May 2016 04:42:01 -0400
Received: from eggs.gnu.org ([2001:4830:134:3::10]:58332)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <list@xenhideout.nl>) id 1azglK-0008Gy-Ur
	for grub-devel@gnu.org; Mon, 09 May 2016 04:41:59 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <list@xenhideout.nl>) id 1azglE-0005US-PV
	for grub-devel@gnu.org; Mon, 09 May 2016 04:41:57 -0400
Received: from smtpgw.dds.nl ([91.142.252.201]:16009 helo=smtp1.dds.nl)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <list@xenhideout.nl>) id 1azglE-0005To-Fz
	for grub-devel@gnu.org; Mon, 09 May 2016 04:41:52 -0400
Received: from webmail.dds.nl (app1.dds.nl [81.21.136.61])
	by smtp1.dds.nl (Postfix) with ESMTP id E5BD27FBF9
	for <grub-devel@gnu.org>; Mon,  9 May 2016 10:41:46 +0200 (CEST)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 7bit
Date: Mon, 09 May 2016 10:41:46 +0200
From: Dryden Personalis <list@xenhideout.nl>
To: The development of GNU GRUB <grub-devel@gnu.org>
Subject: Re: [PATCH] Install to LVM PVs
In-Reply-To: <57302925.2000000@gmail.com>
References: <baeaa6d800c3efa6c1557cae48caa0f2@dds.nl>
	<572ED720.30800@gmail.com> <b0e98971a9db1d373f91d236a94644f5@dds.nl>
	<57302925.2000000@gmail.com>
Message-ID: <fe4753c68025fcb38fa99ae7ddf1e7ec@dds.nl>
X-Sender: list@xenhideout.nl
User-Agent: Roundcube Webmail/1.1.5
X-Virus-Scanned: clamav-milter 0.99.1 at smtp1
X-Virus-Status: Clean
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [generic]
X-Received-From: 91.142.252.201
X-BeenThere: grub-devel@gnu.org
X-Mailman-Version: 2.1.21
Precedence: list
List-Id: The development of GNU GRUB <grub-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/grub-devel>,
	<mailto:grub-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/grub-devel/>
List-Post: <mailto:grub-devel@gnu.org>
List-Help: <mailto:grub-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/grub-devel>,
	<mailto:grub-devel-request@gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 09 May 2016 08:41:59 -0000

Andrei Borzenkov schreef op 09-05-2016 8:07:

> No, I do not want to change it at all. It should remain as is and 
> always
> probe for FS so that test below actually works

But its output makes no sense, there cannot be a filesystem in a PV. It 
could check for existence of VG AND LV AND filesystem but does it do 
that right now?

Installing Grub is generally a non-destructive operation, apart from 
overwriting the boot sector.

Anyway my foot is hurting and I can't sit behind the computer, I will 
just show the code at some point so to discuss that alright.

>> I take it you mean:
>> 
>> if (!is_lvm && (ctx.multiple_partmaps || (ctx.dest_partmap && fs) ||
>> (is_ldm && fs)))
>> 
> 
> I mean
> 
> if (ctx.multiple_partmaps || (ctx.dest_partmap && fs) || ((is_ldm ||
> is_lvm) && fs))

Yes, I realized. Sorry.