All of lore.kernel.org
 help / color / mirror / Atom feed
From: bstroesser@ts.fujitsu.com
To: james.smart@avagotech.com, linux-scsi@vger.kernel.org
Cc: bstroesser@ts.fujitsu.com
Subject: [PATCH] lpfc: in sli3 use configured sg_seg_cnt for sg_tablesize
Date: 29 May 2015 14:22:44 +0200	[thread overview]
Message-ID: <fe5b2b$6sl0ed@dgate10u.abg.fsc.net> (raw)

Hi James,

We had some performance problems with RAID systems connected to LPe12k.
AFAICS, the reason is a small bug in lpfc.ko, causing the IO-size to
be smaller than expected.

The patch below fixes it for us.

Please CC me, I'm not on the list.

Best regards
Bodo


------------------------------------------------------

From: Bodo Stroesser <bstroesser@ts.fujitsu.com>
Date: Fri, 29 May 2015 13:34:19 +0200
Subject: [PATCH] lpfc: in sli3 use configured sg_seg_cnt for sg_tablesize

Currently the module parameter lpfc_sg_seg_count does not have effect
for sli3 devices.

In lpfc_sli_driver_resource_setup(), which is used for sli3, the code
writes the configured sg_seg_cnt into lpfc_template.sg_tablesize.
But lpfc_template is the template used for sli4 only. Thus the value should
correctly be written to lpfc_template_s3->sg_tablesize.

This patch is for kernel 4.1-rc5, but is tested with lpfc 10.2.405.26 only.

Signed-off-by: Bodo Stroesser <bstroesser@ts.fujitsu.com>
---

--- a/drivers/scsi/lpfc/lpfc_init.c	2015-05-29 10:19:02.000000000 +0200
+++ b/drivers/scsi/lpfc/lpfc_init.c	2015-05-29 10:19:56.000000000 +0200
@@ -4988,7 +4988,7 @@ lpfc_sli_driver_resource_setup(struct lp
 
 	/* Initialize the host templates the configured values. */
 	lpfc_vport_template.sg_tablesize = phba->cfg_sg_seg_cnt;
-	lpfc_template.sg_tablesize = phba->cfg_sg_seg_cnt;
+	lpfc_template_s3.sg_tablesize = phba->cfg_sg_seg_cnt;
 
 	/* There are going to be 2 reserved BDEs: 1 FCP cmnd + 1 FCP rsp */
 	if (phba->cfg_enable_bg) {

             reply	other threads:[~2015-05-29 12:32 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-29 12:22 bstroesser [this message]
2015-06-02 21:09 ` [PATCH] lpfc: in sli3 use configured sg_seg_cnt for sg_tablesize Sebastian Herbszt
     [not found] <10f4d2$5t7km8@dgate20u.abg.fsc.net>
2015-05-29 14:05 ` James Smart
2015-05-29 14:12   ` Strösser, Bodo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='fe5b2b$6sl0ed@dgate10u.abg.fsc.net' \
    --to=bstroesser@ts.fujitsu.com \
    --cc=james.smart@avagotech.com \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.