From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [PATCH -next] efi/libstub/tpm: Make function efi_retrieve_tpm2_eventlog_1_2() static
Date: Thu, 22 Mar 2018 14:06:27 +0000 [thread overview]
Message-ID: <fe665fc510d63fbc2d7b83ef7085d1e1ae5eec0b.camel@linux.intel.com> (raw)
In-Reply-To: <1521555478-29097-1-git-send-email-weiyongjun1@huawei.com>
On Tue, 2018-03-20 at 14:17 +0000, Wei Yongjun wrote:
> Fixes the following sparse warning:
>
> drivers/firmware/efi/libstub/tpm.c:62:6: warning:
> symbol 'efi_retrieve_tpm2_eventlog_1_2' was not declared. Should it be
> static?
>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
> drivers/firmware/efi/libstub/tpm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/firmware/efi/libstub/tpm.c
> b/drivers/firmware/efi/libstub/tpm.c
> index 9d08cea..caa37a6 100644
> --- a/drivers/firmware/efi/libstub/tpm.c
> +++ b/drivers/firmware/efi/libstub/tpm.c
> @@ -59,7 +59,7 @@ void efi_enable_reset_attack_mitigation(efi_system_table_t
> *sys_table_arg)
>
> #endif
>
> -void efi_retrieve_tpm2_eventlog_1_2(efi_system_table_t *sys_table_arg)
> +static void efi_retrieve_tpm2_eventlog_1_2(efi_system_table_t *sys_table_arg)
> {
> efi_guid_t tcg2_guid = EFI_TCG2_PROTOCOL_GUID;
> efi_guid_t linux_eventlog_guid = LINUX_EFI_TPM_EVENT_LOG_GUID;
>
Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
/Jarkko
next prev parent reply other threads:[~2018-03-22 14:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-20 14:17 [PATCH -next] efi/libstub/tpm: Make function efi_retrieve_tpm2_eventlog_1_2() static Wei Yongjun
2018-03-22 14:06 ` Jarkko Sakkinen [this message]
2018-03-22 14:09 ` Jarkko Sakkinen
2018-04-16 11:05 ` Ard Biesheuvel
2018-04-23 19:38 ` Jarkko Sakkinen
2018-04-24 6:39 ` Ard Biesheuvel
2018-05-01 11:41 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fe665fc510d63fbc2d7b83ef7085d1e1ae5eec0b.camel@linux.intel.com \
--to=jarkko.sakkinen@linux.intel.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.