From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 29434CEDDB7 for ; Thu, 10 Oct 2024 02:30:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:CC:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=mmkk8eKfudlLzhB6vZ+781ey1UwhCnHvrY9XM6r+YLQ=; b=H8xjl/5/Q9OuL2BdCeP/4KwhfC evGsh/FW6NFGJZbVMVegB7s8pop8aZvAH4PnmKRVj+TBp5bHDrRcGtdK19X+YUO4t2PMSfUrEFFTG o2/69Yod/0ieVrAHfknut1LqxHwG11tYe6gWnM2l83kHdp5NiznvPeYoH5HqYORLYEdFZAxlHaJ1U GkNAC8x0ilxt6FvAlxiPwy0n+pw+zGtxX5Obd8EfTvQYEIziTEj/0crZpvfLcdetZp4waJpsOuv+G 6RV4zLljihVSR4MZV3Mq1ge/NuA8a3OU84Ux7bvjhCQ7aVMXZzgvDyEazWVt5dZS7pgVl6L9+OGrg ntQqbolQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1syiwe-0000000BII6-35Pk; Thu, 10 Oct 2024 02:30:28 +0000 Received: from szxga04-in.huawei.com ([45.249.212.190]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1syiwa-0000000BIGN-0w3E for linux-mtd@lists.infradead.org; Thu, 10 Oct 2024 02:30:26 +0000 Received: from mail.maildlp.com (unknown [172.19.88.214]) by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4XPDGQ38Tyz2DdJt; Thu, 10 Oct 2024 10:29:02 +0800 (CST) Received: from kwepemk500005.china.huawei.com (unknown [7.202.194.90]) by mail.maildlp.com (Postfix) with ESMTPS id 85D871A016C; Thu, 10 Oct 2024 10:30:08 +0800 (CST) Received: from [10.174.178.46] (10.174.178.46) by kwepemk500005.china.huawei.com (7.202.194.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Thu, 10 Oct 2024 10:30:07 +0800 Subject: Re: [PATCH 1/1] ubifs: Try to recover from missing znode To: Benedikt Spranger CC: Richard Weinberger , linux-kernel , linux-mtd References: <20241008133342.1937674-1-b.spranger@linutronix.de> <0840be30-63bc-449d-a9a4-c4e6b54c8885@huawei.com> <883601802.30668.1728453832223.JavaMail.zimbra@nod.at> <351bdd98-98ac-036f-4685-56e88a102cf3@huawei.com> <20241009144900.367f9cb4@mitra> From: Zhihao Cheng Message-ID: Date: Thu, 10 Oct 2024 10:30:07 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <20241009144900.367f9cb4@mitra> X-Originating-IP: [10.174.178.46] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To kwepemk500005.china.huawei.com (7.202.194.90) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241009_193024_812870_F58C1CB5 X-CRM114-Status: GOOD ( 17.04 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org 5ZyoIDIwMjQvMTAvOSAyMDo0OSwgQmVuZWRpa3QgU3ByYW5nZXIg5YaZ6YGTOgo+IE9uIFdlZCwg OSBPY3QgMjAyNCAxODo0Njo0MyArMDgwMAo+IFpoaWhhbyBDaGVuZyA8Y2hlbmd6aGloYW8xQGh1 YXdlaS5jb20+IHdyb3RlOgo+IAo+PiDlnKggMjAyNC8xMC85IDE0OjAzLCBSaWNoYXJkIFdlaW5i ZXJnZXIg5YaZ6YGTOgo+Pj4gLS0tLS0gVXJzcHLDvG5nbGljaGUgTWFpbCAtLS0tLQo+Pj4+IFZv bjogImNoZW5nemhpaGFvMSIgPGNoZW5nemhpaGFvMUBodWF3ZWkuY29tPgo+Pj4+IEFuOiAiQmVu ZWRpa3QgU3ByYW5nZXIiIDxiLnNwcmFuZ2VyQGxpbnV0cm9uaXguZGU+LCAibGludXgta2VybmVs Igo+Pj4+IDxsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnPiBDQzogImxpbnV4LW10ZCIKPj4+ PiA8bGludXgtbXRkQGxpc3RzLmluZnJhZGVhZC5vcmc+LCAicmljaGFyZCIgPHJpY2hhcmRAbm9k LmF0Pgo+Pj4+IEdlc2VuZGV0OiBNaXR0d29jaCwgOS4gT2t0b2JlciAyMDI0IDA0OjIzOjAyIEJl dHJlZmY6IFJlOiBbUEFUQ0gKPj4+PiAxLzFdIHViaWZzOiBUcnkgdG8gcmVjb3ZlciBmcm9tIG1p c3Npbmcgem5vZGUKPj4+Cj4+Pj4g5ZyoIDIwMjQvMTAvOCAyMTozMywgQmVuZWRpa3QgU3ByYW5n ZXIg5YaZ6YGTOgo+Pj4+PiBBZnRlciBwb3dlcmN1dCBvbiBhIHN5c3RlbSB1c2luZyB1YmlmcyBt b3VudGluZyBmYWlsZWQ6Cj4+Pj4+Cj4+Pj4+IDIwMjQtMDktMzBUMTI6Mzg6MjYuODgwNDg3KzAy OjAwIHNvbmphIGtlcm5lbDogVUJJRlMgZXJyb3IKPj4+Pj4gKHViaTA6MCBwaWQgMjE3OCk6IHVi aWZzX3JlYWRfbm9kZSBbdWJpZnNdOiBiYWQgbm9kZSB0eXBlICgyNTUKPj4+Pj4gYnV0IGV4cGVj dGVkIDkpIDIwMjQtMDktMzBUMTI6Mzg6MjYuODgwNTA2KzAyOjAwIHNvbmphIGtlcm5lbDoKPj4+ Pj4gVUJJRlMgZXJyb3IgKHViaTA6MCBwaWQgMjE3OCk6IHViaWZzX3JlYWRfbm9kZSBbdWJpZnNd OiBiYWQgbm9kZQo+Pj4+PiBhdCBMRUIgMTAzOjQ2OTIwLCBMRUIgbWFwcGluZyBzdGF0dXMgMAo+ Pj4+PiAyMDI0LTA5LTMwVDEyOjM4OjI2Ljg4MDUwOSswMjowMCBzb25qYSBrZXJuZWw6IE5vdCBh IG5vZGUsIGZpcnN0Cj4+Pj4+IDI0IGJ5dGVzOiAyMDI0LTA5LTMwVDEyOjM4OjI2Ljg4MDUxMCsw MjowMCBzb25qYSBrZXJuZWw6Cj4+Pj4+IDAwMDAwMDAwOiBmZiBmZiBmZiBmZiBmZiBmZiBmZiBm ZiBmZiBmZiBmZiBmZiBmZiBmZiBmZiBmZiBmZiBmZgo+Pj4+PiBmZiBmZiBmZiBmZiBmZiBmZiAu Li4uLi4uLi4uLi4uLi4uLi4uLi4uLi4KPj4+Pj4KPj4+Pj4gV2hpbGUgdHJhdmVyc2luZyBvdmVy IHpicmFuY2hlcyBkdXJpbmcgdGhlIGpvdXJuYWwgcmVwbGF5IG9uZQo+Pj4+PiB6YnJhbmNoIHBv aW50cyB0byBhIHpub2RlLCB3aGljaCB3YXMgbm90IHdyaXR0ZW4gdG8gdGhlIGZsYXNoIGFuZAo+ Pj4+PiB0aGVyZWZvcmUgdGhlIGZsYXNoIGlzIGVtcHR5Lgo+Pj4+Cj4+Pj4gVUJJRlMgZ3VhcmFu dGVlcyB0d28gdGhpbmdzIGZvciB6bm9kZXM6Cj4+Pj4gMSkgYWxsIGluZGV4IG5vZGVzKGluIGNv bW1pdCBzZXEgTikgYXJlIHdyaXR0ZW4gb24gZmxhc2ggYmVmb3JlCj4+Pj4gbWFzdGVyIG5vZGVz KGZvciBjb21taXQgc2VxIE4pIGFyZSB3cml0dGVuLgo+Pj4+IDIpIGFsbCBpbmRleCBub2Rlcyhp biBjb21taXQgc2VxIE4pIHdvbid0IGJlIGVyYXNlZCBmcm9tIGZsYXNoCj4+Pj4gYmVmb3JlIG1h c3RlciBub2Rlcyhmb3IgY29tbWl0IHNlcSBOKzEpIGFyZSB3cml0dGVuLgo+Pj4+IFNvLCBJIGRv bid0IHVuZGVyc3RhbmQgdGhhdCB3aHkgem5vZGVzIG5vdCBleGlzdCBkdXJpbmcgam91cm5hbAo+ Pj4+IHJlcGxheWluZz8KPj4+Cj4+PiBJbiBhZGRpdGlvbiB0byB0aGF0LCBpcyBqdXN0IG9uZSB6 bm9kZSBtaXNzaW5nIG9yIGFyZSBsYXJnZXIgcGFydHMKPj4+IG9mIHRoZSBmbGFzaCBlbXB0eT8K PiAKPiBTb21lIGJhY2tncm91bmQ6Cj4gVGhlIHN5c3RlbSBwcm9kdWNpbmcgdGhlIGJyb2tlbiBp bWFnZSBydW5zIG9uIGFuIG9sZGVyIGtlcm5lbCB2ZXJzaW9uCj4gKDQuOS4yODYtcnQxODkpLiBB dHRhY2hpbmcgVUJJIHBlcmZvcm1zIHdpdGhvdXQgYW55IGVycm9yLiBJdCBzZWVtcywKPiB0aGF0 IHRoZXJlIGlzIG9ubHkgb25lIHpub2RlIG1pc3NpbmcuIFRoZXJlIGFyZSBlbXB0eSBwYXJ0cyBv biB0aGUKPiBmbGFzaCwgYnV0IGFzIGZhciBhcyBJIGNhbiBzZWUgYWxsIFBFQnMgaGF2ZSBVQkkg aGVhZGVyIEluZm9ybWF0aW9uLgo+IFRoZSBtaXNzaW5nIHpub2RlIGlzIHNvbWV3aGVyZSBpbiB0 aCBtaWRkbGUgb2YgYW4gUEVCIGFuZCBvdGhlciB6bm9kZXMKPiBhcmUgaW4gdGhhdCBQRUIuCj4g Cj4+IEFmdGVyIHJldmlld2luZyB0aGUgVE5DIHJlbGF0ZWQgY29kZSwgSSBjYW5ub3QgZmluZCBv dXQgYW55IGlsbGVnYWwKPj4gYmVoYXZpb3JzIHRvIG1ha2Ugem5vZGUgbG9zdCBvciB2YWxpZCBp bmRleCBMRUIgZXJhc2VkLgo+IE9LLiBJcyBpdCBwb3NzaWJsZSwgdGhhdCB0aGlzIGJlaGF2aW91 ciBpcyBjYXVzZWQgYnkgYSBhbHJlYWR5IGZpeGVkCj4gYnVnPyBUaGlzIGhhcHBlbmQgb24gYSBz eXN0ZW0gcnVubmluZyA0LjkuMjg2LXJ0MTg5LgoKSSBmb3VuZCBvbmUgcGF0Y2ggWzFdLCB3aGlj aCBmaXhlcyBhIGRhdGEgbG9zdCBwcm9ibGVtIHdoaWxlIHdyaXRpbmcgZmFpbGVkLgoKWzFdIApo dHRwczovL2dpdC5rZXJuZWwub3JnL3B1Yi9zY20vbGludXgva2VybmVsL2dpdC90b3J2YWxkcy9s aW51eC5naXQvY29tbWl0Lz9oPXY2LjEyLXJjMiZpZD0zMWExNDlkNWMxM2M0Y2JjZjk3ZGUzNDM1 ODE3MjYzYTJkOGM5ZDZlCj4gCj4+IEhpIEJlbmVkaWt0LCBjb3VsZCB5b3UgcHJvdmlkZSBhIGNv cnJ1cHRlZCBVQklGUyBpbWFnZT8gTGV0IG1lIHRyeQo+PiBnZXR0aW5nIG1vcmUgaW5mb3JtYXRp b24uCj4gSSBuZWVkIHRvIGNsYXJpZnkgdGhpcy4KPiAKPiBSZWdhcmRzCj4gICAgICBCZW5lZGlr dCBTcHJhbmdlcgo+IC4KPiAKCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX18KTGludXggTVREIGRpc2N1c3Npb24gbWFpbGluZyBsaXN0Cmh0dHA6 Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtbXRkLwo= From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from szxga04-in.huawei.com (szxga04-in.huawei.com [45.249.212.190]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0350438396 for ; Thu, 10 Oct 2024 02:30:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=45.249.212.190 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728527419; cv=none; b=AMWjE4lbAGfT/6yGed8e4JuXSh3Mf0XxCprIppJ3+Mrmca540GA41mEME378DxN9L4lsz7pcL/sqW9x2G8dY/w+3H4A58/u6Qu9cQ1P7Q5IqntYOR9+MXBg+2uuw4kATwmLjPOopgCk943SyVOsWGoia7NQ7D6hei3Trqcvyn4w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728527419; c=relaxed/simple; bh=jQHLJebipjWC3RG6zINB7NPrCE3n4F4AfAURhsXbxxE=; h=Subject:To:CC:References:From:Message-ID:Date:MIME-Version: In-Reply-To:Content-Type; b=ftO4sJj5/sGxwE7CmCOQBY2u+Ihvw4VrPalZbTEsyNPXDAuKfBitwKYbepiDqWxFQh6pDJFYbRPSdwxpX8S2RFv9sLhFdb5aWUFqEQ2rHMlwrPKWGZctGHy3293FvDzIQUJgMdse3poiNeKQaCXlAWBxMInJ5t5FokDG20V4Tqk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com; spf=pass smtp.mailfrom=huawei.com; arc=none smtp.client-ip=45.249.212.190 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huawei.com Received: from mail.maildlp.com (unknown [172.19.88.214]) by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4XPDGQ38Tyz2DdJt; Thu, 10 Oct 2024 10:29:02 +0800 (CST) Received: from kwepemk500005.china.huawei.com (unknown [7.202.194.90]) by mail.maildlp.com (Postfix) with ESMTPS id 85D871A016C; Thu, 10 Oct 2024 10:30:08 +0800 (CST) Received: from [10.174.178.46] (10.174.178.46) by kwepemk500005.china.huawei.com (7.202.194.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Thu, 10 Oct 2024 10:30:07 +0800 Subject: Re: [PATCH 1/1] ubifs: Try to recover from missing znode To: Benedikt Spranger CC: Richard Weinberger , linux-kernel , linux-mtd References: <20241008133342.1937674-1-b.spranger@linutronix.de> <0840be30-63bc-449d-a9a4-c4e6b54c8885@huawei.com> <883601802.30668.1728453832223.JavaMail.zimbra@nod.at> <351bdd98-98ac-036f-4685-56e88a102cf3@huawei.com> <20241009144900.367f9cb4@mitra> From: Zhihao Cheng Message-ID: Date: Thu, 10 Oct 2024 10:30:07 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 In-Reply-To: <20241009144900.367f9cb4@mitra> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To kwepemk500005.china.huawei.com (7.202.194.90) 在 2024/10/9 20:49, Benedikt Spranger 写道: > On Wed, 9 Oct 2024 18:46:43 +0800 > Zhihao Cheng wrote: > >> 在 2024/10/9 14:03, Richard Weinberger 写道: >>> ----- Ursprüngliche Mail ----- >>>> Von: "chengzhihao1" >>>> An: "Benedikt Spranger" , "linux-kernel" >>>> CC: "linux-mtd" >>>> , "richard" >>>> Gesendet: Mittwoch, 9. Oktober 2024 04:23:02 Betreff: Re: [PATCH >>>> 1/1] ubifs: Try to recover from missing znode >>> >>>> 在 2024/10/8 21:33, Benedikt Spranger 写道: >>>>> After powercut on a system using ubifs mounting failed: >>>>> >>>>> 2024-09-30T12:38:26.880487+02:00 sonja kernel: UBIFS error >>>>> (ubi0:0 pid 2178): ubifs_read_node [ubifs]: bad node type (255 >>>>> but expected 9) 2024-09-30T12:38:26.880506+02:00 sonja kernel: >>>>> UBIFS error (ubi0:0 pid 2178): ubifs_read_node [ubifs]: bad node >>>>> at LEB 103:46920, LEB mapping status 0 >>>>> 2024-09-30T12:38:26.880509+02:00 sonja kernel: Not a node, first >>>>> 24 bytes: 2024-09-30T12:38:26.880510+02:00 sonja kernel: >>>>> 00000000: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff >>>>> ff ff ff ff ff ff ........................ >>>>> >>>>> While traversing over zbranches during the journal replay one >>>>> zbranch points to a znode, which was not written to the flash and >>>>> therefore the flash is empty. >>>> >>>> UBIFS guarantees two things for znodes: >>>> 1) all index nodes(in commit seq N) are written on flash before >>>> master nodes(for commit seq N) are written. >>>> 2) all index nodes(in commit seq N) won't be erased from flash >>>> before master nodes(for commit seq N+1) are written. >>>> So, I don't understand that why znodes not exist during journal >>>> replaying? >>> >>> In addition to that, is just one znode missing or are larger parts >>> of the flash empty? > > Some background: > The system producing the broken image runs on an older kernel version > (4.9.286-rt189). Attaching UBI performs without any error. It seems, > that there is only one znode missing. There are empty parts on the > flash, but as far as I can see all PEBs have UBI header Information. > The missing znode is somewhere in th middle of an PEB and other znodes > are in that PEB. > >> After reviewing the TNC related code, I cannot find out any illegal >> behaviors to make znode lost or valid index LEB erased. > OK. Is it possible, that this behaviour is caused by a already fixed > bug? This happend on a system running 4.9.286-rt189. I found one patch [1], which fixes a data lost problem while writing failed. [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?h=v6.12-rc2&id=31a149d5c13c4cbcf97de3435817263a2d8c9d6e > >> Hi Benedikt, could you provide a corrupted UBIFS image? Let me try >> getting more information. > I need to clarify this. > > Regards > Benedikt Spranger > . >